* [PATCH] staging: rts5208: Lines should not end with a '('
@ 2019-03-14 15:00 Branden Bonaby
2019-03-14 15:03 ` [Outreachy kernel] " Julia Lawall
2019-03-14 15:28 ` [PATCH v2] " Branden Bonaby
0 siblings, 2 replies; 4+ messages in thread
From: Branden Bonaby @ 2019-03-14 15:00 UTC (permalink / raw)
To: gregkh; +Cc: Branden Bonaby, outreachy-kernel
Start function arguments after initial bracket so that the
line does not end with a opening bracket.
CHECK: Lines should not end with a '('
Signed-off-by: Branden Bonaby <brandonbonaby94@gmail.com>
---
drivers/staging/rts5208/rtsx_transport.c | 16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rts5208/rtsx_transport.c b/drivers/staging/rts5208/rtsx_transport.c
index 8277d7895608..d2c1dfcb95e4 100644
--- a/drivers/staging/rts5208/rtsx_transport.c
+++ b/drivers/staging/rts5208/rtsx_transport.c
@@ -257,8 +257,9 @@ int rtsx_send_cmd(struct rtsx_chip *chip, u8 card, int timeout)
spin_unlock_irq(&rtsx->reg_lock);
/* Wait for TRANS_OK_INT */
- timeleft = wait_for_completion_interruptible_timeout(
- &trans_done, msecs_to_jiffies(timeout));
+ timeleft =
+ wait_for_completion_interruptible_timeout(&trans_done,
+ msecs_to_jiffies(timeout));
if (timeleft <= 0) {
dev_dbg(rtsx_dev(chip), "chip->int_reg = 0x%x\n",
chip->int_reg);
@@ -284,8 +285,10 @@ int rtsx_send_cmd(struct rtsx_chip *chip, u8 card, int timeout)
return err;
}
-static inline void rtsx_add_sg_tbl(
- struct rtsx_chip *chip, u32 addr, u32 len, u8 option)
+static inline void rtsx_add_sg_tbl(struct rtsx_chip *chip,
+ u32 addr,
+ u32 len,
+ u8 option)
{
__le64 *sgb = (__le64 *)(chip->host_sg_tbl_ptr);
u64 val = 0;
@@ -420,8 +423,9 @@ static int rtsx_transfer_sglist_adma_partial(struct rtsx_chip *chip, u8 card,
spin_unlock_irq(&rtsx->reg_lock);
- timeleft = wait_for_completion_interruptible_timeout(
- &trans_done, msecs_to_jiffies(timeout));
+ timeleft =
+ wait_for_completion_interruptible_timeout(&trans_done,
+ msecs_to_jiffies(timeout));
if (timeleft <= 0) {
dev_dbg(rtsx_dev(chip), "Timeout (%s %d)\n",
__func__, __LINE__);
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Outreachy kernel] [PATCH] staging: rts5208: Lines should not end with a '('
2019-03-14 15:00 [PATCH] staging: rts5208: Lines should not end with a '(' Branden Bonaby
@ 2019-03-14 15:03 ` Julia Lawall
2019-03-14 15:28 ` [PATCH v2] " Branden Bonaby
1 sibling, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2019-03-14 15:03 UTC (permalink / raw)
To: Branden Bonaby; +Cc: gregkh, outreachy-kernel
On Thu, 14 Mar 2019, Branden Bonaby wrote:
> Start function arguments after initial bracket so that the
> line does not end with a opening bracket.
> CHECK: Lines should not end with a '('
>
> Signed-off-by: Branden Bonaby <brandonbonaby94@gmail.com>
> ---
> drivers/staging/rts5208/rtsx_transport.c | 16 ++++++++++------
> 1 file changed, 10 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/rts5208/rtsx_transport.c b/drivers/staging/rts5208/rtsx_transport.c
> index 8277d7895608..d2c1dfcb95e4 100644
> --- a/drivers/staging/rts5208/rtsx_transport.c
> +++ b/drivers/staging/rts5208/rtsx_transport.c
> @@ -257,8 +257,9 @@ int rtsx_send_cmd(struct rtsx_chip *chip, u8 card, int timeout)
> spin_unlock_irq(&rtsx->reg_lock);
>
> /* Wait for TRANS_OK_INT */
> - timeleft = wait_for_completion_interruptible_timeout(
> - &trans_done, msecs_to_jiffies(timeout));
> + timeleft =
> + wait_for_completion_interruptible_timeout(&trans_done,
> + msecs_to_jiffies(timeout));
> if (timeleft <= 0) {
> dev_dbg(rtsx_dev(chip), "chip->int_reg = 0x%x\n",
> chip->int_reg);
> @@ -284,8 +285,10 @@ int rtsx_send_cmd(struct rtsx_chip *chip, u8 card, int timeout)
> return err;
> }
>
> -static inline void rtsx_add_sg_tbl(
> - struct rtsx_chip *chip, u32 addr, u32 len, u8 option)
> +static inline void rtsx_add_sg_tbl(struct rtsx_chip *chip,
> + u32 addr,
> + u32 len,
> + u8 option)
There is no actual need to have one parameter per line. Is this what is
done elsewhere in the file or in the driver?
julia
> {
> __le64 *sgb = (__le64 *)(chip->host_sg_tbl_ptr);
> u64 val = 0;
> @@ -420,8 +423,9 @@ static int rtsx_transfer_sglist_adma_partial(struct rtsx_chip *chip, u8 card,
>
> spin_unlock_irq(&rtsx->reg_lock);
>
> - timeleft = wait_for_completion_interruptible_timeout(
> - &trans_done, msecs_to_jiffies(timeout));
> + timeleft =
> + wait_for_completion_interruptible_timeout(&trans_done,
> + msecs_to_jiffies(timeout));
> if (timeleft <= 0) {
> dev_dbg(rtsx_dev(chip), "Timeout (%s %d)\n",
> __func__, __LINE__);
> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190314150017.25470-1-brandonbonaby94%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH v2] staging: rts5208: Lines should not end with a '('
2019-03-14 15:00 [PATCH] staging: rts5208: Lines should not end with a '(' Branden Bonaby
2019-03-14 15:03 ` [Outreachy kernel] " Julia Lawall
@ 2019-03-14 15:28 ` Branden Bonaby
2019-03-17 10:47 ` Greg KH
1 sibling, 1 reply; 4+ messages in thread
From: Branden Bonaby @ 2019-03-14 15:28 UTC (permalink / raw)
To: gregkh; +Cc: Branden Bonaby, outreachy-kernel
Start function arguments after initial bracket so that the
line does not end with a opening bracket.
CHECK: Lines should not end with a '('
Signed-off-by: Branden Bonaby <brandonbonaby94@gmail.com>
---
Changes in v2:
Moved function arguments that do not go over the
80 character a line limit, to the same line as the
function name.
drivers/staging/rts5208/rtsx_transport.c | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rts5208/rtsx_transport.c b/drivers/staging/rts5208/rtsx_transport.c
index 8277d7895608..a476e22767e9 100644
--- a/drivers/staging/rts5208/rtsx_transport.c
+++ b/drivers/staging/rts5208/rtsx_transport.c
@@ -257,8 +257,9 @@ int rtsx_send_cmd(struct rtsx_chip *chip, u8 card, int timeout)
spin_unlock_irq(&rtsx->reg_lock);
/* Wait for TRANS_OK_INT */
- timeleft = wait_for_completion_interruptible_timeout(
- &trans_done, msecs_to_jiffies(timeout));
+ timeleft =
+ wait_for_completion_interruptible_timeout(&trans_done,
+ msecs_to_jiffies(timeout));
if (timeleft <= 0) {
dev_dbg(rtsx_dev(chip), "chip->int_reg = 0x%x\n",
chip->int_reg);
@@ -284,8 +285,8 @@ int rtsx_send_cmd(struct rtsx_chip *chip, u8 card, int timeout)
return err;
}
-static inline void rtsx_add_sg_tbl(
- struct rtsx_chip *chip, u32 addr, u32 len, u8 option)
+static inline void rtsx_add_sg_tbl(struct rtsx_chip *chip, u32 addr, u32 len,
+ u8 option)
{
__le64 *sgb = (__le64 *)(chip->host_sg_tbl_ptr);
u64 val = 0;
@@ -420,8 +421,9 @@ static int rtsx_transfer_sglist_adma_partial(struct rtsx_chip *chip, u8 card,
spin_unlock_irq(&rtsx->reg_lock);
- timeleft = wait_for_completion_interruptible_timeout(
- &trans_done, msecs_to_jiffies(timeout));
+ timeleft =
+ wait_for_completion_interruptible_timeout(&trans_done,
+ msecs_to_jiffies(timeout));
if (timeleft <= 0) {
dev_dbg(rtsx_dev(chip), "Timeout (%s %d)\n",
__func__, __LINE__);
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] staging: rts5208: Lines should not end with a '('
2019-03-14 15:28 ` [PATCH v2] " Branden Bonaby
@ 2019-03-17 10:47 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2019-03-17 10:47 UTC (permalink / raw)
To: Branden Bonaby; +Cc: outreachy-kernel
On Thu, Mar 14, 2019 at 11:28:28AM -0400, Branden Bonaby wrote:
> Start function arguments after initial bracket so that the
> line does not end with a opening bracket.
> CHECK: Lines should not end with a '('
>
> Signed-off-by: Branden Bonaby <brandonbonaby94@gmail.com>
> ---
> Changes in v2:
> Moved function arguments that do not go over the
> 80 character a line limit, to the same line as the
> function name.
>
> drivers/staging/rts5208/rtsx_transport.c | 14 ++++++++------
> 1 file changed, 8 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/rts5208/rtsx_transport.c b/drivers/staging/rts5208/rtsx_transport.c
> index 8277d7895608..a476e22767e9 100644
> --- a/drivers/staging/rts5208/rtsx_transport.c
> +++ b/drivers/staging/rts5208/rtsx_transport.c
> @@ -257,8 +257,9 @@ int rtsx_send_cmd(struct rtsx_chip *chip, u8 card, int timeout)
> spin_unlock_irq(&rtsx->reg_lock);
>
> /* Wait for TRANS_OK_INT */
> - timeleft = wait_for_completion_interruptible_timeout(
> - &trans_done, msecs_to_jiffies(timeout));
> + timeleft =
> + wait_for_completion_interruptible_timeout(&trans_done,
Indenting 4 spaces is not acceptable coding style, sorry.
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-03-17 10:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-14 15:00 [PATCH] staging: rts5208: Lines should not end with a '(' Branden Bonaby
2019-03-14 15:03 ` [Outreachy kernel] " Julia Lawall
2019-03-14 15:28 ` [PATCH v2] " Branden Bonaby
2019-03-17 10:47 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.