From: Greg KH <gregkh@linuxfoundation.org>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] staging: sm759fb: fix camelcase check issue
Date: Sun, 17 Mar 2019 11:00:22 +0000 [thread overview]
Message-ID: <20190317110022.GA10411@kroah.com> (raw)
In-Reply-To: <20190316000109.22244-1-jbi.octave@gmail.com>
On Sat, Mar 16, 2019 at 12:01:09AM +0000, Jules Irenge wrote:
> Lower case of parameters to fix camelcase warning
> Issue reported by checkpatch.pl tool
>
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> ---
> drivers/staging/sm750fb/ddk750_chip.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
> index 4c1f00f551da..6bdf643707c2 100644
> --- a/drivers/staging/sm750fb/ddk750_chip.c
> +++ b/drivers/staging/sm750fb/ddk750_chip.c
> @@ -15,14 +15,14 @@ enum logical_chip_type sm750_get_chip_type(void)
> return chip;
> }
>
> -void sm750_set_chip_type(unsigned short devId, u8 revId)
> +void sm750_set_chip_type(unsigned short dev_id, u8 rev_id)
> {
> - if (devId = 0x718) {
> + if (dev_id = 0x718) {
> chip = SM718;
> - } else if (devId = 0x750) {
> + } else if (dev_id = 0x750) {
> chip = SM750;
> /* SM750 and SM750LE are different in their revision ID only. */
> - if (revId = SM750LE_REVISION_ID) {
> + if (rev_id = SM750LE_REVISION_ID) {
> chip = SM750LE;
> pr_info("found sm750le\n");
> }
> --
> 2.20.1
>
This patch does not apply to my tree at all :(
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Jules Irenge <jbi.octave@gmail.com>
Cc: linux-fbdev@vger.kernel.org, outreachy-kernel@googlegroups.com
Subject: Re: [PATCH] staging: sm759fb: fix camelcase check issue
Date: Sun, 17 Mar 2019 12:00:22 +0100 [thread overview]
Message-ID: <20190317110022.GA10411@kroah.com> (raw)
In-Reply-To: <20190316000109.22244-1-jbi.octave@gmail.com>
On Sat, Mar 16, 2019 at 12:01:09AM +0000, Jules Irenge wrote:
> Lower case of parameters to fix camelcase warning
> Issue reported by checkpatch.pl tool
>
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> ---
> drivers/staging/sm750fb/ddk750_chip.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
> index 4c1f00f551da..6bdf643707c2 100644
> --- a/drivers/staging/sm750fb/ddk750_chip.c
> +++ b/drivers/staging/sm750fb/ddk750_chip.c
> @@ -15,14 +15,14 @@ enum logical_chip_type sm750_get_chip_type(void)
> return chip;
> }
>
> -void sm750_set_chip_type(unsigned short devId, u8 revId)
> +void sm750_set_chip_type(unsigned short dev_id, u8 rev_id)
> {
> - if (devId == 0x718) {
> + if (dev_id == 0x718) {
> chip = SM718;
> - } else if (devId == 0x750) {
> + } else if (dev_id == 0x750) {
> chip = SM750;
> /* SM750 and SM750LE are different in their revision ID only. */
> - if (revId == SM750LE_REVISION_ID) {
> + if (rev_id == SM750LE_REVISION_ID) {
> chip = SM750LE;
> pr_info("found sm750le\n");
> }
> --
> 2.20.1
>
This patch does not apply to my tree at all :(
next prev parent reply other threads:[~2019-03-17 11:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-16 0:01 [PATCH] staging: sm759fb: fix camelcase check issue Jules Irenge
2019-03-16 0:01 ` Jules Irenge
2019-03-16 22:50 ` Tom Li
2019-03-16 22:50 ` Tom Li
2019-03-17 11:00 ` Greg KH [this message]
2019-03-17 11:00 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190317110022.GA10411@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.