From: Greg KH <gregkh@linuxfoundation.org>
To: Jules Irenge <jbi.octave@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [PATCH 1/2] staging: speakup: fix line over 80 characters.
Date: Sun, 17 Mar 2019 12:42:47 +0100 [thread overview]
Message-ID: <20190317114247.GD3160@kroah.com> (raw)
In-Reply-To: <20190317112857.18220-1-jbi.octave@gmail.com>
On Sun, Mar 17, 2019 at 11:28:56AM +0000, Jules Irenge wrote:
> Fix coding style issues, which solves checkpatch.pl warning:
> "WARNING: line over 80 characters".
> ---
> drivers/staging/speakup/kobjects.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
No signed off by?
>
> diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c
> index 11c704b27c3c..53c8793c382f 100644
> --- a/drivers/staging/speakup/kobjects.c
> +++ b/drivers/staging/speakup/kobjects.c
> @@ -154,7 +154,7 @@ static ssize_t chars_chartab_store(struct kobject *kobj,
> continue;
> }
>
> - /* Do not replace with kstrtoul: here we need temp to be updated */
> + /* Do not replace with kstrtoul: temp need to be updated */
Original text is better than this, I do not know what your shortening of
the line now means :(
thanks,
greg k-h
prev parent reply other threads:[~2019-03-17 11:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-17 11:28 [PATCH 1/2] staging: speakup: fix line over 80 characters Jules Irenge
2019-03-17 11:28 ` [PATCH 2/2] " Jules Irenge
2019-03-17 11:43 ` Greg KH
2019-03-17 11:35 ` [Outreachy kernel] [PATCH 1/2] " Julia Lawall
2019-03-17 11:42 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190317114247.GD3160@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jbi.octave@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.