All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Jules Irenge <jbi.octave@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [PATCH 2/2] staging: speakup: fix line over 80 characters.
Date: Sun, 17 Mar 2019 12:43:19 +0100	[thread overview]
Message-ID: <20190317114319.GE3160@kroah.com> (raw)
In-Reply-To: <20190317112857.18220-2-jbi.octave@gmail.com>

On Sun, Mar 17, 2019 at 11:28:57AM +0000, Jules Irenge wrote:
> Fix coding style issues which solves checkpatch.pl warning:
>     "WARNING: line over 80 characters".
> 
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> ---
>  drivers/staging/speakup/kobjects.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c
> index 53c8793c382f..1c3b0a257fe5 100644
> --- a/drivers/staging/speakup/kobjects.c
> +++ b/drivers/staging/speakup/kobjects.c
> @@ -788,7 +788,7 @@ static ssize_t message_store_helper(const char *buf, size_t count,
>  			continue;
>  		}
>  
> -		/* Do not replace with kstrtoul: here we need temp to be updated */
> +		/* Do not replace with kstrtoul: temp need to be updated */

You sent 2 patches that did different things, yet they had the same
subject line?

Also, again, the original is better.

thanks,

greg k-h


  reply	other threads:[~2019-03-17 11:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-17 11:28 [PATCH 1/2] staging: speakup: fix line over 80 characters Jules Irenge
2019-03-17 11:28 ` [PATCH 2/2] " Jules Irenge
2019-03-17 11:43   ` Greg KH [this message]
2019-03-17 11:35 ` [Outreachy kernel] [PATCH 1/2] " Julia Lawall
2019-03-17 11:42 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190317114319.GE3160@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=jbi.octave@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.