From: Thierry Reding <thierry.reding@gmail.com>
To: Anson Huang <anson.huang@nxp.com>
Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"otavio@ossystems.com.br" <otavio@ossystems.com.br>,
"stefan@agner.ch" <stefan@agner.ch>,
Leonard Crestez <leonard.crestez@nxp.com>,
Robin Gong <yibin.gong@nxp.com>,
"jan.tuerk@emtrion.com" <jan.tuerk@emtrion.com>,
"linux-pwm@vger.kernel.org" <linux-pwm@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V5 1/5] dt-bindings: pwm: Add i.MX TPM PWM binding
Date: Mon, 18 Mar 2019 10:58:42 +0100 [thread overview]
Message-ID: <20190318095842.GD17565@ulmo> (raw)
In-Reply-To: <1552894581-3391-2-git-send-email-Anson.Huang@nxp.com>
[-- Attachment #1: Type: text/plain, Size: 1361 bytes --]
On Mon, Mar 18, 2019 at 07:41:32AM +0000, Anson Huang wrote:
> Add i.MX TPM(Low Power Timer/Pulse Width Modulation Module) PWM binding.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> No changes.
> ---
> Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt
>
> diff --git a/Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt b/Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt
> new file mode 100644
> index 0000000..d47b8fb
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt
> @@ -0,0 +1,19 @@
> +Freescale i.MX TPM PWM controller
> +
> +Required properties:
> +- compatible : Should be "fsl,imx-tpm-pwm".
Should this perhaps only be "fsl,imx-tpm"? Sounds to me like this is a
hardware block called "TPM" that can be used as a PWM. The compatible
string should describe the hardware block, not the mode in which it is
used.
> +- reg: Physical base address and length of the controller's registers.
> +- #pwm-cells: Should be 2. See pwm.txt in this directory for a description of the cells format.
> +- clocks : The clock provided by the SoC to drive the PWM.
> +- interrupts: The interrupt for the pwm controller.
pwm -> PWM
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Anson Huang <anson.huang@nxp.com>
Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>,
"linux-pwm@vger.kernel.org" <linux-pwm@vger.kernel.org>,
Robin Gong <yibin.gong@nxp.com>,
"otavio@ossystems.com.br" <otavio@ossystems.com.br>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"jan.tuerk@emtrion.com" <jan.tuerk@emtrion.com>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"stefan@agner.ch" <stefan@agner.ch>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
dl-linux-imx <linux-imx@nxp.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"u.kleine-koenig@pengutronix.de" <u.kleine-koenig@pengutronix.de>,
Leonard Crestez <leonard.crestez@nxp.com>,
"festevam@gmail.com" <festevam@gmail.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH V5 1/5] dt-bindings: pwm: Add i.MX TPM PWM binding
Date: Mon, 18 Mar 2019 10:58:42 +0100 [thread overview]
Message-ID: <20190318095842.GD17565@ulmo> (raw)
In-Reply-To: <1552894581-3391-2-git-send-email-Anson.Huang@nxp.com>
[-- Attachment #1.1: Type: text/plain, Size: 1361 bytes --]
On Mon, Mar 18, 2019 at 07:41:32AM +0000, Anson Huang wrote:
> Add i.MX TPM(Low Power Timer/Pulse Width Modulation Module) PWM binding.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> No changes.
> ---
> Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt
>
> diff --git a/Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt b/Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt
> new file mode 100644
> index 0000000..d47b8fb
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt
> @@ -0,0 +1,19 @@
> +Freescale i.MX TPM PWM controller
> +
> +Required properties:
> +- compatible : Should be "fsl,imx-tpm-pwm".
Should this perhaps only be "fsl,imx-tpm"? Sounds to me like this is a
hardware block called "TPM" that can be used as a PWM. The compatible
string should describe the hardware block, not the mode in which it is
used.
> +- reg: Physical base address and length of the controller's registers.
> +- #pwm-cells: Should be 2. See pwm.txt in this directory for a description of the cells format.
> +- clocks : The clock provided by the SoC to drive the PWM.
> +- interrupts: The interrupt for the pwm controller.
pwm -> PWM
Thierry
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Anson Huang <anson.huang@nxp.com>
Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"otavio@ossystems.com.br" <otavio@ossystems.com.br>,
"stefan@agner.ch" <stefan@agner.ch>,
Leonard Crestez <leonard.crestez@nxp.com>,
Robin Gong <yibin.gong@nxp.com>,
"jan.tuerk@emtrion.com" <jan.tuerk@emtrion.com>,
"linux-pwm@vger.kernel.org" <linux-pwm@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"u.kleine-koenig@pengutronix.de" <u.kleine-koenig@pengutronix.de>,
dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH V5 1/5] dt-bindings: pwm: Add i.MX TPM PWM binding
Date: Mon, 18 Mar 2019 10:58:42 +0100 [thread overview]
Message-ID: <20190318095842.GD17565@ulmo> (raw)
In-Reply-To: <1552894581-3391-2-git-send-email-Anson.Huang@nxp.com>
[-- Attachment #1: Type: text/plain, Size: 1361 bytes --]
On Mon, Mar 18, 2019 at 07:41:32AM +0000, Anson Huang wrote:
> Add i.MX TPM(Low Power Timer/Pulse Width Modulation Module) PWM binding.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> No changes.
> ---
> Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt
>
> diff --git a/Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt b/Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt
> new file mode 100644
> index 0000000..d47b8fb
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pwm/imx-tpm-pwm.txt
> @@ -0,0 +1,19 @@
> +Freescale i.MX TPM PWM controller
> +
> +Required properties:
> +- compatible : Should be "fsl,imx-tpm-pwm".
Should this perhaps only be "fsl,imx-tpm"? Sounds to me like this is a
hardware block called "TPM" that can be used as a PWM. The compatible
string should describe the hardware block, not the mode in which it is
used.
> +- reg: Physical base address and length of the controller's registers.
> +- #pwm-cells: Should be 2. See pwm.txt in this directory for a description of the cells format.
> +- clocks : The clock provided by the SoC to drive the PWM.
> +- interrupts: The interrupt for the pwm controller.
pwm -> PWM
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-03-18 9:58 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-18 7:41 [PATCH V5 0/5] Add i.MX7ULP EVK PWM backlight support Anson Huang
2019-03-18 7:41 ` Anson Huang
2019-03-18 7:41 ` Anson Huang
2019-03-18 7:41 ` [PATCH V5 1/5] dt-bindings: pwm: Add i.MX TPM PWM binding Anson Huang
2019-03-18 7:41 ` Anson Huang
2019-03-18 7:41 ` Anson Huang
2019-03-18 8:18 ` Stefan Agner
2019-03-18 8:18 ` Stefan Agner
2019-03-18 9:50 ` Anson Huang
2019-03-18 9:50 ` Anson Huang
2019-03-18 9:50 ` Anson Huang
2019-03-18 9:58 ` Thierry Reding [this message]
2019-03-18 9:58 ` Thierry Reding
2019-03-18 9:58 ` Thierry Reding
2019-03-18 10:09 ` Anson Huang
2019-03-18 10:09 ` Anson Huang
2019-03-18 10:09 ` Anson Huang
2019-03-18 7:41 ` [PATCH V5 2/5] pwm: Add i.MX TPM PWM driver support Anson Huang
2019-03-18 7:41 ` Anson Huang
2019-03-18 7:41 ` Anson Huang
2019-03-18 10:27 ` Thierry Reding
2019-03-18 10:27 ` Thierry Reding
2019-03-18 10:27 ` Thierry Reding
2019-03-18 11:33 ` Anson Huang
2019-03-18 11:33 ` Anson Huang
2019-03-18 11:33 ` Anson Huang
2019-03-18 15:30 ` Thierry Reding
2019-03-18 15:30 ` Thierry Reding
2019-03-18 15:30 ` Thierry Reding
2019-03-19 0:55 ` Anson Huang
2019-03-19 0:55 ` Anson Huang
2019-03-19 0:55 ` Anson Huang
2019-03-18 7:41 ` [PATCH V5 3/5] ARM: imx_v6_v7_defconfig: Add TPM PWM support by default Anson Huang
2019-03-18 7:41 ` Anson Huang
2019-03-18 7:41 ` Anson Huang
2019-03-18 7:41 ` [PATCH V5 4/5] ARM: dts: imx7ulp: Add pwm0 support Anson Huang
2019-03-18 7:41 ` Anson Huang
2019-03-18 7:41 ` Anson Huang
2019-03-18 7:42 ` [PATCH V5 5/5] ARM: dts: imx7ulp-evk: Add backlight support Anson Huang
2019-03-18 7:42 ` Anson Huang
2019-03-18 7:42 ` Anson Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190318095842.GD17565@ulmo \
--to=thierry.reding@gmail.com \
--cc=anson.huang@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=jan.tuerk@emtrion.com \
--cc=kernel@pengutronix.de \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=otavio@ossystems.com.br \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stefan@agner.ch \
--cc=yibin.gong@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.