* [PATCH v3] staging: erofs: Add whitespace after declaration
@ 2019-03-18 15:32 ` Bharath Vedartham
0 siblings, 0 replies; 8+ messages in thread
From: Bharath Vedartham @ 2019-03-18 15:32 UTC (permalink / raw)
Add whitespace after declaration. Fixed the checkpatch.pl warning.
---
changes since v2
- mutt gave me a lot of problems. Hence 3 patches for a really
small problem.
- Fixed the extra missing line.
Signed-off-by: Bharath Vedartham <linux.bhar at gmail.com>
---
drivers/staging/erofs/inode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/erofs/inode.c b/drivers/staging/erofs/inode.c
index 924b8df..e09d29f 100644
--- a/drivers/staging/erofs/inode.c
+++ b/drivers/staging/erofs/inode.c
@@ -270,8 +270,8 @@ struct inode *erofs_iget(struct super_block *sb,
if (inode->i_state & I_NEW) {
int err;
struct erofs_vnode *vi = EROFS_V(inode);
- vi->nid = nid;
+ vi->nid = nid;
err = fill_inode(inode, isdir);
if (likely(!err))
unlock_new_inode(inode);
--
2.7.4
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH v3] staging: erofs: Add whitespace after declaration
@ 2019-03-18 15:32 ` Bharath Vedartham
0 siblings, 0 replies; 8+ messages in thread
From: Bharath Vedartham @ 2019-03-18 15:32 UTC (permalink / raw)
To: gaoxiang25, yuchao0, gregkh; +Cc: linux-erofs, devel, linux-kernel
Add whitespace after declaration. Fixed the checkpatch.pl warning.
---
changes since v2
- mutt gave me a lot of problems. Hence 3 patches for a really
small problem.
- Fixed the extra missing line.
Signed-off-by: Bharath Vedartham <linux.bhar@gmail.com>
---
drivers/staging/erofs/inode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/erofs/inode.c b/drivers/staging/erofs/inode.c
index 924b8df..e09d29f 100644
--- a/drivers/staging/erofs/inode.c
+++ b/drivers/staging/erofs/inode.c
@@ -270,8 +270,8 @@ struct inode *erofs_iget(struct super_block *sb,
if (inode->i_state & I_NEW) {
int err;
struct erofs_vnode *vi = EROFS_V(inode);
- vi->nid = nid;
+ vi->nid = nid;
err = fill_inode(inode, isdir);
if (likely(!err))
unlock_new_inode(inode);
--
2.7.4
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH v3] staging: erofs: Add whitespace after declaration
2019-03-18 15:32 ` Bharath Vedartham
@ 2019-03-18 15:38 ` Greg KH
-1 siblings, 0 replies; 8+ messages in thread
From: Greg KH @ 2019-03-18 15:38 UTC (permalink / raw)
On Mon, Mar 18, 2019@09:02:24PM +0530, Bharath Vedartham wrote:
> Add whitespace after declaration. Fixed the checkpatch.pl warning.
>
> ---
No signed-off-by?
> changes since v2
> - mutt gave me a lot of problems. Hence 3 patches for a really
> small problem.
> - Fixed the extra missing line.
>
> Signed-off-by: Bharath Vedartham <linux.bhar at gmail.com>
It needs to be above the --- line, otherwise it will be stripped off
when applied.
v4 please?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v3] staging: erofs: Add whitespace after declaration
@ 2019-03-18 15:38 ` Greg KH
0 siblings, 0 replies; 8+ messages in thread
From: Greg KH @ 2019-03-18 15:38 UTC (permalink / raw)
To: Bharath Vedartham; +Cc: gaoxiang25, yuchao0, devel, linux-erofs, linux-kernel
On Mon, Mar 18, 2019 at 09:02:24PM +0530, Bharath Vedartham wrote:
> Add whitespace after declaration. Fixed the checkpatch.pl warning.
>
> ---
No signed-off-by?
> changes since v2
> - mutt gave me a lot of problems. Hence 3 patches for a really
> small problem.
> - Fixed the extra missing line.
>
> Signed-off-by: Bharath Vedartham <linux.bhar@gmail.com>
It needs to be above the --- line, otherwise it will be stripped off
when applied.
v4 please?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v3] staging: erofs: Add whitespace after declaration
2019-03-18 15:38 ` Greg KH
@ 2019-03-18 15:40 ` Gao Xiang
-1 siblings, 0 replies; 8+ messages in thread
From: Gao Xiang @ 2019-03-18 15:40 UTC (permalink / raw)
On 2019/3/18 23:38, Greg KH wrote:
> On Mon, Mar 18, 2019@09:02:24PM +0530, Bharath Vedartham wrote:
>> Add whitespace after declaration. Fixed the checkpatch.pl warning.
>>
>> ---
>
> No signed-off-by?
>
>> changes since v2
>> - mutt gave me a lot of problems. Hence 3 patches for a really
>> small problem.
>> - Fixed the extra missing line.
>>
>> Signed-off-by: Bharath Vedartham <linux.bhar at gmail.com>
>
> It needs to be above the --- line, otherwise it will be stripped off
> when applied.
>
> v4 please?
Actually a duplicate commit, see:
https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/commit/?h=staging-next&id=8af36478f9516d51fcfedf9b9ed8905a1c00d278
several people submit patches on this line in erofs_iget()....
Thanks,
Gao Xiang
>
> thanks,
>
> greg k-h
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v3] staging: erofs: Add whitespace after declaration
@ 2019-03-18 15:40 ` Gao Xiang
0 siblings, 0 replies; 8+ messages in thread
From: Gao Xiang @ 2019-03-18 15:40 UTC (permalink / raw)
To: Greg KH, Bharath Vedartham; +Cc: yuchao0, devel, linux-erofs, linux-kernel
On 2019/3/18 23:38, Greg KH wrote:
> On Mon, Mar 18, 2019 at 09:02:24PM +0530, Bharath Vedartham wrote:
>> Add whitespace after declaration. Fixed the checkpatch.pl warning.
>>
>> ---
>
> No signed-off-by?
>
>> changes since v2
>> - mutt gave me a lot of problems. Hence 3 patches for a really
>> small problem.
>> - Fixed the extra missing line.
>>
>> Signed-off-by: Bharath Vedartham <linux.bhar@gmail.com>
>
> It needs to be above the --- line, otherwise it will be stripped off
> when applied.
>
> v4 please?
Actually a duplicate commit, see:
https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/commit/?h=staging-next&id=8af36478f9516d51fcfedf9b9ed8905a1c00d278
several people submit patches on this line in erofs_iget()....
Thanks,
Gao Xiang
>
> thanks,
>
> greg k-h
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v3] staging: erofs: Add whitespace after declaration
2019-03-18 15:40 ` Gao Xiang
@ 2019-03-18 16:00 ` Bharath Vedartham
-1 siblings, 0 replies; 8+ messages in thread
From: Bharath Vedartham @ 2019-03-18 16:00 UTC (permalink / raw)
On Mon, Mar 18, 2019@11:40:35PM +0800, Gao Xiang wrote:
>
>
> On 2019/3/18 23:38, Greg KH wrote:
> > On Mon, Mar 18, 2019@09:02:24PM +0530, Bharath Vedartham wrote:
> >> Add whitespace after declaration. Fixed the checkpatch.pl warning.
> >>
> >> ---
> >
> > No signed-off-by?
> >
> >> changes since v2
> >> - mutt gave me a lot of problems. Hence 3 patches for a really
> >> small problem.
> >> - Fixed the extra missing line.
> >>
> >> Signed-off-by: Bharath Vedartham <linux.bhar at gmail.com>
> >
> > It needs to be above the --- line, otherwise it will be stripped off
> > when applied.
> >
> > v4 please?
Missed that! Really sorry!
>
> Actually a duplicate commit, see:
> https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/commit/?h=staging-next&id=8af36478f9516d51fcfedf9b9ed8905a1c00d278
>
> several people submit patches on this line in erofs_iget()....
>
Oh alright then! I ll stop this patch here! Thank for your time! I have
noticed that there are a few functions and structs local to a file in erofs without static
declaration. I ll send a patch soon.
> Thanks,
> Gao Xiang
>
> >
> > thanks,
> >
> > greg k-h
> >
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v3] staging: erofs: Add whitespace after declaration
@ 2019-03-18 16:00 ` Bharath Vedartham
0 siblings, 0 replies; 8+ messages in thread
From: Bharath Vedartham @ 2019-03-18 16:00 UTC (permalink / raw)
To: Gao Xiang; +Cc: Greg KH, yuchao0, devel, linux-erofs, linux-kernel
On Mon, Mar 18, 2019 at 11:40:35PM +0800, Gao Xiang wrote:
>
>
> On 2019/3/18 23:38, Greg KH wrote:
> > On Mon, Mar 18, 2019 at 09:02:24PM +0530, Bharath Vedartham wrote:
> >> Add whitespace after declaration. Fixed the checkpatch.pl warning.
> >>
> >> ---
> >
> > No signed-off-by?
> >
> >> changes since v2
> >> - mutt gave me a lot of problems. Hence 3 patches for a really
> >> small problem.
> >> - Fixed the extra missing line.
> >>
> >> Signed-off-by: Bharath Vedartham <linux.bhar@gmail.com>
> >
> > It needs to be above the --- line, otherwise it will be stripped off
> > when applied.
> >
> > v4 please?
Missed that! Really sorry!
>
> Actually a duplicate commit, see:
> https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/commit/?h=staging-next&id=8af36478f9516d51fcfedf9b9ed8905a1c00d278
>
> several people submit patches on this line in erofs_iget()....
>
Oh alright then! I ll stop this patch here! Thank for your time! I have
noticed that there are a few functions and structs local to a file in erofs without static
declaration. I ll send a patch soon.
> Thanks,
> Gao Xiang
>
> >
> > thanks,
> >
> > greg k-h
> >
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-03-18 16:01 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-18 15:32 [PATCH v3] staging: erofs: Add whitespace after declaration Bharath Vedartham
2019-03-18 15:32 ` Bharath Vedartham
2019-03-18 15:38 ` Greg KH
2019-03-18 15:38 ` Greg KH
2019-03-18 15:40 ` Gao Xiang
2019-03-18 15:40 ` Gao Xiang
2019-03-18 16:00 ` Bharath Vedartham
2019-03-18 16:00 ` Bharath Vedartham
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.