[PATCH] Staging: rtl8188eu: core: rtw_efuse.c: Line over 80 characters.

[PATCH] Staging: rtl8188eu: core: rtw_efuse.c: Line over 80 characters.

[Sanjana Sanikommu]

Fix coding style issues, which solves checkpatch.pl warning:
"WARNING: line over 80 characters".

Signed-off-by: Sanjana Sanikommu <sanjana99reddy99@gmail.com>
---
 drivers/staging/rtl8188eu/core/rtw_efuse.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_efuse.c b/drivers/staging/rtl8188eu/core/rtw_efuse.c
index 51c3dd6d7ffb..a5d34b85d9c5 100644
--- a/drivers/staging/rtl8188eu/core/rtw_efuse.c
+++ b/drivers/staging/rtl8188eu/core/rtw_efuse.c
@@ -794,13 +794,16 @@ bool Efuse_PgPacketWrite(struct adapter *pAdapter, u8 offset, u8 word_en, u8 *pD
 
 	hal_EfuseConstructPGPkt(offset, word_en, pData, &targetPkt);
 
-	if (!hal_EfusePartialWriteCheck(pAdapter, efuseType, &startAddr, &targetPkt))
+	if (!hal_EfusePartialWriteCheck(pAdapter, efuseType,
+					&startAddr, &targetPkt))
 		return false;
 
-	if (!hal_EfusePgPacketWriteHeader(pAdapter, efuseType, &startAddr, &targetPkt))
+	if (!hal_EfusePgPacketWriteHeader(pAdapter, efuseType,
+					  &startAddr, &targetPkt))
 		return false;
 
-	if (!hal_EfusePgPacketWriteData(pAdapter, efuseType, &startAddr, &targetPkt))
+	if (!hal_EfusePgPacketWriteData(pAdapter, efuseType,
+					&startAddr, &targetPkt))
 		return false;
 
 	return true;
-- 
2.17.1

Re: [PATCH] Staging: rtl8188eu: core: rtw_efuse.c: Line over 80 characters.

[Greg KH]

On Mon, Mar 18, 2019 at 09:35:42PM +0530, Sanjana Sanikommu wrote:
> Fix coding style issues, which solves checkpatch.pl warning:
> "WARNING: line over 80 characters".
> 
> Signed-off-by: Sanjana Sanikommu <sanjana99reddy99@gmail.com>
> ---
>  drivers/staging/rtl8188eu/core/rtw_efuse.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/rtl8188eu/core/rtw_efuse.c b/drivers/staging/rtl8188eu/core/rtw_efuse.c
> index 51c3dd6d7ffb..a5d34b85d9c5 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_efuse.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_efuse.c
> @@ -794,13 +794,16 @@ bool Efuse_PgPacketWrite(struct adapter *pAdapter, u8 offset, u8 word_en, u8 *pD
>  
>  	hal_EfuseConstructPGPkt(offset, word_en, pData, &targetPkt);
>  
> -	if (!hal_EfusePartialWriteCheck(pAdapter, efuseType, &startAddr, &targetPkt))
> +	if (!hal_EfusePartialWriteCheck(pAdapter, efuseType,
> +					&startAddr, &targetPkt))

Why not use the full line:
	if (!hal_EfusePartialWriteCheck(pAdapter, efuseType, &startAddr,
					&targetPkt))

Only wrap where you _have_ to wrap, don't make lines shorter than they
have to unless it makes a lot of sense to.

thanks,

greg k-h

Re: [PATCH] Staging: rtl8188eu: core: rtw_efuse.c: Line over 80 characters.

[sanjana99reddy99]

[-- Attachment #1.1: Type: text/plain, Size: 1603 bytes --]



On Monday, March 18, 2019 at 11:10:10 PM UTC+5:30, gregkh wrote:
>
> On Mon, Mar 18, 2019 at 09:35:42PM +0530, Sanjana Sanikommu wrote: 
> > Fix coding style issues, which solves checkpatch.pl warning: 
> > "WARNING: line over 80 characters". 
> > 
> > Signed-off-by: Sanjana Sanikommu <sanjana9...@gmail.com <javascript:>> 
> > --- 
> >  drivers/staging/rtl8188eu/core/rtw_efuse.c | 9 ++++++--- 
> >  1 file changed, 6 insertions(+), 3 deletions(-) 
> > 
> > diff --git a/drivers/staging/rtl8188eu/core/rtw_efuse.c 
> b/drivers/staging/rtl8188eu/core/rtw_efuse.c 
> > index 51c3dd6d7ffb..a5d34b85d9c5 100644 
> > --- a/drivers/staging/rtl8188eu/core/rtw_efuse.c 
> > +++ b/drivers/staging/rtl8188eu/core/rtw_efuse.c 
> > @@ -794,13 +794,16 @@ bool Efuse_PgPacketWrite(struct adapter *pAdapter, 
> u8 offset, u8 word_en, u8 *pD 
> >   
> >          hal_EfuseConstructPGPkt(offset, word_en, pData, &targetPkt); 
> >   
> > -        if (!hal_EfusePartialWriteCheck(pAdapter, efuseType, 
> &startAddr, &targetPkt)) 
> > +        if (!hal_EfusePartialWriteCheck(pAdapter, efuseType, 
> > +                                        &startAddr, &targetPkt)) 
>
> Why not use the full line: 
>
To fix coding style issue I thought of splitting the line over 80 chars.

        if (!hal_EfusePartialWriteCheck(pAdapter, efuseType, &startAddr, 
>                                         &targetPkt)) 
>
> Only wrap where you _have_ to wrap, don't make lines shorter than they 
> have to unless it makes a lot of sense to.


Fine I would put them in single line.
Thank you
Sanjana 

>
>
> thanks, 
>
> greg k-h 
>

[-- Attachment #1.2: Type: text/html, Size: 3022 bytes --]