Re: [PATCH] [Outreachy kernel] staging: gasket: replace symbolic permissions

[Greg KH <greg@kroah.com>]

On Mon, Mar 18, 2019 at 11:23:50PM +0530, Payal Kshirsagar wrote:
> On Mon, 18 Mar 2019 at 23:21, Greg KH <greg@kroah.com> wrote:
> 
> > On Mon, Mar 18, 2019 at 07:21:54PM +0530, Payal Kshirsagar wrote:
> > > Symbolic permissions 'S_IRUGO' are replaced by octal permissions '0444'
> > > in file
> > > drivers/staging/gasket/gasket_sysfs.h at line no 43 and 78.
> > >
> > > Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
> > > ---
> > >  drivers/staging/gasket/gasket_sysfs.h | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/staging/gasket/gasket_sysfs.h
> > b/drivers/staging/gasket/gasket_sysfs.h
> > > index 151e8ed..60590ea 100644
> > > --- a/drivers/staging/gasket/gasket_sysfs.h
> > > +++ b/drivers/staging/gasket/gasket_sysfs.h
> > > @@ -40,7 +40,7 @@
> > >   */
> > >  #define GASKET_END_OF_ATTR_ARRAY
> >        \
> > >       {
> >     \
> > > -             .attr = __ATTR(GASKET_ARRAY_END_TOKEN, S_IRUGO, NULL,
> > NULL),   \
> > > +             .attr = __ATTR(GASKET_ARRAY_END_TOKEN, 0444, NULL, NULL),
> >  \
> > >               .data.attr_type = 0,
> >      \
> > >       }
> > >
> > > @@ -75,7 +75,7 @@ struct gasket_sysfs_attribute {
> > >
> > >  #define GASKET_SYSFS_RO(_name, _show_function, _attr_type)
> >        \
> > >       {
> >     \
> > > -             .attr = __ATTR(_name, S_IRUGO, _show_function, NULL),
> >     \
> > > +             .attr = __ATTR(_name, 0444, _show_function, NULL),
> >   \
> > >               .data.attr_type = _attr_type
> >      \
> > >       }
> > >
> >
> > This patch does not apply at all, as others have made changes in this
> > portion of the kernel.  Be sure you are working against the latest
> > staging tree, it is staging.git on git.kernel.org and use the
> > staging-testing branch.
> >
> > thanks,
> >
> > greg k-h
> >
> 
> How do I update my staging tree ?

There are lots of tutorials for how to update your local branches based
on an "upstream" tree/branch.  I suggest following them, and if you have
any specific questions, please let us know.

thanks,

greg k-h