* [PATCH] [Outreachy kernel] staging: gasket: replace symbolic permissions
@ 2019-03-18 13:51 Payal Kshirsagar
2019-03-18 17:51 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: Payal Kshirsagar @ 2019-03-18 13:51 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Payal Kshirsagar
Symbolic permissions 'S_IRUGO' are replaced by octal permissions '0444'
in file
drivers/staging/gasket/gasket_sysfs.h at line no 43 and 78.
Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
---
drivers/staging/gasket/gasket_sysfs.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/gasket/gasket_sysfs.h b/drivers/staging/gasket/gasket_sysfs.h
index 151e8ed..60590ea 100644
--- a/drivers/staging/gasket/gasket_sysfs.h
+++ b/drivers/staging/gasket/gasket_sysfs.h
@@ -40,7 +40,7 @@
*/
#define GASKET_END_OF_ATTR_ARRAY \
{ \
- .attr = __ATTR(GASKET_ARRAY_END_TOKEN, S_IRUGO, NULL, NULL), \
+ .attr = __ATTR(GASKET_ARRAY_END_TOKEN, 0444, NULL, NULL), \
.data.attr_type = 0, \
}
@@ -75,7 +75,7 @@ struct gasket_sysfs_attribute {
#define GASKET_SYSFS_RO(_name, _show_function, _attr_type) \
{ \
- .attr = __ATTR(_name, S_IRUGO, _show_function, NULL), \
+ .attr = __ATTR(_name, 0444, _show_function, NULL), \
.data.attr_type = _attr_type \
}
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] [Outreachy kernel] staging: gasket: replace symbolic permissions
2019-03-18 13:51 [PATCH] [Outreachy kernel] staging: gasket: replace symbolic permissions Payal Kshirsagar
@ 2019-03-18 17:51 ` Greg KH
2019-03-18 17:53 ` Payal Kshirsagar
0 siblings, 1 reply; 5+ messages in thread
From: Greg KH @ 2019-03-18 17:51 UTC (permalink / raw)
To: Payal Kshirsagar; +Cc: outreachy-kernel
On Mon, Mar 18, 2019 at 07:21:54PM +0530, Payal Kshirsagar wrote:
> Symbolic permissions 'S_IRUGO' are replaced by octal permissions '0444'
> in file
> drivers/staging/gasket/gasket_sysfs.h at line no 43 and 78.
>
> Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
> ---
> drivers/staging/gasket/gasket_sysfs.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/gasket/gasket_sysfs.h b/drivers/staging/gasket/gasket_sysfs.h
> index 151e8ed..60590ea 100644
> --- a/drivers/staging/gasket/gasket_sysfs.h
> +++ b/drivers/staging/gasket/gasket_sysfs.h
> @@ -40,7 +40,7 @@
> */
> #define GASKET_END_OF_ATTR_ARRAY \
> { \
> - .attr = __ATTR(GASKET_ARRAY_END_TOKEN, S_IRUGO, NULL, NULL), \
> + .attr = __ATTR(GASKET_ARRAY_END_TOKEN, 0444, NULL, NULL), \
> .data.attr_type = 0, \
> }
>
> @@ -75,7 +75,7 @@ struct gasket_sysfs_attribute {
>
> #define GASKET_SYSFS_RO(_name, _show_function, _attr_type) \
> { \
> - .attr = __ATTR(_name, S_IRUGO, _show_function, NULL), \
> + .attr = __ATTR(_name, 0444, _show_function, NULL), \
> .data.attr_type = _attr_type \
> }
>
This patch does not apply at all, as others have made changes in this
portion of the kernel. Be sure you are working against the latest
staging tree, it is staging.git on git.kernel.org and use the
staging-testing branch.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] [Outreachy kernel] staging: gasket: replace symbolic permissions
2019-03-18 17:51 ` Greg KH
@ 2019-03-18 17:53 ` Payal Kshirsagar
2019-03-18 18:00 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: Payal Kshirsagar @ 2019-03-18 17:53 UTC (permalink / raw)
To: Greg KH; +Cc: outreachy-kernel
[-- Attachment #1: Type: text/plain, Size: 1732 bytes --]
On Mon, 18 Mar 2019 at 23:21, Greg KH <greg@kroah.com> wrote:
> On Mon, Mar 18, 2019 at 07:21:54PM +0530, Payal Kshirsagar wrote:
> > Symbolic permissions 'S_IRUGO' are replaced by octal permissions '0444'
> > in file
> > drivers/staging/gasket/gasket_sysfs.h at line no 43 and 78.
> >
> > Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
> > ---
> > drivers/staging/gasket/gasket_sysfs.h | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/gasket/gasket_sysfs.h
> b/drivers/staging/gasket/gasket_sysfs.h
> > index 151e8ed..60590ea 100644
> > --- a/drivers/staging/gasket/gasket_sysfs.h
> > +++ b/drivers/staging/gasket/gasket_sysfs.h
> > @@ -40,7 +40,7 @@
> > */
> > #define GASKET_END_OF_ATTR_ARRAY
> \
> > {
> \
> > - .attr = __ATTR(GASKET_ARRAY_END_TOKEN, S_IRUGO, NULL,
> NULL), \
> > + .attr = __ATTR(GASKET_ARRAY_END_TOKEN, 0444, NULL, NULL),
> \
> > .data.attr_type = 0,
> \
> > }
> >
> > @@ -75,7 +75,7 @@ struct gasket_sysfs_attribute {
> >
> > #define GASKET_SYSFS_RO(_name, _show_function, _attr_type)
> \
> > {
> \
> > - .attr = __ATTR(_name, S_IRUGO, _show_function, NULL),
> \
> > + .attr = __ATTR(_name, 0444, _show_function, NULL),
> \
> > .data.attr_type = _attr_type
> \
> > }
> >
>
> This patch does not apply at all, as others have made changes in this
> portion of the kernel. Be sure you are working against the latest
> staging tree, it is staging.git on git.kernel.org and use the
> staging-testing branch.
>
> thanks,
>
> greg k-h
>
How do I update my staging tree ?
Thanks in advance!
payal
[-- Attachment #2: Type: text/html, Size: 2944 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] [Outreachy kernel] staging: gasket: replace symbolic permissions
2019-03-18 17:53 ` Payal Kshirsagar
@ 2019-03-18 18:00 ` Greg KH
2019-03-18 18:22 ` Payal Kshirsagar
0 siblings, 1 reply; 5+ messages in thread
From: Greg KH @ 2019-03-18 18:00 UTC (permalink / raw)
To: Payal Kshirsagar; +Cc: outreachy-kernel
On Mon, Mar 18, 2019 at 11:23:50PM +0530, Payal Kshirsagar wrote:
> On Mon, 18 Mar 2019 at 23:21, Greg KH <greg@kroah.com> wrote:
>
> > On Mon, Mar 18, 2019 at 07:21:54PM +0530, Payal Kshirsagar wrote:
> > > Symbolic permissions 'S_IRUGO' are replaced by octal permissions '0444'
> > > in file
> > > drivers/staging/gasket/gasket_sysfs.h at line no 43 and 78.
> > >
> > > Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
> > > ---
> > > drivers/staging/gasket/gasket_sysfs.h | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/staging/gasket/gasket_sysfs.h
> > b/drivers/staging/gasket/gasket_sysfs.h
> > > index 151e8ed..60590ea 100644
> > > --- a/drivers/staging/gasket/gasket_sysfs.h
> > > +++ b/drivers/staging/gasket/gasket_sysfs.h
> > > @@ -40,7 +40,7 @@
> > > */
> > > #define GASKET_END_OF_ATTR_ARRAY
> > \
> > > {
> > \
> > > - .attr = __ATTR(GASKET_ARRAY_END_TOKEN, S_IRUGO, NULL,
> > NULL), \
> > > + .attr = __ATTR(GASKET_ARRAY_END_TOKEN, 0444, NULL, NULL),
> > \
> > > .data.attr_type = 0,
> > \
> > > }
> > >
> > > @@ -75,7 +75,7 @@ struct gasket_sysfs_attribute {
> > >
> > > #define GASKET_SYSFS_RO(_name, _show_function, _attr_type)
> > \
> > > {
> > \
> > > - .attr = __ATTR(_name, S_IRUGO, _show_function, NULL),
> > \
> > > + .attr = __ATTR(_name, 0444, _show_function, NULL),
> > \
> > > .data.attr_type = _attr_type
> > \
> > > }
> > >
> >
> > This patch does not apply at all, as others have made changes in this
> > portion of the kernel. Be sure you are working against the latest
> > staging tree, it is staging.git on git.kernel.org and use the
> > staging-testing branch.
> >
> > thanks,
> >
> > greg k-h
> >
>
> How do I update my staging tree ?
There are lots of tutorials for how to update your local branches based
on an "upstream" tree/branch. I suggest following them, and if you have
any specific questions, please let us know.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] [Outreachy kernel] staging: gasket: replace symbolic permissions
2019-03-18 18:00 ` Greg KH
@ 2019-03-18 18:22 ` Payal Kshirsagar
0 siblings, 0 replies; 5+ messages in thread
From: Payal Kshirsagar @ 2019-03-18 18:22 UTC (permalink / raw)
To: Greg KH; +Cc: outreachy-kernel
[-- Attachment #1: Type: text/plain, Size: 2320 bytes --]
On Mon, Mar 18, 2019, 11:30 PM Greg KH <greg@kroah.com> wrote:
> On Mon, Mar 18, 2019 at 11:23:50PM +0530, Payal Kshirsagar wrote:
> > On Mon, 18 Mar 2019 at 23:21, Greg KH <greg@kroah.com> wrote:
> >
> > > On Mon, Mar 18, 2019 at 07:21:54PM +0530, Payal Kshirsagar wrote:
> > > > Symbolic permissions 'S_IRUGO' are replaced by octal permissions
> '0444'
> > > > in file
> > > > drivers/staging/gasket/gasket_sysfs.h at line no 43 and 78.
> > > >
> > > > Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
> > > > ---
> > > > drivers/staging/gasket/gasket_sysfs.h | 4 ++--
> > > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/drivers/staging/gasket/gasket_sysfs.h
> > > b/drivers/staging/gasket/gasket_sysfs.h
> > > > index 151e8ed..60590ea 100644
> > > > --- a/drivers/staging/gasket/gasket_sysfs.h
> > > > +++ b/drivers/staging/gasket/gasket_sysfs.h
> > > > @@ -40,7 +40,7 @@
> > > > */
> > > > #define GASKET_END_OF_ATTR_ARRAY
> > > \
> > > > {
> > > \
> > > > - .attr = __ATTR(GASKET_ARRAY_END_TOKEN, S_IRUGO, NULL,
> > > NULL), \
> > > > + .attr = __ATTR(GASKET_ARRAY_END_TOKEN, 0444, NULL,
> NULL),
> > > \
> > > > .data.attr_type = 0,
> > > \
> > > > }
> > > >
> > > > @@ -75,7 +75,7 @@ struct gasket_sysfs_attribute {
> > > >
> > > > #define GASKET_SYSFS_RO(_name, _show_function, _attr_type)
> > > \
> > > > {
> > > \
> > > > - .attr = __ATTR(_name, S_IRUGO, _show_function, NULL),
> > > \
> > > > + .attr = __ATTR(_name, 0444, _show_function, NULL),
> > > \
> > > > .data.attr_type = _attr_type
> > > \
> > > > }
> > > >
> > >
> > > This patch does not apply at all, as others have made changes in this
> > > portion of the kernel. Be sure you are working against the latest
> > > staging tree, it is staging.git on git.kernel.org and use the
> > > staging-testing branch.
> > >
> > > thanks,
> > >
> > > greg k-h
> > >
> >
> > How do I update my staging tree ?
>
> There are lots of tutorials for how to update your local branches based
> on an "upstream" tree/branch. I suggest following them, and if you have
> any specific questions, please let us know.
>
> thanks,
>
> greg k-h
>
Okay thank you ,
Payal
>
[-- Attachment #2: Type: text/html, Size: 3988 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-03-18 18:22 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-18 13:51 [PATCH] [Outreachy kernel] staging: gasket: replace symbolic permissions Payal Kshirsagar
2019-03-18 17:51 ` Greg KH
2019-03-18 17:53 ` Payal Kshirsagar
2019-03-18 18:00 ` Greg KH
2019-03-18 18:22 ` Payal Kshirsagar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.