Re: [PATCH] staging: greybus: Change NULL comparison to Boolean Negation

[Johan Hovold <johan@kernel.org>]

On Mon, Mar 04, 2019 at 11:13:15PM +0530, Nishka Dasgupta wrote:
> Change NULL comparison to boolean negation. Issue found by Checkpatch.
> 
> Signed-off-by: Nishka Dasgupta <nishka.dasgupta@yahoo.com>
> ---
>  drivers/staging/greybus/bundle.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/greybus/bundle.c b/drivers/staging/greybus/bundle.c
> index e97b2b87ba47..376ca53f0d83 100644
> --- a/drivers/staging/greybus/bundle.c
> +++ b/drivers/staging/greybus/bundle.c
> @@ -32,7 +32,7 @@ static ssize_t state_show(struct device *dev, struct device_attribute *attr,
>  {
>  	struct gb_bundle *bundle = to_gb_bundle(dev);
>  
> -	if (bundle->state == NULL)
> +	if (!(bundle->state))

I noticed Greg already picked this one up, but there's no need for
parenthesis around bundle->state here (cf. state_store()).

>  		return sprintf(buf, "\n");
>  
>  	return sprintf(buf, "%s\n", bundle->state);

Johan