[PATCH] staging: greybus: Change NULL comparison to Boolean Negation

[PATCH] staging: greybus: Change NULL comparison to Boolean Negation

[Nishka Dasgupta]

Change NULL comparison to boolean negation. Issue found by Checkpatch.

Signed-off-by: Nishka Dasgupta <nishka.dasgupta@yahoo.com>
---
 drivers/staging/greybus/bundle.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/greybus/bundle.c b/drivers/staging/greybus/bundle.c
index e97b2b87ba47..376ca53f0d83 100644
--- a/drivers/staging/greybus/bundle.c
+++ b/drivers/staging/greybus/bundle.c
@@ -32,7 +32,7 @@ static ssize_t state_show(struct device *dev, struct device_attribute *attr,
 {
 	struct gb_bundle *bundle = to_gb_bundle(dev);
 
-	if (bundle->state == NULL)
+	if (!(bundle->state))
 		return sprintf(buf, "\n");
 
 	return sprintf(buf, "%s\n", bundle->state);
-- 
2.19.1

Re: [PATCH] staging: greybus: Change NULL comparison to Boolean Negation

[Johan Hovold]

On Mon, Mar 04, 2019 at 11:13:15PM +0530, Nishka Dasgupta wrote:
> Change NULL comparison to boolean negation. Issue found by Checkpatch.
> 
> Signed-off-by: Nishka Dasgupta <nishka.dasgupta@yahoo.com>
> ---
>  drivers/staging/greybus/bundle.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/greybus/bundle.c b/drivers/staging/greybus/bundle.c
> index e97b2b87ba47..376ca53f0d83 100644
> --- a/drivers/staging/greybus/bundle.c
> +++ b/drivers/staging/greybus/bundle.c
> @@ -32,7 +32,7 @@ static ssize_t state_show(struct device *dev, struct device_attribute *attr,
>  {
>  	struct gb_bundle *bundle = to_gb_bundle(dev);
>  
> -	if (bundle->state == NULL)
> +	if (!(bundle->state))

I noticed Greg already picked this one up, but there's no need for
parenthesis around bundle->state here (cf. state_store()).

>  		return sprintf(buf, "\n");
>  
>  	return sprintf(buf, "%s\n", bundle->state);

Johan

Re: [PATCH] staging: greybus: Change NULL comparison to Boolean Negation

[NIshka Dasgupta]

On 19/03/19 3:01 PM, Johan Hovold wrote:
> On Mon, Mar 04, 2019 at 11:13:15PM +0530, Nishka Dasgupta wrote:
>> Change NULL comparison to boolean negation. Issue found by Checkpatch.
>>
>> Signed-off-by: Nishka Dasgupta <nishka.dasgupta@yahoo.com>
>> ---
>>   drivers/staging/greybus/bundle.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/greybus/bundle.c b/drivers/staging/greybus/bundle.c
>> index e97b2b87ba47..376ca53f0d83 100644
>> --- a/drivers/staging/greybus/bundle.c
>> +++ b/drivers/staging/greybus/bundle.c
>> @@ -32,7 +32,7 @@ static ssize_t state_show(struct device *dev, struct device_attribute *attr,
>>   {
>>   	struct gb_bundle *bundle = to_gb_bundle(dev);
>>   
>> -	if (bundle->state == NULL)
>> +	if (!(bundle->state))
> 
> I noticed Greg already picked this one up, but there's no need for
> parenthesis around bundle->state here (cf. state_store()).
  Okay, I'll keep that in mind.
Thanking you,
Nishka
>>   		return sprintf(buf, "\n");
>>   
>>   	return sprintf(buf, "%s\n", bundle->state);
> 
> Johan
> 

Re: [Outreachy kernel] Re: [PATCH] staging: greybus: Change NULL comparison to Boolean Negation

[Julia Lawall]

On Tue, 19 Mar 2019, 'NIshka Dasgupta' via outreachy-kernel wrote:

>
>
> On 19/03/19 3:01 PM, Johan Hovold wrote:
> > On Mon, Mar 04, 2019 at 11:13:15PM +0530, Nishka Dasgupta wrote:
> > > Change NULL comparison to boolean negation. Issue found by Checkpatch.
> > >
> > > Signed-off-by: Nishka Dasgupta <nishka.dasgupta@yahoo.com>
> > > ---
> > >   drivers/staging/greybus/bundle.c | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/staging/greybus/bundle.c
> > > b/drivers/staging/greybus/bundle.c
> > > index e97b2b87ba47..376ca53f0d83 100644
> > > --- a/drivers/staging/greybus/bundle.c
> > > +++ b/drivers/staging/greybus/bundle.c
> > > @@ -32,7 +32,7 @@ static ssize_t state_show(struct device *dev, struct
> > > device_attribute *attr,
> > >   {
> > >   	struct gb_bundle *bundle = to_gb_bundle(dev);
> > >   -	if (bundle->state == NULL)
> > > +	if (!(bundle->state))
> >
> > I noticed Greg already picked this one up, but there's no need for
> > parenthesis around bundle->state here (cf. state_store()).
>  Okay, I'll keep that in mind.

Since Greg picked it up, you can send another patch that fixes the issue.

julia

> Thanking you,
> Nishka
> > >   		return sprintf(buf, "\n");
> > >     	return sprintf(buf, "%s\n", bundle->state);
> >
> > Johan
> >
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/outreachy-kernel/3cecf381-0230-400c-d0c4-5aed1134e62d%40yahoo.com.
> For more options, visit https://groups.google.com/d/optout.
>