All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: kgene@kernel.org, robh+dt@kernel.org, b.zolnierkie@samsung.com,
	m.szyprowski@samsung.com, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: exynos: Fix audio (microphone) routing on Odroid XU3
Date: Tue, 19 Mar 2019 21:55:22 +0100	[thread overview]
Message-ID: <20190319205522.GD16150@kozik-lap> (raw)
In-Reply-To: <20190311155012.15797-1-s.nawrocki@samsung.com>

On Mon, Mar 11, 2019 at 04:50:12PM +0100, Sylwester Nawrocki wrote:
> The name of CODEC input widget to which microphone is connected through
> the "Headphone" jack is "IN12" not "IN1". This fixes microphone support
> on Odroid XU3.
> 
> Cc: <stable@vger.kernel.org> # v4.14+
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> ---
>  arch/arm/boot/dts/exynos5422-odroidxu3-audio.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

This does not apply on my next/dt nor on v5.1-rc1 branch.  Probably
because of 885b005d232c ("ARM: dts: exynos: Add support for secondary
DAI to Odroid XU3"). Can you rebase?

Best regards,
Krzysztof


> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-audio.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-audio.dtsi
> index e84544b220b9..b90cea8b7368 100644
> --- a/arch/arm/boot/dts/exynos5422-odroidxu3-audio.dtsi
> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-audio.dtsi
> @@ -22,7 +22,7 @@
>  			"Headphone Jack", "HPL",
>  			"Headphone Jack", "HPR",
>  			"Headphone Jack", "MICBIAS",
> -			"IN1", "Headphone Jack",
> +			"IN12", "Headphone Jack",
>  			"Speakers", "SPKL",
>  			"Speakers", "SPKR";
>  
> -- 
> 2.17.1
> 

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
	b.zolnierkie@samsung.com, linux-kernel@vger.kernel.org,
	robh+dt@kernel.org, kgene@kernel.org, stable@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, m.szyprowski@samsung.com
Subject: Re: [PATCH] ARM: dts: exynos: Fix audio (microphone) routing on Odroid XU3
Date: Tue, 19 Mar 2019 21:55:22 +0100	[thread overview]
Message-ID: <20190319205522.GD16150@kozik-lap> (raw)
In-Reply-To: <20190311155012.15797-1-s.nawrocki@samsung.com>

On Mon, Mar 11, 2019 at 04:50:12PM +0100, Sylwester Nawrocki wrote:
> The name of CODEC input widget to which microphone is connected through
> the "Headphone" jack is "IN12" not "IN1". This fixes microphone support
> on Odroid XU3.
> 
> Cc: <stable@vger.kernel.org> # v4.14+
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> ---
>  arch/arm/boot/dts/exynos5422-odroidxu3-audio.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

This does not apply on my next/dt nor on v5.1-rc1 branch.  Probably
because of 885b005d232c ("ARM: dts: exynos: Add support for secondary
DAI to Odroid XU3"). Can you rebase?

Best regards,
Krzysztof


> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-audio.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-audio.dtsi
> index e84544b220b9..b90cea8b7368 100644
> --- a/arch/arm/boot/dts/exynos5422-odroidxu3-audio.dtsi
> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-audio.dtsi
> @@ -22,7 +22,7 @@
>  			"Headphone Jack", "HPL",
>  			"Headphone Jack", "HPR",
>  			"Headphone Jack", "MICBIAS",
> -			"IN1", "Headphone Jack",
> +			"IN12", "Headphone Jack",
>  			"Speakers", "SPKL",
>  			"Speakers", "SPKR";
>  
> -- 
> 2.17.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-03-19 20:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20190311155023epcas2p428a025925f6442554b50e14e328a6d04@epcas2p4.samsung.com>
2019-03-11 15:50 ` [PATCH] ARM: dts: exynos: Fix audio (microphone) routing on Odroid XU3 Sylwester Nawrocki
2019-03-11 15:50   ` Sylwester Nawrocki
2019-03-19 20:55   ` Krzysztof Kozlowski [this message]
2019-03-19 20:55     ` Krzysztof Kozlowski
2019-03-20  9:59     ` [PATCH RESEND] " Sylwester Nawrocki
2019-03-20  9:59       ` Sylwester Nawrocki
2019-03-20 19:57       ` Krzysztof Kozlowski
2019-03-20 19:57         ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190319205522.GD16150@kozik-lap \
    --to=krzk@kernel.org \
    --cc=b.zolnierkie@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kgene@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=robh+dt@kernel.org \
    --cc=s.nawrocki@samsung.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.