[PATCH] staging: speakup: Remove return variable

[PATCH] staging: speakup: Remove return variable

[Nishka Dasgupta]

Remove return variable and return the required value directly. Issue
suggested by Coccinelle using ret.cocci.

Signed-off-by: Nishka Dasgupta <nishka.dasgupta@yahoo.com>
---
 drivers/staging/speakup/i18n.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/speakup/i18n.c b/drivers/staging/speakup/i18n.c
index ee240d36f947..a748eb8052d1 100644
--- a/drivers/staging/speakup/i18n.c
+++ b/drivers/staging/speakup/i18n.c
@@ -470,8 +470,7 @@ static char *find_specifier_end(char *input)
 	input++;		/* Advance over %. */
 	input = skip_flags(input);
 	input = skip_width(input);
-	input = skip_conversion(input);
-	return input;
+	return skip_conversion(input);
 }
 
 /*
-- 
2.19.1

Re: [Outreachy kernel] [PATCH] staging: speakup: Remove return variable

[Julia Lawall]

On Wed, 20 Mar 2019, 'Nishka Dasgupta' via outreachy-kernel wrote:

> Remove return variable and return the required value directly. Issue
> suggested by Coccinelle using ret.cocci.
>
> Signed-off-by: Nishka Dasgupta <nishka.dasgupta@yahoo.com>
> ---
>  drivers/staging/speakup/i18n.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/speakup/i18n.c b/drivers/staging/speakup/i18n.c
> index ee240d36f947..a748eb8052d1 100644
> --- a/drivers/staging/speakup/i18n.c
> +++ b/drivers/staging/speakup/i18n.c
> @@ -470,8 +470,7 @@ static char *find_specifier_end(char *input)
>  	input++;		/* Advance over %. */
>  	input = skip_flags(input);
>  	input = skip_width(input);
> -	input = skip_conversion(input);
> -	return input;
> +	return skip_conversion(input);

The maintainer has already said that he prefers the parallelism of an
assignment on input in each case.

julia

>  }
>
>  /*
> --
> 2.19.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190319193722.9561-1-nishka.dasgupta%40yahoo.com.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [PATCH] staging: speakup: Remove return variable

[Samuel Thibault]

Nishka Dasgupta, le mer. 20 mars 2019 01:07:22 +0530, a ecrit:
> Remove return variable and return the required value directly. Issue
> suggested by Coccinelle using ret.cocci.

Well, I have to say that for style I prefer the way it was: we apply
several functions to the input variable, before returning it.

> Signed-off-by: Nishka Dasgupta <nishka.dasgupta@yahoo.com>
> ---
>  drivers/staging/speakup/i18n.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/speakup/i18n.c b/drivers/staging/speakup/i18n.c
> index ee240d36f947..a748eb8052d1 100644
> --- a/drivers/staging/speakup/i18n.c
> +++ b/drivers/staging/speakup/i18n.c
> @@ -470,8 +470,7 @@ static char *find_specifier_end(char *input)
>  	input++;		/* Advance over %. */
>  	input = skip_flags(input);
>  	input = skip_width(input);
> -	input = skip_conversion(input);
> -	return input;
> +	return skip_conversion(input);
>  }
>  
>  /*
> -- 
> 2.19.1
> 

-- 
Samuel
<s> je la connaissais pas celle la : "make: Entering an unknown directory"
 -+- #ens-mim -+-

Re: [PATCH] staging: speakup: Remove return variable

[NIshka Dasgupta]

On 20/03/19 3:35 AM, Samuel Thibault wrote:
> Nishka Dasgupta, le mer. 20 mars 2019 01:07:22 +0530, a ecrit:
>> Remove return variable and return the required value directly. Issue
>> suggested by Coccinelle using ret.cocci.
> 
> Well, I have to say that for style I prefer the way it was: we apply
> several functions to the input variable, before returning it.

I apologise; I did not know. I will not submit this kind of patch for 
this driver in future.
- Nishka
>> Signed-off-by: Nishka Dasgupta <nishka.dasgupta@yahoo.com>
>> ---
>>   drivers/staging/speakup/i18n.c | 3 +--
>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/speakup/i18n.c b/drivers/staging/speakup/i18n.c
>> index ee240d36f947..a748eb8052d1 100644
>> --- a/drivers/staging/speakup/i18n.c
>> +++ b/drivers/staging/speakup/i18n.c
>> @@ -470,8 +470,7 @@ static char *find_specifier_end(char *input)
>>   	input++;		/* Advance over %. */
>>   	input = skip_flags(input);
>>   	input = skip_width(input);
>> -	input = skip_conversion(input);
>> -	return input;
>> +	return skip_conversion(input);
>>   }
>>   
>>   /*
>> -- 
>> 2.19.1
>>
>