* [Buildroot] [PATCH 1/1] package/libpcap: fix bluez5_utils-headers dependency
@ 2019-03-18 22:40 Fabrice Fontaine
2019-03-19 4:44 ` Baruch Siach
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Fabrice Fontaine @ 2019-03-18 22:40 UTC (permalink / raw)
To: buildroot
Commit c46afc37dc877f1e94ffde0d77585290711b27ec changed bluez5-utils
dependency by bluez5_utils-headers without replacing the test on
BR2_PACKAGE_BLUEZ5_UTILS by BR2_PACKAGE_BLUEZ5_UTILS_HEADERS
Fix this mistake and also add a select on
BR2_PACKAGE_BLUEZ5_UTILS_HEADERS if BR2_PACKAGE_BLUEZ5_UTILS is set
so the user does not have to do it
Fixes:
- http://autobuild.buildroot.org/results/c6828df1f3782564451ddd4187ff026679bf37d8
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/libpcap/Config.in | 1 +
package/libpcap/libpcap.mk | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/package/libpcap/Config.in b/package/libpcap/Config.in
index 643acbef6e..74429f209a 100644
--- a/package/libpcap/Config.in
+++ b/package/libpcap/Config.in
@@ -1,5 +1,6 @@
config BR2_PACKAGE_LIBPCAP
bool "libpcap"
+ select BR2_PACKAGE_BLUEZ5_UTILS_HEADERS if BR2_PACKAGE_BLUEZ5_UTILS
select BR2_PACKAGE_ZLIB
help
A system-independent library for user-level network packet
diff --git a/package/libpcap/libpcap.mk b/package/libpcap/libpcap.mk
index 2f46426d37..ebceca5273 100644
--- a/package/libpcap/libpcap.mk
+++ b/package/libpcap/libpcap.mk
@@ -26,7 +26,7 @@ define LIBPCAP_CONFIG_REMOVE_RPATH
endef
LIBPCAP_POST_BUILD_HOOKS = LIBPCAP_CONFIG_REMOVE_RPATH
-ifeq ($(BR2_PACKAGE_BLUEZ5_UTILS),y)
+ifeq ($(BR2_PACKAGE_BLUEZ5_UTILS_HEADERS),y)
LIBPCAP_DEPENDENCIES += bluez5_utils-headers
else
LIBPCAP_CONF_OPTS += --disable-bluetooth
--
2.14.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [Buildroot] [PATCH 1/1] package/libpcap: fix bluez5_utils-headers dependency
2019-03-18 22:40 [Buildroot] [PATCH 1/1] package/libpcap: fix bluez5_utils-headers dependency Fabrice Fontaine
@ 2019-03-19 4:44 ` Baruch Siach
2019-03-19 21:31 ` Thomas Petazzoni
2019-03-27 14:37 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Baruch Siach @ 2019-03-19 4:44 UTC (permalink / raw)
To: buildroot
Hi Fabrice,
On Mon, Mar 18, 2019 at 11:40:42PM +0100, Fabrice Fontaine wrote:
> Commit c46afc37dc877f1e94ffde0d77585290711b27ec changed bluez5-utils
> dependency by bluez5_utils-headers without replacing the test on
> BR2_PACKAGE_BLUEZ5_UTILS by BR2_PACKAGE_BLUEZ5_UTILS_HEADERS
>
> Fix this mistake and also add a select on
> BR2_PACKAGE_BLUEZ5_UTILS_HEADERS if BR2_PACKAGE_BLUEZ5_UTILS is set
> so the user does not have to do it
>
> Fixes:
> - http://autobuild.buildroot.org/results/c6828df1f3782564451ddd4187ff026679bf37d8
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Acked-by: Baruch Siach <baruch@tkos.co.il>
Thanks,
baruch
> ---
> package/libpcap/Config.in | 1 +
> package/libpcap/libpcap.mk | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/package/libpcap/Config.in b/package/libpcap/Config.in
> index 643acbef6e..74429f209a 100644
> --- a/package/libpcap/Config.in
> +++ b/package/libpcap/Config.in
> @@ -1,5 +1,6 @@
> config BR2_PACKAGE_LIBPCAP
> bool "libpcap"
> + select BR2_PACKAGE_BLUEZ5_UTILS_HEADERS if BR2_PACKAGE_BLUEZ5_UTILS
> select BR2_PACKAGE_ZLIB
> help
> A system-independent library for user-level network packet
> diff --git a/package/libpcap/libpcap.mk b/package/libpcap/libpcap.mk
> index 2f46426d37..ebceca5273 100644
> --- a/package/libpcap/libpcap.mk
> +++ b/package/libpcap/libpcap.mk
> @@ -26,7 +26,7 @@ define LIBPCAP_CONFIG_REMOVE_RPATH
> endef
> LIBPCAP_POST_BUILD_HOOKS = LIBPCAP_CONFIG_REMOVE_RPATH
>
> -ifeq ($(BR2_PACKAGE_BLUEZ5_UTILS),y)
> +ifeq ($(BR2_PACKAGE_BLUEZ5_UTILS_HEADERS),y)
> LIBPCAP_DEPENDENCIES += bluez5_utils-headers
> else
> LIBPCAP_CONF_OPTS += --disable-bluetooth
> --
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 4+ messages in thread* [Buildroot] [PATCH 1/1] package/libpcap: fix bluez5_utils-headers dependency
2019-03-18 22:40 [Buildroot] [PATCH 1/1] package/libpcap: fix bluez5_utils-headers dependency Fabrice Fontaine
2019-03-19 4:44 ` Baruch Siach
@ 2019-03-19 21:31 ` Thomas Petazzoni
2019-03-27 14:37 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2019-03-19 21:31 UTC (permalink / raw)
To: buildroot
On Mon, 18 Mar 2019 23:40:42 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> Commit c46afc37dc877f1e94ffde0d77585290711b27ec changed bluez5-utils
> dependency by bluez5_utils-headers without replacing the test on
> BR2_PACKAGE_BLUEZ5_UTILS by BR2_PACKAGE_BLUEZ5_UTILS_HEADERS
>
> Fix this mistake and also add a select on
> BR2_PACKAGE_BLUEZ5_UTILS_HEADERS if BR2_PACKAGE_BLUEZ5_UTILS is set
> so the user does not have to do it
>
> Fixes:
> - http://autobuild.buildroot.org/results/c6828df1f3782564451ddd4187ff026679bf37d8
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/libpcap/Config.in | 1 +
> package/libpcap/libpcap.mk | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] package/libpcap: fix bluez5_utils-headers dependency
2019-03-18 22:40 [Buildroot] [PATCH 1/1] package/libpcap: fix bluez5_utils-headers dependency Fabrice Fontaine
2019-03-19 4:44 ` Baruch Siach
2019-03-19 21:31 ` Thomas Petazzoni
@ 2019-03-27 14:37 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2019-03-27 14:37 UTC (permalink / raw)
To: buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> Commit c46afc37dc877f1e94ffde0d77585290711b27ec changed bluez5-utils
> dependency by bluez5_utils-headers without replacing the test on
> BR2_PACKAGE_BLUEZ5_UTILS by BR2_PACKAGE_BLUEZ5_UTILS_HEADERS
> Fix this mistake and also add a select on
> BR2_PACKAGE_BLUEZ5_UTILS_HEADERS if BR2_PACKAGE_BLUEZ5_UTILS is set
> so the user does not have to do it
> Fixes:
> - http://autobuild.buildroot.org/results/c6828df1f3782564451ddd4187ff026679bf37d8
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed to 2019.02.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-03-27 14:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-18 22:40 [Buildroot] [PATCH 1/1] package/libpcap: fix bluez5_utils-headers dependency Fabrice Fontaine
2019-03-19 4:44 ` Baruch Siach
2019-03-19 21:31 ` Thomas Petazzoni
2019-03-27 14:37 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.