From: Johan Hovold <johan@kernel.org>
To: Nishka Dasgupta <nishka.dasgupta@yahoo.com>
Cc: johan@kernel.org, elder@kernel.org, gregkh@linuxfoundation.org,
outreachy-kernel@googlegroups.com
Subject: Re: [PATCH] staging: greybus: Remove parentheses around variable
Date: Wed, 20 Mar 2019 09:50:38 +0100 [thread overview]
Message-ID: <20190320085038.GC15782@localhost> (raw)
In-Reply-To: <20190319200308.10710-1-nishka.dasgupta@yahoo.com>
On Wed, Mar 20, 2019 at 01:33:08AM +0530, Nishka Dasgupta wrote:
> Remove parentheses around variable.
Perhaps
Remove unnecessary parentheses around expression.
would be more accurate.
> Signed-off-by: Nishka Dasgupta <nishka.dasgupta@yahoo.com>
But no need to resend unless you want to. If you do, you can add my ack
before your SoB-tag:
Acked-by: Johan Hovold <johan@kernel.org>
> ---
> drivers/staging/greybus/bundle.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/bundle.c b/drivers/staging/greybus/bundle.c
> index 376ca53f0d83..3f702db9e098 100644
> --- a/drivers/staging/greybus/bundle.c
> +++ b/drivers/staging/greybus/bundle.c
> @@ -32,7 +32,7 @@ static ssize_t state_show(struct device *dev, struct device_attribute *attr,
> {
> struct gb_bundle *bundle = to_gb_bundle(dev);
>
> - if (!(bundle->state))
> + if (!bundle->state)
> return sprintf(buf, "\n");
>
> return sprintf(buf, "%s\n", bundle->state);
Thanks,
Johan
next prev parent reply other threads:[~2019-03-20 8:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-19 20:03 [PATCH] staging: greybus: Remove parentheses around variable Nishka Dasgupta
2019-03-19 20:06 ` [Outreachy kernel] " Julia Lawall
2019-03-20 6:47 ` Greg KH
2019-03-20 6:58 ` Julia Lawall
2019-03-20 8:50 ` Johan Hovold [this message]
2019-03-20 16:02 ` NIshka Dasgupta
2019-03-20 16:31 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190320085038.GC15782@localhost \
--to=johan@kernel.org \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=nishka.dasgupta@yahoo.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.