Re: [PATCH] staging: greybus: Remove parentheses around variable

[Johan Hovold <johan@kernel.org>]

On Wed, Mar 20, 2019 at 09:32:01PM +0530, NIshka Dasgupta wrote:
> 
> 
> On 20/03/19 2:20 PM, Johan Hovold wrote:
> > On Wed, Mar 20, 2019 at 01:33:08AM +0530, Nishka Dasgupta wrote:
> >> Remove parentheses around variable.
> > 
> > Perhaps
> > 
> > 	Remove unnecessary parentheses around expression.
> > 
> > would be more accurate.
> > 
> >> Signed-off-by: Nishka Dasgupta <nishka.dasgupta@yahoo.com>
> > 
> > But no need to resend unless you want to. If you do, you can add my ack
> > before your SoB-tag:
> > 
> > Acked-by: Johan Hovold <johan@kernel.org>
> 
> I would like to resend but I think this patch has already been added to 
> staging-next, so I don't think I should send it again. I could if it's 
> alright.

Greg's trees are generally immutable so once a patch has been applied
(and passed some initial testing) it cannot be replaced and the
corresponding code can only be fixed incrementally.

So no need to resend.

> Thank you for your initial suggestion though, and I'm sorry I wasn't 
> sure about how to acknowledge your help in the patch itself.

No worries at all. And there's no need to give credit for minor review
feedback; reviewers may still provide their Reviewed-by or Acked-by tags
once they're happy with the patch though.

Thanks,
Johan