[PATCH] staging: greybus: Remove parentheses around variable

[PATCH] staging: greybus: Remove parentheses around variable

[Nishka Dasgupta]

Remove parentheses around variable.

Signed-off-by: Nishka Dasgupta <nishka.dasgupta@yahoo.com>
---
 drivers/staging/greybus/bundle.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/greybus/bundle.c b/drivers/staging/greybus/bundle.c
index 376ca53f0d83..3f702db9e098 100644
--- a/drivers/staging/greybus/bundle.c
+++ b/drivers/staging/greybus/bundle.c
@@ -32,7 +32,7 @@ static ssize_t state_show(struct device *dev, struct device_attribute *attr,
 {
 	struct gb_bundle *bundle = to_gb_bundle(dev);
 
-	if (!(bundle->state))
+	if (!bundle->state)
 		return sprintf(buf, "\n");
 
 	return sprintf(buf, "%s\n", bundle->state);
-- 
2.19.1

Re: [Outreachy kernel] [PATCH] staging: greybus: Remove parentheses around variable

[Julia Lawall]

This didn't arrive with a From line that corresponds to your SOB.  You may
need to put From: Nishka Dasgupta <nishka.dasgupta@yahoo.com> at the
beginning of your log message (after the subject line) if you aren't able
to have the message come through with a proper From line.

julia

On Wed, 20 Mar 2019, 'Nishka Dasgupta' via outreachy-kernel wrote:

> Remove parentheses around variable.
>
> Signed-off-by: Nishka Dasgupta <nishka.dasgupta@yahoo.com>
> ---
>  drivers/staging/greybus/bundle.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/bundle.c b/drivers/staging/greybus/bundle.c
> index 376ca53f0d83..3f702db9e098 100644
> --- a/drivers/staging/greybus/bundle.c
> +++ b/drivers/staging/greybus/bundle.c
> @@ -32,7 +32,7 @@ static ssize_t state_show(struct device *dev, struct device_attribute *attr,
>  {
>  	struct gb_bundle *bundle = to_gb_bundle(dev);
>
> -	if (!(bundle->state))
> +	if (!bundle->state)
>  		return sprintf(buf, "\n");
>
>  	return sprintf(buf, "%s\n", bundle->state);
> --
> 2.19.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190319200308.10710-1-nishka.dasgupta%40yahoo.com.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] [PATCH] staging: greybus: Remove parentheses around variable

[Greg KH]

On Tue, Mar 19, 2019 at 09:06:04PM +0100, Julia Lawall wrote:
> This didn't arrive with a From line that corresponds to your SOB.  You may
> need to put From: Nishka Dasgupta <nishka.dasgupta@yahoo.com> at the
> beginning of your log message (after the subject line) if you aren't able
> to have the message come through with a proper From line.

Odd, it looks correct to me.

And you are top-posting :)

thanks,

greg k-h

Re: [Outreachy kernel] [PATCH] staging: greybus: Remove parentheses around variable

[Julia Lawall]

On Wed, 20 Mar 2019, Greg KH wrote:

> On Tue, Mar 19, 2019 at 09:06:04PM +0100, Julia Lawall wrote:
> > This didn't arrive with a From line that corresponds to your SOB.  You may
> > need to put From: Nishka Dasgupta <nishka.dasgupta@yahoo.com> at the
> > beginning of your log message (after the subject line) if you aren't able
> > to have the message come through with a proper From line.
>
> Odd, it looks correct to me.
>
> And you are top-posting :)

Well, I'm complaining about the From line in the message, that is above
my comment :)

I guess that if Nishka has you explicitly in the CC list, you get a
message that looks fine.  The problem is with the ones that come through
the mailing list.

julia

>
> thanks,
>
> greg k-h
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190320064724.GA11556%40kroah.com.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [PATCH] staging: greybus: Remove parentheses around variable

[Johan Hovold]

On Wed, Mar 20, 2019 at 01:33:08AM +0530, Nishka Dasgupta wrote:
> Remove parentheses around variable.

Perhaps 

	Remove unnecessary parentheses around expression.

would be more accurate.

> Signed-off-by: Nishka Dasgupta <nishka.dasgupta@yahoo.com>

But no need to resend unless you want to. If you do, you can add my ack
before your SoB-tag:

Acked-by: Johan Hovold <johan@kernel.org>

> ---
>  drivers/staging/greybus/bundle.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/greybus/bundle.c b/drivers/staging/greybus/bundle.c
> index 376ca53f0d83..3f702db9e098 100644
> --- a/drivers/staging/greybus/bundle.c
> +++ b/drivers/staging/greybus/bundle.c
> @@ -32,7 +32,7 @@ static ssize_t state_show(struct device *dev, struct device_attribute *attr,
>  {
>  	struct gb_bundle *bundle = to_gb_bundle(dev);
>  
> -	if (!(bundle->state))
> +	if (!bundle->state)
>  		return sprintf(buf, "\n");
>  
>  	return sprintf(buf, "%s\n", bundle->state);

Thanks,
Johan

Re: [PATCH] staging: greybus: Remove parentheses around variable

[NIshka Dasgupta]

On 20/03/19 2:20 PM, Johan Hovold wrote:
> On Wed, Mar 20, 2019 at 01:33:08AM +0530, Nishka Dasgupta wrote:
>> Remove parentheses around variable.
> 
> Perhaps
> 
> 	Remove unnecessary parentheses around expression.
> 
> would be more accurate.
> 
>> Signed-off-by: Nishka Dasgupta <nishka.dasgupta@yahoo.com>
> 
> But no need to resend unless you want to. If you do, you can add my ack
> before your SoB-tag:
> 
> Acked-by: Johan Hovold <johan@kernel.org>

I would like to resend but I think this patch has already been added to 
staging-next, so I don't think I should send it again. I could if it's 
alright.
Thank you for your initial suggestion though, and I'm sorry I wasn't 
sure about how to acknowledge your help in the patch itself.

Thanking you,
Nishka Dasgupta

>> ---
>>   drivers/staging/greybus/bundle.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/greybus/bundle.c b/drivers/staging/greybus/bundle.c
>> index 376ca53f0d83..3f702db9e098 100644
>> --- a/drivers/staging/greybus/bundle.c
>> +++ b/drivers/staging/greybus/bundle.c
>> @@ -32,7 +32,7 @@ static ssize_t state_show(struct device *dev, struct device_attribute *attr,
>>   {
>>   	struct gb_bundle *bundle = to_gb_bundle(dev);
>>   
>> -	if (!(bundle->state))
>> +	if (!bundle->state)
>>   		return sprintf(buf, "\n");
>>   
>>   	return sprintf(buf, "%s\n", bundle->state);
> 
> Thanks,
> Johan
> 

Re: [PATCH] staging: greybus: Remove parentheses around variable

[Johan Hovold]

On Wed, Mar 20, 2019 at 09:32:01PM +0530, NIshka Dasgupta wrote:
> 
> 
> On 20/03/19 2:20 PM, Johan Hovold wrote:
> > On Wed, Mar 20, 2019 at 01:33:08AM +0530, Nishka Dasgupta wrote:
> >> Remove parentheses around variable.
> > 
> > Perhaps
> > 
> > 	Remove unnecessary parentheses around expression.
> > 
> > would be more accurate.
> > 
> >> Signed-off-by: Nishka Dasgupta <nishka.dasgupta@yahoo.com>
> > 
> > But no need to resend unless you want to. If you do, you can add my ack
> > before your SoB-tag:
> > 
> > Acked-by: Johan Hovold <johan@kernel.org>
> 
> I would like to resend but I think this patch has already been added to 
> staging-next, so I don't think I should send it again. I could if it's 
> alright.

Greg's trees are generally immutable so once a patch has been applied
(and passed some initial testing) it cannot be replaced and the
corresponding code can only be fixed incrementally.

So no need to resend.

> Thank you for your initial suggestion though, and I'm sorry I wasn't 
> sure about how to acknowledge your help in the patch itself.

No worries at all. And there's no need to give credit for minor review
feedback; reviewers may still provide their Reviewed-by or Acked-by tags
once they're happy with the patch though.

Thanks,
Johan