From: Shawn Guo <shawnguo@kernel.org>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: devicetree@vger.kernel.org, robh+dt@kernel.org,
linux-imx@nxp.com, kernel@pengutronix.de,
Christian Hemp <c.hemp@phytec.de>,
Stefan Christ <s.christ@phytec.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: pfla02: increase phy reset duration
Date: Wed, 20 Mar 2019 16:59:38 +0800 [thread overview]
Message-ID: <20190320085937.GG4980@dragon> (raw)
In-Reply-To: <20190304104940.18138-1-m.felsch@pengutronix.de>
On Mon, Mar 04, 2019 at 11:49:40AM +0100, Marco Felsch wrote:
> Increase the reset duration to ensure correct phy functionality. The
> reset duration is taken from barebox commit 52fdd510de ("ARM: dts:
> pfla02: use long enough reset for ethernet phy"):
>
> Use a longer reset time for ethernet phy Micrel KSZ9031RNX. Otherwise a
> small percentage of modules have 'transmission timeouts' errors like
>
> barebox@Phytec phyFLEX-i.MX6 Quad Carrier-Board:/ ifup eth0
> warning: No MAC address set. Using random address 7e:94:4d:02:f8:f3
> eth0: 1000Mbps full duplex link detected
> eth0: transmission timeout
> T eth0: transmission timeout
> T eth0: transmission timeout
> T eth0: transmission timeout
> T eth0: transmission timeout
>
> Cc: Stefan Christ <s.christ@phytec.de>
> Cc: Christian Hemp <c.hemp@phytec.de>
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
Do you want to get this in as a fix or just -next material? If it's a
fix, please have a Fixes tag.
Shawn
> ---
> arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
> index 673711f445b6..7e53ac6cfa8a 100644
> --- a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
> @@ -91,6 +91,7 @@
> pinctrl-0 = <&pinctrl_enet>;
> phy-handle = <ðphy>;
> phy-mode = "rgmii";
> + phy-reset-duration = <10>; /* in msecs */
> phy-reset-gpios = <&gpio3 23 GPIO_ACTIVE_LOW>;
> phy-supply = <&vdd_eth_io_reg>;
> status = "disabled";
> --
> 2.20.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: devicetree@vger.kernel.org, robh+dt@kernel.org,
linux-imx@nxp.com, kernel@pengutronix.de,
Christian Hemp <c.hemp@phytec.de>,
Stefan Christ <s.christ@phytec.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: pfla02: increase phy reset duration
Date: Wed, 20 Mar 2019 16:59:38 +0800 [thread overview]
Message-ID: <20190320085937.GG4980@dragon> (raw)
In-Reply-To: <20190304104940.18138-1-m.felsch@pengutronix.de>
On Mon, Mar 04, 2019 at 11:49:40AM +0100, Marco Felsch wrote:
> Increase the reset duration to ensure correct phy functionality. The
> reset duration is taken from barebox commit 52fdd510de ("ARM: dts:
> pfla02: use long enough reset for ethernet phy"):
>
> Use a longer reset time for ethernet phy Micrel KSZ9031RNX. Otherwise a
> small percentage of modules have 'transmission timeouts' errors like
>
> barebox@Phytec phyFLEX-i.MX6 Quad Carrier-Board:/ ifup eth0
> warning: No MAC address set. Using random address 7e:94:4d:02:f8:f3
> eth0: 1000Mbps full duplex link detected
> eth0: transmission timeout
> T eth0: transmission timeout
> T eth0: transmission timeout
> T eth0: transmission timeout
> T eth0: transmission timeout
>
> Cc: Stefan Christ <s.christ@phytec.de>
> Cc: Christian Hemp <c.hemp@phytec.de>
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
Do you want to get this in as a fix or just -next material? If it's a
fix, please have a Fixes tag.
Shawn
> ---
> arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
> index 673711f445b6..7e53ac6cfa8a 100644
> --- a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
> @@ -91,6 +91,7 @@
> pinctrl-0 = <&pinctrl_enet>;
> phy-handle = <ðphy>;
> phy-mode = "rgmii";
> + phy-reset-duration = <10>; /* in msecs */
> phy-reset-gpios = <&gpio3 23 GPIO_ACTIVE_LOW>;
> phy-supply = <&vdd_eth_io_reg>;
> status = "disabled";
> --
> 2.20.1
>
next prev parent reply other threads:[~2019-03-20 9:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-04 10:49 [PATCH] ARM: dts: pfla02: increase phy reset duration Marco Felsch
2019-03-04 10:49 ` Marco Felsch
2019-03-20 8:59 ` Shawn Guo [this message]
2019-03-20 8:59 ` Shawn Guo
2019-03-20 10:10 ` Marco Felsch
2019-03-20 10:10 ` Marco Felsch
2019-03-20 11:37 ` Shawn Guo
2019-03-20 11:37 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190320085937.GG4980@dragon \
--to=shawnguo@kernel.org \
--cc=c.hemp@phytec.de \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=m.felsch@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=s.christ@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.