From: Dan Carpenter <dan.carpenter@oracle.com>
To: Yifeng Li <tomli@tomli.me>
Cc: Jiri Kosina <trivial@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, Jin Chen <nobijinc@gmail.com>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Teddy Wang <teddy.wang@siliconmotion.com>
Subject: Re: [RESEND][PATCH 2/2] staging: sm750fb: trivial Camel Case removal for setDisplayControl().
Date: Wed, 20 Mar 2019 12:36:23 +0000 [thread overview]
Message-ID: <20190320123622.GH2202@kadam> (raw)
In-Reply-To: <20190303165532.23727-3-tomli@tomli.me>
On Mon, Mar 04, 2019 at 12:55:32AM +0800, Yifeng Li wrote:
> Rename the function setDisplayControl() to set_display_control().
> This fixes the following checkpatch.pl warning:
>
> CHECK: Avoid CamelCase: <setDisplayControl>
>
> Suggested-by: Jin Chen <nobijinc@gmail.com>
> Signed-off-by: Jin Chen <nobijinc@gmail.com>
> [tomli@tomli.me: resent as trivial patch, reworded the commit message]
> Signed-off-by: Yifeng Li <tomli@tomli.me>
> ---
Apparently Greg already applied this earlier... I don't know why the
original patch didn't reach me. I'm on the devel@driverdev.osuosl.org
list.
Did Jin Chen write this? If so why does it have a Suggested-by tag for
him? If not then you should have preserved the authorship credit by
using the From: header in the first line on the commit message...
Anyway, it doesn't matter but hopefully this helps for next time.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Yifeng Li <tomli@tomli.me>
Cc: Jiri Kosina <trivial@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, Jin Chen <nobijinc@gmail.com>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Teddy Wang <teddy.wang@siliconmotion.com>
Subject: Re: [RESEND][PATCH 2/2] staging: sm750fb: trivial Camel Case removal for setDisplayControl().
Date: Wed, 20 Mar 2019 15:36:23 +0300 [thread overview]
Message-ID: <20190320123622.GH2202@kadam> (raw)
In-Reply-To: <20190303165532.23727-3-tomli@tomli.me>
On Mon, Mar 04, 2019 at 12:55:32AM +0800, Yifeng Li wrote:
> Rename the function setDisplayControl() to set_display_control().
> This fixes the following checkpatch.pl warning:
>
> CHECK: Avoid CamelCase: <setDisplayControl>
>
> Suggested-by: Jin Chen <nobijinc@gmail.com>
> Signed-off-by: Jin Chen <nobijinc@gmail.com>
> [tomli@tomli.me: resent as trivial patch, reworded the commit message]
> Signed-off-by: Yifeng Li <tomli@tomli.me>
> ---
Apparently Greg already applied this earlier... I don't know why the
original patch didn't reach me. I'm on the devel@driverdev.osuosl.org
list.
Did Jin Chen write this? If so why does it have a Suggested-by tag for
him? If not then you should have preserved the authorship credit by
using the From: header in the first line on the commit message...
Anyway, it doesn't matter but hopefully this helps for next time.
regards,
dan carpenter
next prev parent reply other threads:[~2019-03-20 12:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-03 16:55 [RESEND][PATCH 0/2] staging: sm750fb: trivial style fixes Yifeng Li
2019-03-03 16:55 ` Yifeng Li
2019-03-03 16:55 ` [RESEND][PATCH 1/2] staging: sm750fb: trivial comment indention fix Yifeng Li
2019-03-03 16:55 ` Yifeng Li
2019-03-03 16:55 ` [RESEND][PATCH 2/2] staging: sm750fb: trivial Camel Case removal for setDisplayControl() Yifeng Li
2019-03-03 16:55 ` Yifeng Li
2019-03-07 20:22 ` Greg Kroah-Hartman
2019-03-07 20:22 ` Greg Kroah-Hartman
2019-03-20 12:36 ` Dan Carpenter [this message]
2019-03-20 12:36 ` Dan Carpenter
2019-03-03 17:56 ` [RESEND][PATCH 0/2] staging: sm750fb: trivial style fixes Greg Kroah-Hartman
2019-03-03 17:56 ` Greg Kroah-Hartman
2019-03-20 5:13 ` Greg Kroah-Hartman
2019-03-20 5:13 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190320123622.GH2202@kadam \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nobijinc@gmail.com \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
--cc=tomli@tomli.me \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.