From: Chandan Rajendra <chandan@linux.ibm.com>
To: fstests@vger.kernel.org
Cc: Chandan Rajendra <chandan@linux.ibm.com>,
guaneryu@gmail.com, linux-xfs@vger.kernel.org
Subject: [PATCH] _require_prjquota: Disable tests only when using realtime fs
Date: Wed, 20 Mar 2019 19:51:12 +0530 [thread overview]
Message-ID: <20190320142112.31239-1-chandan@linux.ibm.com> (raw)
$USE_EXTERNAL needs to be set when using external log devices. In such a
setup, tests which have "_require_prjquota
$SCRATCH_DEV" (e.g. generic/383) incorrectly end up being marked as
"not run" since the test "[ "$USE_EXTERNAL" = yes -a ! -z "$_dev" ]"
evaluates to true.
This commit fixes the bug by marking the test as "not run" only when
$USE_EXTERNAL is set and one of $TEST_RTDEV or $SCRATCH_RTDEV is set.
Signed-off-by: Chandan Rajendra <chandan@linux.ibm.com>
---
common/quota | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/common/quota b/common/quota
index 9309e786..cb627f19 100644
--- a/common/quota
+++ b/common/quota
@@ -86,8 +86,9 @@ _require_prjquota()
fi
src/feature -P $_dev
[ $? -ne 0 ] && _notrun "Installed kernel does not support project quotas"
- if [ "$USE_EXTERNAL" = yes -a ! -z "$_dev" ]; then
- _notrun "Project quotas not supported on realtime filesystem"
+ if [ "$USE_EXTERNAL" = yes -a \
+ \( ! -z "$TEST_RTDEV" \-o ! -z "$SCRATCH_RTDEV" \) ]; then
+ _notrun "Project quotas not supported on realtime filesystem"
fi
}
--
2.19.1
next reply other threads:[~2019-03-20 14:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 14:21 Chandan Rajendra [this message]
2019-03-23 11:44 ` [PATCH] _require_prjquota: Disable tests only when using realtime fs Eryu Guan
2019-03-24 4:12 ` Chandan Rajendra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190320142112.31239-1-chandan@linux.ibm.com \
--to=chandan@linux.ibm.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.