* [PATCH] watchdog: alim7101: Mark expected switch fall-through
@ 2019-03-20 18:16 Gustavo A. R. Silva
2019-03-21 0:12 ` Guenter Roeck
0 siblings, 1 reply; 6+ messages in thread
From: Gustavo A. R. Silva @ 2019-03-20 18:16 UTC (permalink / raw)
To: Wim Van Sebroeck, Guenter Roeck
Cc: linux-watchdog, linux-kernel, Gustavo A. R. Silva, Kees Cook
In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.
This patch fixes the following warning:
drivers/watchdog/alim7101_wdt.c: In function ‘fop_ioctl’:
drivers/watchdog/alim7101_wdt.c:279:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
wdt_keepalive();
^~~~~~~~~~~~~~~
drivers/watchdog/alim7101_wdt.c:282:2: note: here
case WDIOC_GETTIMEOUT:
^~~~
Notice that, in this particular case, the /* Fall through */
comment is placed at the very bottom of the case statement,
which is what GCC is expecting to find.
Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enabling
-Wimplicit-fallthrough.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/watchdog/alim7101_wdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/watchdog/alim7101_wdt.c b/drivers/watchdog/alim7101_wdt.c
index 12f7ea62dddd..f5ada07e9202 100644
--- a/drivers/watchdog/alim7101_wdt.c
+++ b/drivers/watchdog/alim7101_wdt.c
@@ -277,8 +277,8 @@ static long fop_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
return -EINVAL;
timeout = new_timeout;
wdt_keepalive();
- /* Fall through */
}
+ /* Fall through */
case WDIOC_GETTIMEOUT:
return put_user(timeout, p);
default:
--
2.21.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] watchdog: alim7101: Mark expected switch fall-through
2019-03-20 18:16 [PATCH] watchdog: alim7101: Mark expected switch fall-through Gustavo A. R. Silva
@ 2019-03-21 0:12 ` Guenter Roeck
2019-03-21 0:15 ` Gustavo A. R. Silva
0 siblings, 1 reply; 6+ messages in thread
From: Guenter Roeck @ 2019-03-21 0:12 UTC (permalink / raw)
To: Gustavo A. R. Silva, Wim Van Sebroeck
Cc: linux-watchdog, linux-kernel, Kees Cook
On 3/20/19 11:16 AM, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
>
> This patch fixes the following warning:
>
> drivers/watchdog/alim7101_wdt.c: In function ‘fop_ioctl’:
> drivers/watchdog/alim7101_wdt.c:279:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
> wdt_keepalive();
> ^~~~~~~~~~~~~~~
> drivers/watchdog/alim7101_wdt.c:282:2: note: here
> case WDIOC_GETTIMEOUT:
> ^~~~
>
> Notice that, in this particular case, the /* Fall through */
> comment is placed at the very bottom of the case statement,
> which is what GCC is expecting to find.
>
> Warning level 3 was used: -Wimplicit-fallthrough=3
>
> This patch is part of the ongoing efforts to enabling
> -Wimplicit-fallthrough.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/alim7101_wdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/alim7101_wdt.c b/drivers/watchdog/alim7101_wdt.c
> index 12f7ea62dddd..f5ada07e9202 100644
> --- a/drivers/watchdog/alim7101_wdt.c
> +++ b/drivers/watchdog/alim7101_wdt.c
> @@ -277,8 +277,8 @@ static long fop_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
> return -EINVAL;
> timeout = new_timeout;
> wdt_keepalive();
> - /* Fall through */
> }
> + /* Fall through */
> case WDIOC_GETTIMEOUT:
> return put_user(timeout, p);
> default:
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] watchdog: alim7101: Mark expected switch fall-through
2019-03-21 0:12 ` Guenter Roeck
@ 2019-03-21 0:15 ` Gustavo A. R. Silva
2019-04-05 18:04 ` Gustavo A. R. Silva
0 siblings, 1 reply; 6+ messages in thread
From: Gustavo A. R. Silva @ 2019-03-21 0:15 UTC (permalink / raw)
To: Guenter Roeck, Wim Van Sebroeck; +Cc: linux-watchdog, linux-kernel, Kees Cook
On 3/20/19 7:12 PM, Guenter Roeck wrote:
> On 3/20/19 11:16 AM, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>> cases where we are expecting to fall through.
>>
>> This patch fixes the following warning:
>>
>> drivers/watchdog/alim7101_wdt.c: In function ‘fop_ioctl’:
>> drivers/watchdog/alim7101_wdt.c:279:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
>> wdt_keepalive();
>> ^~~~~~~~~~~~~~~
>> drivers/watchdog/alim7101_wdt.c:282:2: note: here
>> case WDIOC_GETTIMEOUT:
>> ^~~~
>>
>> Notice that, in this particular case, the /* Fall through */
>> comment is placed at the very bottom of the case statement,
>> which is what GCC is expecting to find.
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> This patch is part of the ongoing efforts to enabling
>> -Wimplicit-fallthrough.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>
Thanks, Guenter. :)
--
Gustavo
>> ---
>> drivers/watchdog/alim7101_wdt.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/watchdog/alim7101_wdt.c b/drivers/watchdog/alim7101_wdt.c
>> index 12f7ea62dddd..f5ada07e9202 100644
>> --- a/drivers/watchdog/alim7101_wdt.c
>> +++ b/drivers/watchdog/alim7101_wdt.c
>> @@ -277,8 +277,8 @@ static long fop_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
>> return -EINVAL;
>> timeout = new_timeout;
>> wdt_keepalive();
>> - /* Fall through */
>> }
>> + /* Fall through */
>> case WDIOC_GETTIMEOUT:
>> return put_user(timeout, p);
>> default:
>>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] watchdog: alim7101: Mark expected switch fall-through
2019-03-21 0:15 ` Gustavo A. R. Silva
@ 2019-04-05 18:04 ` Gustavo A. R. Silva
2019-04-05 20:55 ` Guenter Roeck
0 siblings, 1 reply; 6+ messages in thread
From: Gustavo A. R. Silva @ 2019-04-05 18:04 UTC (permalink / raw)
To: Guenter Roeck, Wim Van Sebroeck; +Cc: linux-watchdog, linux-kernel, Kees Cook
Hi all,
Friendly ping:
Who can take this?
Thanks
--
Gustavo
On 3/20/19 7:15 PM, Gustavo A. R. Silva wrote:
>
>
> On 3/20/19 7:12 PM, Guenter Roeck wrote:
>> On 3/20/19 11:16 AM, Gustavo A. R. Silva wrote:
>>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>>> cases where we are expecting to fall through.
>>>
>>> This patch fixes the following warning:
>>>
>>> drivers/watchdog/alim7101_wdt.c: In function ‘fop_ioctl’:
>>> drivers/watchdog/alim7101_wdt.c:279:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
>>> wdt_keepalive();
>>> ^~~~~~~~~~~~~~~
>>> drivers/watchdog/alim7101_wdt.c:282:2: note: here
>>> case WDIOC_GETTIMEOUT:
>>> ^~~~
>>>
>>> Notice that, in this particular case, the /* Fall through */
>>> comment is placed at the very bottom of the case statement,
>>> which is what GCC is expecting to find.
>>>
>>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>>
>>> This patch is part of the ongoing efforts to enabling
>>> -Wimplicit-fallthrough.
>>>
>>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>>
>> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>>
>
> Thanks, Guenter. :)
>
> --
> Gustavo
>
>>> ---
>>> drivers/watchdog/alim7101_wdt.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/watchdog/alim7101_wdt.c b/drivers/watchdog/alim7101_wdt.c
>>> index 12f7ea62dddd..f5ada07e9202 100644
>>> --- a/drivers/watchdog/alim7101_wdt.c
>>> +++ b/drivers/watchdog/alim7101_wdt.c
>>> @@ -277,8 +277,8 @@ static long fop_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
>>> return -EINVAL;
>>> timeout = new_timeout;
>>> wdt_keepalive();
>>> - /* Fall through */
>>> }
>>> + /* Fall through */
>>> case WDIOC_GETTIMEOUT:
>>> return put_user(timeout, p);
>>> default:
>>>
>>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] watchdog: alim7101: Mark expected switch fall-through
2019-04-05 18:04 ` Gustavo A. R. Silva
@ 2019-04-05 20:55 ` Guenter Roeck
2019-04-05 21:41 ` Gustavo A. R. Silva
0 siblings, 1 reply; 6+ messages in thread
From: Guenter Roeck @ 2019-04-05 20:55 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Wim Van Sebroeck, linux-watchdog, linux-kernel, Kees Cook
On Fri, Apr 05, 2019 at 01:04:27PM -0500, Gustavo A. R. Silva wrote:
> Hi all,
>
> Friendly ping:
>
> Who can take this?
I added it to my watchdog-next branch. Usually Wim will pick it up from there.
Guenter
>
> Thanks
> --
> Gustavo
>
> On 3/20/19 7:15 PM, Gustavo A. R. Silva wrote:
> >
> >
> > On 3/20/19 7:12 PM, Guenter Roeck wrote:
> >> On 3/20/19 11:16 AM, Gustavo A. R. Silva wrote:
> >>> In preparation to enabling -Wimplicit-fallthrough, mark switch
> >>> cases where we are expecting to fall through.
> >>>
> >>> This patch fixes the following warning:
> >>>
> >>> drivers/watchdog/alim7101_wdt.c: In function ‘fop_ioctl’:
> >>> drivers/watchdog/alim7101_wdt.c:279:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
> >>> wdt_keepalive();
> >>> ^~~~~~~~~~~~~~~
> >>> drivers/watchdog/alim7101_wdt.c:282:2: note: here
> >>> case WDIOC_GETTIMEOUT:
> >>> ^~~~
> >>>
> >>> Notice that, in this particular case, the /* Fall through */
> >>> comment is placed at the very bottom of the case statement,
> >>> which is what GCC is expecting to find.
> >>>
> >>> Warning level 3 was used: -Wimplicit-fallthrough=3
> >>>
> >>> This patch is part of the ongoing efforts to enabling
> >>> -Wimplicit-fallthrough.
> >>>
> >>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> >>
> >> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> >>
> >
> > Thanks, Guenter. :)
> >
> > --
> > Gustavo
> >
> >>> ---
> >>> drivers/watchdog/alim7101_wdt.c | 2 +-
> >>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/drivers/watchdog/alim7101_wdt.c b/drivers/watchdog/alim7101_wdt.c
> >>> index 12f7ea62dddd..f5ada07e9202 100644
> >>> --- a/drivers/watchdog/alim7101_wdt.c
> >>> +++ b/drivers/watchdog/alim7101_wdt.c
> >>> @@ -277,8 +277,8 @@ static long fop_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
> >>> return -EINVAL;
> >>> timeout = new_timeout;
> >>> wdt_keepalive();
> >>> - /* Fall through */
> >>> }
> >>> + /* Fall through */
> >>> case WDIOC_GETTIMEOUT:
> >>> return put_user(timeout, p);
> >>> default:
> >>>
> >>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] watchdog: alim7101: Mark expected switch fall-through
2019-04-05 20:55 ` Guenter Roeck
@ 2019-04-05 21:41 ` Gustavo A. R. Silva
0 siblings, 0 replies; 6+ messages in thread
From: Gustavo A. R. Silva @ 2019-04-05 21:41 UTC (permalink / raw)
To: Guenter Roeck; +Cc: Wim Van Sebroeck, linux-watchdog, linux-kernel, Kees Cook
On 4/5/19 3:55 PM, Guenter Roeck wrote:
> On Fri, Apr 05, 2019 at 01:04:27PM -0500, Gustavo A. R. Silva wrote:
>> Hi all,
>>
>> Friendly ping:
>>
>> Who can take this?
>
> I added it to my watchdog-next branch. Usually Wim will pick it up from there.
>
Awesome. :)
Thanks, Guenter.
--
Gustavo
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-04-05 22:05 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-20 18:16 [PATCH] watchdog: alim7101: Mark expected switch fall-through Gustavo A. R. Silva
2019-03-21 0:12 ` Guenter Roeck
2019-03-21 0:15 ` Gustavo A. R. Silva
2019-04-05 18:04 ` Gustavo A. R. Silva
2019-04-05 20:55 ` Guenter Roeck
2019-04-05 21:41 ` Gustavo A. R. Silva
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.