* [PATCH -next] ipmi: Make ipmi_interfaces_srcu variable static
@ 2019-03-20 13:35 Yue Haibing
2019-03-21 12:27 ` Corey Minyard
0 siblings, 1 reply; 2+ messages in thread
From: Yue Haibing @ 2019-03-20 13:35 UTC (permalink / raw)
To: cminyard, minyard, arnd, gregkh
Cc: linux-kernel, openipmi-developer, YueHaibing
From: YueHaibing <yuehaibing@huawei.com>
Fix sparse warning:
drivers/char/ipmi/ipmi_msghandler.c:635:20: warning:
symbol 'ipmi_interfaces_srcu' was not declared. Should it be static?
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/char/ipmi/ipmi_msghandler.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c
index c35f2bc..7ebdde4 100644
--- a/drivers/char/ipmi/ipmi_msghandler.c
+++ b/drivers/char/ipmi/ipmi_msghandler.c
@@ -632,7 +632,7 @@ static DEFINE_MUTEX(ipmidriver_mutex);
static LIST_HEAD(ipmi_interfaces);
static DEFINE_MUTEX(ipmi_interfaces_mutex);
-struct srcu_struct ipmi_interfaces_srcu;
+static struct srcu_struct ipmi_interfaces_srcu;
/*
* List of watchers that want to know when smi's are added and deleted.
--
2.7.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] ipmi: Make ipmi_interfaces_srcu variable static
2019-03-20 13:35 [PATCH -next] ipmi: Make ipmi_interfaces_srcu variable static Yue Haibing
@ 2019-03-21 12:27 ` Corey Minyard
0 siblings, 0 replies; 2+ messages in thread
From: Corey Minyard @ 2019-03-21 12:27 UTC (permalink / raw)
To: Yue Haibing; +Cc: cminyard, arnd, gregkh, linux-kernel, openipmi-developer
On Wed, Mar 20, 2019 at 09:35:05PM +0800, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warning:
>
> drivers/char/ipmi/ipmi_msghandler.c:635:20: warning:
> symbol 'ipmi_interfaces_srcu' was not declared. Should it be static?
Queued for Linux 5.1. Thanks
-corey
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/char/ipmi/ipmi_msghandler.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c
> index c35f2bc..7ebdde4 100644
> --- a/drivers/char/ipmi/ipmi_msghandler.c
> +++ b/drivers/char/ipmi/ipmi_msghandler.c
> @@ -632,7 +632,7 @@ static DEFINE_MUTEX(ipmidriver_mutex);
>
> static LIST_HEAD(ipmi_interfaces);
> static DEFINE_MUTEX(ipmi_interfaces_mutex);
> -struct srcu_struct ipmi_interfaces_srcu;
> +static struct srcu_struct ipmi_interfaces_srcu;
>
> /*
> * List of watchers that want to know when smi's are added and deleted.
> --
> 2.7.0
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-21 12:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-20 13:35 [PATCH -next] ipmi: Make ipmi_interfaces_srcu variable static Yue Haibing
2019-03-21 12:27 ` Corey Minyard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.