From: "Michael S. Tsirkin" <mst@redhat.com>
To: Liran Alon <liran.alon@oracle.com>
Cc: vuhuong@mellanox.com, Jiri Pirko <jiri@resnulli.us>,
Jakub Kicinski <kubakici@wp.pl>,
Sridhar Samudrala <sridhar.samudrala@intel.com>,
Alexander Duyck <alexander.duyck@gmail.com>,
virtualization@lists.linux-foundation.org,
Netdev <netdev@vger.kernel.org>,
Si-Wei Liu <si-wei.liu@oracle.com>,
boris.ostrovsky@oracle.com, David Miller <davem@davemloft.net>,
ogerlitz@mellanox.com
Subject: Re: [summary] virtio network device failover writeup
Date: Thu, 21 Mar 2019 13:12:23 -0400 [thread overview]
Message-ID: <20190321131006-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <BC327EF2-22C7-402B-9078-93891A4774D6@oracle.com>
On Thu, Mar 21, 2019 at 06:31:35PM +0200, Liran Alon wrote:
>
>
> > On 21 Mar 2019, at 17:50, Michael S. Tsirkin <mst@redhat.com> wrote:
> >
> > On Thu, Mar 21, 2019 at 08:45:17AM -0700, Stephen Hemminger wrote:
> >> On Thu, 21 Mar 2019 15:04:37 +0200
> >> Liran Alon <liran.alon@oracle.com> wrote:
> >>
> >>>>
> >>>> OK. Now what happens if master is moved to another namespace? Do we need
> >>>> to move the slaves too?
> >>>
> >>> No. Why would we move the slaves? The whole point is to make most customer ignore the net-failover slaves and remain them “hidden” in their dedicated netns.
> >>> We won’t prevent customer from explicitly moving the net-failover slaves out of this netns, but we will not move them out of there automatically.
> >>
> >>
> >> The 2-device netvsc already handles case where master changes namespace.
> >
> > Is it by moving slave with it?
>
> See c0a41b887ce6 ("hv_netvsc: move VF to same namespace as netvsc device”).
> It seems that when NetVSC master netdev changes netns, the VF is moved to the same netns by the NetVSC driver.
> Kinda the opposite than what we are suggesting here to make sure that the net-failover master netdev is on a separate
> netns than it’s slaves...
>
> -Liran
>
> >
> > --
> > MST
Not exactly opposite I'd say.
If failover is in host ns, slaves in /primary and /standby, then moving
failover to /container should move slaves to /container/primary and
/container/standby.
--
MST
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Liran Alon <liran.alon@oracle.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
Si-Wei Liu <si-wei.liu@oracle.com>,
Sridhar Samudrala <sridhar.samudrala@intel.com>,
Alexander Duyck <alexander.duyck@gmail.com>,
Jakub Kicinski <kubakici@wp.pl>, Jiri Pirko <jiri@resnulli.us>,
David Miller <davem@davemloft.net>,
Netdev <netdev@vger.kernel.org>,
virtualization@lists.linux-foundation.org,
boris.ostrovsky@oracle.com, vijay.balakrishna@oracle.com,
jfreimann@redhat.com, ogerlitz@mellanox.com,
vuhuong@mellanox.com
Subject: Re: [summary] virtio network device failover writeup
Date: Thu, 21 Mar 2019 13:12:23 -0400 [thread overview]
Message-ID: <20190321131006-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <BC327EF2-22C7-402B-9078-93891A4774D6@oracle.com>
On Thu, Mar 21, 2019 at 06:31:35PM +0200, Liran Alon wrote:
>
>
> > On 21 Mar 2019, at 17:50, Michael S. Tsirkin <mst@redhat.com> wrote:
> >
> > On Thu, Mar 21, 2019 at 08:45:17AM -0700, Stephen Hemminger wrote:
> >> On Thu, 21 Mar 2019 15:04:37 +0200
> >> Liran Alon <liran.alon@oracle.com> wrote:
> >>
> >>>>
> >>>> OK. Now what happens if master is moved to another namespace? Do we need
> >>>> to move the slaves too?
> >>>
> >>> No. Why would we move the slaves? The whole point is to make most customer ignore the net-failover slaves and remain them “hidden” in their dedicated netns.
> >>> We won’t prevent customer from explicitly moving the net-failover slaves out of this netns, but we will not move them out of there automatically.
> >>
> >>
> >> The 2-device netvsc already handles case where master changes namespace.
> >
> > Is it by moving slave with it?
>
> See c0a41b887ce6 ("hv_netvsc: move VF to same namespace as netvsc device”).
> It seems that when NetVSC master netdev changes netns, the VF is moved to the same netns by the NetVSC driver.
> Kinda the opposite than what we are suggesting here to make sure that the net-failover master netdev is on a separate
> netns than it’s slaves...
>
> -Liran
>
> >
> > --
> > MST
Not exactly opposite I'd say.
If failover is in host ns, slaves in /primary and /standby, then moving
failover to /container should move slaves to /container/primary and
/container/standby.
--
MST
next prev parent reply other threads:[~2019-03-21 17:12 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-17 13:55 [summary] virtio network device failover writeup Michael S. Tsirkin
2019-03-19 12:38 ` Liran Alon
2019-03-19 15:46 ` Stephen Hemminger
2019-03-19 15:46 ` Stephen Hemminger
2019-03-19 21:19 ` Michael S. Tsirkin
2019-03-19 21:19 ` Michael S. Tsirkin
2019-03-19 23:25 ` Liran Alon
2019-03-19 23:25 ` Liran Alon
2019-03-20 10:25 ` Michael S. Tsirkin
2019-03-20 12:23 ` Liran Alon
2019-03-20 14:09 ` Michael S. Tsirkin
2019-03-20 14:09 ` Michael S. Tsirkin
2019-03-20 21:43 ` Liran Alon
2019-03-20 21:43 ` Liran Alon
2019-03-20 22:10 ` Michael S. Tsirkin
2019-03-20 22:19 ` Liran Alon
2019-03-21 8:58 ` Michael S. Tsirkin
2019-03-21 8:58 ` Michael S. Tsirkin
2019-03-21 10:07 ` Liran Alon
2019-03-21 10:07 ` Liran Alon
2019-03-21 12:37 ` Michael S. Tsirkin
2019-03-21 12:47 ` Liran Alon
2019-03-21 12:47 ` Liran Alon
2019-03-21 12:57 ` Michael S. Tsirkin
2019-03-21 13:04 ` Liran Alon
2019-03-21 13:04 ` Liran Alon
2019-03-21 13:12 ` Michael S. Tsirkin
2019-03-21 13:12 ` Michael S. Tsirkin
2019-03-21 13:24 ` Liran Alon
2019-03-21 13:51 ` Michael S. Tsirkin
2019-03-21 14:16 ` Liran Alon
2019-03-21 15:15 ` Michael S. Tsirkin
2019-03-21 15:15 ` Michael S. Tsirkin
2019-03-21 14:16 ` Liran Alon
2019-03-21 13:51 ` Michael S. Tsirkin
2019-03-21 13:24 ` Liran Alon
2019-03-21 15:45 ` Stephen Hemminger
2019-03-21 15:45 ` Stephen Hemminger
2019-03-21 15:50 ` Michael S. Tsirkin
2019-03-21 16:31 ` Liran Alon
2019-03-21 17:12 ` Michael S. Tsirkin [this message]
2019-03-21 17:12 ` Michael S. Tsirkin
2019-03-21 17:15 ` Liran Alon
2019-03-21 17:15 ` Liran Alon
2019-03-21 16:31 ` Liran Alon
2019-03-21 15:50 ` Michael S. Tsirkin
2019-03-21 15:44 ` Stephen Hemminger
2019-03-21 15:44 ` Stephen Hemminger
2019-03-21 22:33 ` si-wei liu
2019-03-21 12:57 ` Michael S. Tsirkin
2019-03-21 12:37 ` Michael S. Tsirkin
2019-03-20 22:19 ` Liran Alon
2019-03-20 22:10 ` Michael S. Tsirkin
2019-03-20 12:23 ` Liran Alon
2019-03-20 10:25 ` Michael S. Tsirkin
2019-03-19 21:06 ` Michael S. Tsirkin
2019-03-19 23:05 ` Liran Alon
2019-03-19 23:05 ` Liran Alon
2019-03-19 21:06 ` Michael S. Tsirkin
2019-03-19 21:55 ` si-wei liu
2019-03-19 12:38 ` Liran Alon
-- strict thread matches above, loose matches on Subject: below --
2019-03-17 13:55 Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190321131006-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=alexander.duyck@gmail.com \
--cc=boris.ostrovsky@oracle.com \
--cc=davem@davemloft.net \
--cc=jiri@resnulli.us \
--cc=kubakici@wp.pl \
--cc=liran.alon@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=si-wei.liu@oracle.com \
--cc=sridhar.samudrala@intel.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=vuhuong@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.