From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-nvdimm@lists.01.org, James Bottomley <jejb@linux.ibm.com>,
Roberto Sassu <roberto.sassu@huawei.com>,
linux-kernel@vger.kernel.org, Mimi Zohar <zohar@linux.ibm.com>,
David Howells <dhowells@redhat.com>,
keyrings@vger.kernel.org
Subject: Re: [PATCH] security/keys/trusted: Allow operation without hardware TPM
Date: Thu, 21 Mar 2019 13:54:51 +0000 [thread overview]
Message-ID: <20190321135451.GD4603@linux.intel.com> (raw)
In-Reply-To: <155295271345.1945351.6465460744078693578.stgit@dwillia2-desk3.amr.corp.intel.com>
On Mon, Mar 18, 2019 at 04:45:13PM -0700, Dan Williams wrote:
> Rather than fail initialization of the trusted.ko module, arrange for
> the module to load, but rely on trusted_instantiate() to fail
> trusted-key operations.
>
> Fixes: 240730437deb ("KEYS: trusted: explicitly use tpm_chip structure...")
> Cc: Roberto Sassu <roberto.sassu@huawei.com>
> Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> Cc: James Bottomley <jejb@linux.ibm.com>
> Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> Cc: Mimi Zohar <zohar@linux.ibm.com>
> Cc: David Howells <dhowells@redhat.com>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
It should check for chip in each function that uses TPM now that
the code does not rely on default chip. Otherwise, the semantics
are kind of inconsistent.
/Jarkko
WARNING: multiple messages have this Message-ID (diff)
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-nvdimm@lists.01.org, James Bottomley <jejb@linux.ibm.com>,
Roberto Sassu <roberto.sassu@huawei.com>,
linux-kernel@vger.kernel.org, Mimi Zohar <zohar@linux.ibm.com>,
David Howells <dhowells@redhat.com>,
keyrings@vger.kernel.org
Subject: Re: [PATCH] security/keys/trusted: Allow operation without hardware TPM
Date: Thu, 21 Mar 2019 15:54:51 +0200 [thread overview]
Message-ID: <20190321135451.GD4603@linux.intel.com> (raw)
In-Reply-To: <155295271345.1945351.6465460744078693578.stgit@dwillia2-desk3.amr.corp.intel.com>
On Mon, Mar 18, 2019 at 04:45:13PM -0700, Dan Williams wrote:
> Rather than fail initialization of the trusted.ko module, arrange for
> the module to load, but rely on trusted_instantiate() to fail
> trusted-key operations.
>
> Fixes: 240730437deb ("KEYS: trusted: explicitly use tpm_chip structure...")
> Cc: Roberto Sassu <roberto.sassu@huawei.com>
> Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> Cc: James Bottomley <jejb@linux.ibm.com>
> Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> Cc: Mimi Zohar <zohar@linux.ibm.com>
> Cc: David Howells <dhowells@redhat.com>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
It should check for chip in each function that uses TPM now that
the code does not rely on default chip. Otherwise, the semantics
are kind of inconsistent.
/Jarkko
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Roberto Sassu <roberto.sassu@huawei.com>,
James Bottomley <jejb@linux.ibm.com>,
Mimi Zohar <zohar@linux.ibm.com>,
David Howells <dhowells@redhat.com>,
keyrings@vger.kernel.org, linux-nvdimm@lists.01.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] security/keys/trusted: Allow operation without hardware TPM
Date: Thu, 21 Mar 2019 15:54:51 +0200 [thread overview]
Message-ID: <20190321135451.GD4603@linux.intel.com> (raw)
In-Reply-To: <155295271345.1945351.6465460744078693578.stgit@dwillia2-desk3.amr.corp.intel.com>
On Mon, Mar 18, 2019 at 04:45:13PM -0700, Dan Williams wrote:
> Rather than fail initialization of the trusted.ko module, arrange for
> the module to load, but rely on trusted_instantiate() to fail
> trusted-key operations.
>
> Fixes: 240730437deb ("KEYS: trusted: explicitly use tpm_chip structure...")
> Cc: Roberto Sassu <roberto.sassu@huawei.com>
> Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> Cc: James Bottomley <jejb@linux.ibm.com>
> Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> Cc: Mimi Zohar <zohar@linux.ibm.com>
> Cc: David Howells <dhowells@redhat.com>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
It should check for chip in each function that uses TPM now that
the code does not rely on default chip. Otherwise, the semantics
are kind of inconsistent.
/Jarkko
next prev parent reply other threads:[~2019-03-21 13:54 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-18 23:45 [PATCH] security/keys/trusted: Allow operation without hardware TPM Dan Williams
2019-03-18 23:45 ` Dan Williams
2019-03-18 23:45 ` Dan Williams
[not found] ` <155295271345.1945351.6465460744078693578.stgit-p8uTFz9XbKj2zm6wflaqv1nYeNYlB/vhral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2019-03-19 0:24 ` James Bottomley
2019-03-19 0:24 ` James Bottomley
2019-03-19 0:24 ` James Bottomley
2019-03-19 0:30 ` Dan Williams
2019-03-19 0:30 ` Dan Williams
2019-03-19 0:30 ` Dan Williams
[not found] ` <CAA9_cmcOD2zPaaNbkYAaH5DRDRAebPkW+hwPA0zPKY4kU8R-rg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-03-19 0:56 ` James Bottomley
2019-03-19 0:56 ` James Bottomley
2019-03-19 0:56 ` James Bottomley
2019-03-19 1:34 ` Dan Williams
2019-03-19 1:34 ` Dan Williams
2019-03-19 1:34 ` Dan Williams
2019-03-20 1:55 ` Dan Williams
2019-03-20 1:55 ` Dan Williams
2019-03-20 1:55 ` Dan Williams
[not found] ` <CAPcyv4hXKQcdLnKG6rPNOJr2wjq31uCCr+16S5Yu6S5A_5UGrA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-03-20 2:19 ` James Bottomley
2019-03-20 2:19 ` James Bottomley
2019-03-20 2:19 ` James Bottomley
2019-03-19 22:56 ` Mimi Zohar
2019-03-19 22:56 ` Mimi Zohar
2019-03-19 22:56 ` Mimi Zohar
2019-03-19 23:01 ` Dan Williams
2019-03-19 23:01 ` Dan Williams
2019-03-19 23:01 ` Dan Williams
2019-03-21 13:54 ` Jarkko Sakkinen [this message]
2019-03-21 13:54 ` Jarkko Sakkinen
2019-03-21 13:54 ` Jarkko Sakkinen
2019-03-21 14:26 ` Roberto Sassu
2019-03-21 14:26 ` Roberto Sassu
2019-03-21 14:26 ` Roberto Sassu
2019-03-21 16:30 ` Dan Williams
2019-03-21 16:30 ` Dan Williams
2019-03-21 16:30 ` Dan Williams
[not found] ` <CAPcyv4gc_KWedC12bTcX24KwjKiBCF=yvouRNzCbJKaLrgJdDg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-03-21 17:45 ` Roberto Sassu
2019-03-21 17:45 ` Roberto Sassu
2019-03-21 17:45 ` Roberto Sassu
2019-03-22 10:12 ` Jarkko Sakkinen
2019-03-22 10:12 ` Jarkko Sakkinen
2019-03-22 15:24 ` Dan Williams
2019-03-22 15:24 ` Dan Williams
2019-03-22 15:24 ` Dan Williams
2019-03-25 14:12 ` Jarkko Sakkinen
2019-03-25 14:12 ` Jarkko Sakkinen
2019-03-25 14:12 ` Jarkko Sakkinen
2019-03-25 14:50 ` Jarkko Sakkinen
2019-03-25 14:50 ` Jarkko Sakkinen
2019-03-25 14:50 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190321135451.GD4603@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=dan.j.williams@intel.com \
--cc=dhowells@redhat.com \
--cc=jejb@linux.ibm.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=roberto.sassu@huawei.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.