[PATCH 1/3] [Outreachy kernel] staging: sm750fb: avoid camelcase function names

[PATCH 1/3] [Outreachy kernel] staging: sm750fb: avoid camelcase function names

[Payal Kshirsagar]

Eliminate camelcase function names to fix the style issue – 'avoid
camelcase'.

Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
---
 drivers/staging/sm750fb/ddk750_mode.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/sm750fb/ddk750_mode.c b/drivers/staging/sm750fb/ddk750_mode.c
index 1256b13..5e35fec 100644
--- a/drivers/staging/sm750fb/ddk750_mode.c
+++ b/drivers/staging/sm750fb/ddk750_mode.c
@@ -13,8 +13,8 @@
  * HW only supports 7 predefined pixel clocks, and clock select is
  * in bit 29:27 of Display Control register.
  */
-static unsigned long displayControlAdjust_SM750LE(struct mode_parameter *pModeParam,
-						  unsigned long dispcontrol)
+static unsigned long display_control_adjust_SM750LE(struct mode_parameter *pModeParam,
+						    unsigned long dispcontrol)
 {
 	unsigned long x, y;
 
@@ -124,7 +124,7 @@ static int program_mode_registers(struct mode_parameter *pModeParam,
 			tmp |= DISPLAY_CTRL_HSYNC_PHASE;
 
 		if (sm750_get_chip_type() == SM750LE) {
-			displayControlAdjust_SM750LE(pModeParam, tmp);
+			display_control_adjust_SM750LE(pModeParam, tmp);
 		} else {
 			reg = peek32(CRT_DISPLAY_CTRL) &
 				~(DISPLAY_CTRL_VSYNC_PHASE |
-- 
2.7.4

Re: [PATCH 1/3] [Outreachy kernel] staging: sm750fb: avoid camelcase function names

[Greg KH]

On Thu, Mar 21, 2019 at 04:34:09PM +0530, Payal Kshirsagar wrote:
> Eliminate camelcase function names to fix the style issue – 'avoid
> camelcase'.
> 
> Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
> ---
>  drivers/staging/sm750fb/ddk750_mode.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/sm750fb/ddk750_mode.c b/drivers/staging/sm750fb/ddk750_mode.c
> index 1256b13..5e35fec 100644
> --- a/drivers/staging/sm750fb/ddk750_mode.c
> +++ b/drivers/staging/sm750fb/ddk750_mode.c
> @@ -13,8 +13,8 @@
>   * HW only supports 7 predefined pixel clocks, and clock select is
>   * in bit 29:27 of Display Control register.
>   */
> -static unsigned long displayControlAdjust_SM750LE(struct mode_parameter *pModeParam,
> -						  unsigned long dispcontrol)
> +static unsigned long display_control_adjust_SM750LE(struct mode_parameter *pModeParam,
> +						    unsigned long dispcontrol)
>  {
>  	unsigned long x, y;
>  
> @@ -124,7 +124,7 @@ static int program_mode_registers(struct mode_parameter *pModeParam,
>  			tmp |= DISPLAY_CTRL_HSYNC_PHASE;
>  
>  		if (sm750_get_chip_type() == SM750LE) {
> -			displayControlAdjust_SM750LE(pModeParam, tmp);
> +			display_control_adjust_SM750LE(pModeParam, tmp);
>  		} else {
>  			reg = peek32(CRT_DISPLAY_CTRL) &
>  				~(DISPLAY_CTRL_VSYNC_PHASE |

This patch does not apply to my tree at all :(

Please rebase and resend it.

thanks,

greg k-h