* [PATCH 1/2] ARM: dts: ls1021a: Remove unused properties from QSPI node
@ 2019-03-20 14:38 ` Schrempf Frieder
0 siblings, 0 replies; 8+ messages in thread
From: Schrempf Frieder @ 2019-03-20 14:38 UTC (permalink / raw)
To: Shawn Guo, Li Yang, Rob Herring, Mark Rutland
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Schrempf Frieder, linux-kernel@vger.kernel.org
From: Frieder Schrempf <frieder.schrempf@kontron.de>
After switching to the new FSL QSPI driver the properties
'fsl,qspi-has-second-chip' and 'big-endian' are not used anymore.
The driver now uses the 'reg' property to determine the bus and
the chipselect. The endianness is selected by the driver depending
on which SoC is used.
Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
---
arch/arm/boot/dts/ls1021a-moxa-uc-8410a.dts | 1 -
arch/arm/boot/dts/ls1021a.dtsi | 1 -
2 files changed, 2 deletions(-)
diff --git a/arch/arm/boot/dts/ls1021a-moxa-uc-8410a.dts b/arch/arm/boot/dts/ls1021a-moxa-uc-8410a.dts
index ba1ddd93b8f8..dcb1d9bd0922 100644
--- a/arch/arm/boot/dts/ls1021a-moxa-uc-8410a.dts
+++ b/arch/arm/boot/dts/ls1021a-moxa-uc-8410a.dts
@@ -204,7 +204,6 @@
};
&qspi {
- fsl,qspi-has-second-chip;
status = "okay";
flash: flash@0 {
diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi
index b4f2723ecd86..2bcc00de88d4 100644
--- a/arch/arm/boot/dts/ls1021a.dtsi
+++ b/arch/arm/boot/dts/ls1021a.dtsi
@@ -186,7 +186,6 @@
interrupts = <GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH>;
clock-names = "qspi_en", "qspi";
clocks = <&clockgen 4 1>, <&clockgen 4 1>;
- big-endian;
status = "disabled";
};
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 1/2] ARM: dts: ls1021a: Remove unused properties from QSPI node
@ 2019-03-20 14:38 ` Schrempf Frieder
0 siblings, 0 replies; 8+ messages in thread
From: Schrempf Frieder @ 2019-03-20 14:38 UTC (permalink / raw)
To: Shawn Guo, Li Yang, Rob Herring, Mark Rutland
Cc: Schrempf Frieder, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
From: Frieder Schrempf <frieder.schrempf@kontron.de>
After switching to the new FSL QSPI driver the properties
'fsl,qspi-has-second-chip' and 'big-endian' are not used anymore.
The driver now uses the 'reg' property to determine the bus and
the chipselect. The endianness is selected by the driver depending
on which SoC is used.
Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
---
arch/arm/boot/dts/ls1021a-moxa-uc-8410a.dts | 1 -
arch/arm/boot/dts/ls1021a.dtsi | 1 -
2 files changed, 2 deletions(-)
diff --git a/arch/arm/boot/dts/ls1021a-moxa-uc-8410a.dts b/arch/arm/boot/dts/ls1021a-moxa-uc-8410a.dts
index ba1ddd93b8f8..dcb1d9bd0922 100644
--- a/arch/arm/boot/dts/ls1021a-moxa-uc-8410a.dts
+++ b/arch/arm/boot/dts/ls1021a-moxa-uc-8410a.dts
@@ -204,7 +204,6 @@
};
&qspi {
- fsl,qspi-has-second-chip;
status = "okay";
flash: flash@0 {
diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi
index b4f2723ecd86..2bcc00de88d4 100644
--- a/arch/arm/boot/dts/ls1021a.dtsi
+++ b/arch/arm/boot/dts/ls1021a.dtsi
@@ -186,7 +186,6 @@
interrupts = <GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH>;
clock-names = "qspi_en", "qspi";
clocks = <&clockgen 4 1>, <&clockgen 4 1>;
- big-endian;
status = "disabled";
};
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/2] ARM64: dts: Remove unused properties from FSL QSPI nodes
2019-03-20 14:38 ` Schrempf Frieder
@ 2019-03-20 14:38 ` Schrempf Frieder
-1 siblings, 0 replies; 8+ messages in thread
From: Schrempf Frieder @ 2019-03-20 14:38 UTC (permalink / raw)
To: Shawn Guo, Li Yang
Cc: Mark Rutland, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Schrempf Frieder, Rob Herring,
linux-arm-kernel@lists.infradead.org
From: Frieder Schrempf <frieder.schrempf@kontron.de>
After switching to the new FSL QSPI driver the properties
'fsl,qspi-has-second-chip' and 'big-endian' are not used anymore.
The driver now uses the 'reg' property to determine the bus and
the chipselect. The endianness is selected by the driver depending
on which SoC is used.
Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
---
arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 1 -
arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 2 --
2 files changed, 3 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
index 6fd6116509cc..2fb8138c6bb0 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
@@ -296,7 +296,6 @@
interrupts = <0 99 0x4>;
clock-names = "qspi_en", "qspi";
clocks = <&clockgen 4 0>, <&clockgen 4 0>;
- big-endian;
status = "disabled";
};
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
index cb7185014d3a..b0ef08b090dd 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
@@ -215,8 +215,6 @@
interrupts = <GIC_SPI 99 IRQ_TYPE_LEVEL_HIGH>;
clock-names = "qspi_en", "qspi";
clocks = <&clockgen 4 1>, <&clockgen 4 1>;
- big-endian;
- fsl,qspi-has-second-chip;
status = "disabled";
};
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/2] ARM64: dts: Remove unused properties from FSL QSPI nodes
@ 2019-03-20 14:38 ` Schrempf Frieder
0 siblings, 0 replies; 8+ messages in thread
From: Schrempf Frieder @ 2019-03-20 14:38 UTC (permalink / raw)
To: Shawn Guo, Li Yang
Cc: Schrempf Frieder, Rob Herring, Mark Rutland,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
From: Frieder Schrempf <frieder.schrempf@kontron.de>
After switching to the new FSL QSPI driver the properties
'fsl,qspi-has-second-chip' and 'big-endian' are not used anymore.
The driver now uses the 'reg' property to determine the bus and
the chipselect. The endianness is selected by the driver depending
on which SoC is used.
Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
---
arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 1 -
arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 2 --
2 files changed, 3 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
index 6fd6116509cc..2fb8138c6bb0 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
@@ -296,7 +296,6 @@
interrupts = <0 99 0x4>;
clock-names = "qspi_en", "qspi";
clocks = <&clockgen 4 0>, <&clockgen 4 0>;
- big-endian;
status = "disabled";
};
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
index cb7185014d3a..b0ef08b090dd 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
@@ -215,8 +215,6 @@
interrupts = <GIC_SPI 99 IRQ_TYPE_LEVEL_HIGH>;
clock-names = "qspi_en", "qspi";
clocks = <&clockgen 4 1>, <&clockgen 4 1>;
- big-endian;
- fsl,qspi-has-second-chip;
status = "disabled";
};
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] ARM: dts: ls1021a: Remove unused properties from QSPI node
2019-03-20 14:38 ` Schrempf Frieder
@ 2019-03-22 2:21 ` Shawn Guo
-1 siblings, 0 replies; 8+ messages in thread
From: Shawn Guo @ 2019-03-22 2:21 UTC (permalink / raw)
To: Schrempf Frieder
Cc: Mark Rutland, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Li Yang, Rob Herring,
linux-arm-kernel@lists.infradead.org
On Wed, Mar 20, 2019 at 02:38:02PM +0000, Schrempf Frieder wrote:
> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>
> After switching to the new FSL QSPI driver the properties
> 'fsl,qspi-has-second-chip' and 'big-endian' are not used anymore.
>
> The driver now uses the 'reg' property to determine the bus and
> the chipselect. The endianness is selected by the driver depending
> on which SoC is used.
>
> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
Applied both, thanks.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] ARM: dts: ls1021a: Remove unused properties from QSPI node
@ 2019-03-22 2:21 ` Shawn Guo
0 siblings, 0 replies; 8+ messages in thread
From: Shawn Guo @ 2019-03-22 2:21 UTC (permalink / raw)
To: Schrempf Frieder
Cc: Li Yang, Rob Herring, Mark Rutland, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
On Wed, Mar 20, 2019 at 02:38:02PM +0000, Schrempf Frieder wrote:
> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>
> After switching to the new FSL QSPI driver the properties
> 'fsl,qspi-has-second-chip' and 'big-endian' are not used anymore.
>
> The driver now uses the 'reg' property to determine the bus and
> the chipselect. The endianness is selected by the driver depending
> on which SoC is used.
>
> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
Applied both, thanks.
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH 2/2] ARM64: dts: Remove unused properties from FSL QSPI nodes
2019-03-20 14:38 ` Schrempf Frieder
@ 2019-08-09 6:18 ` Pankaj Bansal
-1 siblings, 0 replies; 8+ messages in thread
From: Pankaj Bansal @ 2019-08-09 6:18 UTC (permalink / raw)
To: Schrempf Frieder, Shawn Guo, Leo Li
Cc: Mark Rutland, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Ashish Kumar, Rob Herring,
Meenakshi Aggarwal, Varun Sethi,
linux-arm-kernel@lists.infradead.org
Hi Shawn/Leo,
Removing the "big-endian" property has caused problems in our UEFI firmware.
In UEFI, we use the device tree to detect and use the qspi controller and flashes attached to it.
We don't maintain a list of platforms like linux driver.
Can you please revert the endianness change from linux mainline ?
Regards,
Pankaj Bansal
> -----Original Message-----
> From: devicetree-owner@vger.kernel.org <devicetree-owner@vger.kernel.org>
> On Behalf Of Schrempf Frieder
> Sent: Wednesday, 20 March, 2019 08:08 PM
> To: Shawn Guo <shawnguo@kernel.org>; Leo Li <leoyang.li@nxp.com>
> Cc: Schrempf Frieder <frieder.schrempf@kontron.de>; Rob Herring
> <robh+dt@kernel.org>; Mark Rutland <mark.rutland@arm.com>; linux-arm-
> kernel@lists.infradead.org; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: [PATCH 2/2] ARM64: dts: Remove unused properties from FSL QSPI
> nodes
>
> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>
> After switching to the new FSL QSPI driver the properties 'fsl,qspi-has-second-
> chip' and 'big-endian' are not used anymore.
>
> The driver now uses the 'reg' property to determine the bus and the chipselect.
> The endianness is selected by the driver depending on which SoC is used.
>
> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
> ---
> arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 1 -
> arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 2 --
> 2 files changed, 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> index 6fd6116509cc..2fb8138c6bb0 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> @@ -296,7 +296,6 @@
> interrupts = <0 99 0x4>;
> clock-names = "qspi_en", "qspi";
> clocks = <&clockgen 4 0>, <&clockgen 4 0>;
> - big-endian;
> status = "disabled";
> };
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> index cb7185014d3a..b0ef08b090dd 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> @@ -215,8 +215,6 @@
> interrupts = <GIC_SPI 99 IRQ_TYPE_LEVEL_HIGH>;
> clock-names = "qspi_en", "qspi";
> clocks = <&clockgen 4 1>, <&clockgen 4 1>;
> - big-endian;
> - fsl,qspi-has-second-chip;
> status = "disabled";
> };
>
> --
> 2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH 2/2] ARM64: dts: Remove unused properties from FSL QSPI nodes
@ 2019-08-09 6:18 ` Pankaj Bansal
0 siblings, 0 replies; 8+ messages in thread
From: Pankaj Bansal @ 2019-08-09 6:18 UTC (permalink / raw)
To: Schrempf Frieder, Shawn Guo, Leo Li
Cc: Rob Herring, Mark Rutland, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Meenakshi Aggarwal, Varun Sethi, Ashish Kumar
Hi Shawn/Leo,
Removing the "big-endian" property has caused problems in our UEFI firmware.
In UEFI, we use the device tree to detect and use the qspi controller and flashes attached to it.
We don't maintain a list of platforms like linux driver.
Can you please revert the endianness change from linux mainline ?
Regards,
Pankaj Bansal
> -----Original Message-----
> From: devicetree-owner@vger.kernel.org <devicetree-owner@vger.kernel.org>
> On Behalf Of Schrempf Frieder
> Sent: Wednesday, 20 March, 2019 08:08 PM
> To: Shawn Guo <shawnguo@kernel.org>; Leo Li <leoyang.li@nxp.com>
> Cc: Schrempf Frieder <frieder.schrempf@kontron.de>; Rob Herring
> <robh+dt@kernel.org>; Mark Rutland <mark.rutland@arm.com>; linux-arm-
> kernel@lists.infradead.org; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: [PATCH 2/2] ARM64: dts: Remove unused properties from FSL QSPI
> nodes
>
> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>
> After switching to the new FSL QSPI driver the properties 'fsl,qspi-has-second-
> chip' and 'big-endian' are not used anymore.
>
> The driver now uses the 'reg' property to determine the bus and the chipselect.
> The endianness is selected by the driver depending on which SoC is used.
>
> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
> ---
> arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 1 -
> arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 2 --
> 2 files changed, 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> index 6fd6116509cc..2fb8138c6bb0 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> @@ -296,7 +296,6 @@
> interrupts = <0 99 0x4>;
> clock-names = "qspi_en", "qspi";
> clocks = <&clockgen 4 0>, <&clockgen 4 0>;
> - big-endian;
> status = "disabled";
> };
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> index cb7185014d3a..b0ef08b090dd 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> @@ -215,8 +215,6 @@
> interrupts = <GIC_SPI 99 IRQ_TYPE_LEVEL_HIGH>;
> clock-names = "qspi_en", "qspi";
> clocks = <&clockgen 4 1>, <&clockgen 4 1>;
> - big-endian;
> - fsl,qspi-has-second-chip;
> status = "disabled";
> };
>
> --
> 2.17.1
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-08-09 6:18 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-20 14:38 [PATCH 1/2] ARM: dts: ls1021a: Remove unused properties from QSPI node Schrempf Frieder
2019-03-20 14:38 ` Schrempf Frieder
2019-03-20 14:38 ` [PATCH 2/2] ARM64: dts: Remove unused properties from FSL QSPI nodes Schrempf Frieder
2019-03-20 14:38 ` Schrempf Frieder
2019-08-09 6:18 ` Pankaj Bansal
2019-08-09 6:18 ` Pankaj Bansal
2019-03-22 2:21 ` [PATCH 1/2] ARM: dts: ls1021a: Remove unused properties from QSPI node Shawn Guo
2019-03-22 2:21 ` Shawn Guo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.