From: Tony Lindgren <tony@atomide.com>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: linux-omap@vger.kernel.org, kernel-janitors@vger.kernel.org,
Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 11/12] ARM: OMAP2+: add missing of_node_put after of_device_is_available
Date: Fri, 22 Mar 2019 22:24:54 +0000 [thread overview]
Message-ID: <20190322222454.GJ19425@atomide.com> (raw)
In-Reply-To: <1550928043-14889-12-git-send-email-Julia.Lawall@lip6.fr>
* Julia Lawall <Julia.Lawall@lip6.fr> [190223 13:58]:
> Add an of_node_put when a tested device node is not available.
>
> The semantic patch that fixes this problem is as follows
> (http://coccinelle.lip6.fr):
>
> // <smpl>
> @@
> identifier f;
> local idexpression e;
> expression x;
> @@
>
> e = f(...);
> ... when != of_node_put(e)
> when != x = e
> when != e = x
> when any
> if (<+...of_device_is_available(e)...+>) {
> ... when != of_node_put(e)
> (
> return e;
> |
> + of_node_put(e);
> return ...;
> )
> }
> // </smpl>
>
> Fixes: e0c827aca0730 ("drm/omap: Populate DSS children in omapdss driver")
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Thanks applying this one into omap-for-v5.1/fixes.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: linux-omap@vger.kernel.org, kernel-janitors@vger.kernel.org,
Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 11/12] ARM: OMAP2+: add missing of_node_put after of_device_is_available
Date: Fri, 22 Mar 2019 15:24:54 -0700 [thread overview]
Message-ID: <20190322222454.GJ19425@atomide.com> (raw)
In-Reply-To: <1550928043-14889-12-git-send-email-Julia.Lawall@lip6.fr>
* Julia Lawall <Julia.Lawall@lip6.fr> [190223 13:58]:
> Add an of_node_put when a tested device node is not available.
>
> The semantic patch that fixes this problem is as follows
> (http://coccinelle.lip6.fr):
>
> // <smpl>
> @@
> identifier f;
> local idexpression e;
> expression x;
> @@
>
> e = f(...);
> ... when != of_node_put(e)
> when != x = e
> when != e = x
> when any
> if (<+...of_device_is_available(e)...+>) {
> ... when != of_node_put(e)
> (
> return e;
> |
> + of_node_put(e);
> return ...;
> )
> }
> // </smpl>
>
> Fixes: e0c827aca0730 ("drm/omap: Populate DSS children in omapdss driver")
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Thanks applying this one into omap-for-v5.1/fixes.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: linux-omap@vger.kernel.org, kernel-janitors@vger.kernel.org,
Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 11/12] ARM: OMAP2+: add missing of_node_put after of_device_is_available
Date: Fri, 22 Mar 2019 15:24:54 -0700 [thread overview]
Message-ID: <20190322222454.GJ19425@atomide.com> (raw)
In-Reply-To: <1550928043-14889-12-git-send-email-Julia.Lawall@lip6.fr>
* Julia Lawall <Julia.Lawall@lip6.fr> [190223 13:58]:
> Add an of_node_put when a tested device node is not available.
>
> The semantic patch that fixes this problem is as follows
> (http://coccinelle.lip6.fr):
>
> // <smpl>
> @@
> identifier f;
> local idexpression e;
> expression x;
> @@
>
> e = f(...);
> ... when != of_node_put(e)
> when != x = e
> when != e = x
> when any
> if (<+...of_device_is_available(e)...+>) {
> ... when != of_node_put(e)
> (
> return e;
> |
> + of_node_put(e);
> return ...;
> )
> }
> // </smpl>
>
> Fixes: e0c827aca0730 ("drm/omap: Populate DSS children in omapdss driver")
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Thanks applying this one into omap-for-v5.1/fixes.
Regards,
Tony
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: kernel-janitors@vger.kernel.org,
Russell King <linux@armlinux.org.uk>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 11/12] ARM: OMAP2+: add missing of_node_put after of_device_is_available
Date: Fri, 22 Mar 2019 15:24:54 -0700 [thread overview]
Message-ID: <20190322222454.GJ19425@atomide.com> (raw)
In-Reply-To: <1550928043-14889-12-git-send-email-Julia.Lawall@lip6.fr>
* Julia Lawall <Julia.Lawall@lip6.fr> [190223 13:58]:
> Add an of_node_put when a tested device node is not available.
>
> The semantic patch that fixes this problem is as follows
> (http://coccinelle.lip6.fr):
>
> // <smpl>
> @@
> identifier f;
> local idexpression e;
> expression x;
> @@
>
> e = f(...);
> ... when != of_node_put(e)
> when != x = e
> when != e = x
> when any
> if (<+...of_device_is_available(e)...+>) {
> ... when != of_node_put(e)
> (
> return e;
> |
> + of_node_put(e);
> return ...;
> )
> }
> // </smpl>
>
> Fixes: e0c827aca0730 ("drm/omap: Populate DSS children in omapdss driver")
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Thanks applying this one into omap-for-v5.1/fixes.
Regards,
Tony
next prev parent reply other threads:[~2019-03-22 22:24 UTC|newest]
Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-23 13:20 [PATCH 00/12] add missing of_node_put after of_device_is_available Julia Lawall
2019-02-23 13:20 ` Julia Lawall
2019-02-23 13:20 ` Julia Lawall
2019-02-23 13:20 ` Julia Lawall
2019-02-23 13:20 ` Julia Lawall
2019-02-23 13:20 ` [PATCH 01/12] arm-cci: " Julia Lawall
2019-02-23 13:20 ` Julia Lawall
2019-04-01 12:48 ` Mukesh Ojha
2019-04-01 12:48 ` Mukesh Ojha
2019-04-14 14:45 ` Markus Elfring
2019-04-14 14:45 ` Markus Elfring
2019-04-16 13:02 ` Robin Murphy
2019-04-16 13:02 ` Robin Murphy
2019-02-23 13:20 ` [PATCH 02/12] drm/tegra: rgb: " Julia Lawall
2019-02-23 13:20 ` Julia Lawall
2019-04-01 12:49 ` Mukesh Ojha
2019-04-01 12:49 ` Mukesh Ojha
2019-04-14 15:01 ` Markus Elfring
2019-04-14 15:01 ` Markus Elfring
2019-02-23 13:20 ` [PATCH 03/12] PowerPC-83xx: " Julia Lawall
2019-02-23 13:20 ` Julia Lawall
2019-02-23 13:20 ` Julia Lawall
2019-04-01 12:49 ` Mukesh Ojha
2019-04-01 12:50 ` Mukesh Ojha
2019-04-01 12:49 ` Mukesh Ojha
2019-04-14 15:25 ` Markus Elfring
2019-04-14 15:25 ` Markus Elfring
2019-04-14 15:25 ` Markus Elfring
2019-02-23 13:20 ` [PATCH 04/12] phy: tegra: " Julia Lawall
2019-02-23 13:20 ` Julia Lawall
2019-04-01 12:50 ` Mukesh Ojha
2019-04-01 12:50 ` Mukesh Ojha
2019-04-14 15:42 ` Markus Elfring
2019-04-14 15:42 ` Markus Elfring
2019-02-23 13:20 ` [PATCH 05/12] tee: optee: " Julia Lawall
2019-02-23 13:20 ` Julia Lawall
2019-02-28 11:17 ` Jens Wiklander
2019-02-28 11:17 ` Jens Wiklander
2019-02-23 13:20 ` [PATCH 06/12] omapfb: " Julia Lawall
2019-02-23 13:20 ` Julia Lawall
2019-04-01 12:07 ` Bartlomiej Zolnierkiewicz
2019-04-01 12:07 ` Bartlomiej Zolnierkiewicz
2019-02-23 13:20 ` [PATCH 07/12] drm: omapdrm: " Julia Lawall
2019-02-23 13:20 ` Julia Lawall
2019-04-01 12:58 ` Mukesh Ojha
2019-04-01 12:58 ` Mukesh Ojha
2019-02-23 13:20 ` [PATCH 08/12] crypto: " Julia Lawall
2019-02-23 13:20 ` Julia Lawall
2019-02-28 6:39 ` Herbert Xu
2019-02-28 6:39 ` Herbert Xu
2019-02-23 13:20 ` [PATCH 09/12] meson-gx-socinfo: " Julia Lawall
2019-02-23 13:20 ` Julia Lawall
2019-02-23 13:20 ` Julia Lawall
2019-02-23 13:20 ` Julia Lawall
2019-03-12 20:28 ` Kevin Hilman
2019-03-12 20:28 ` Kevin Hilman
2019-03-12 20:28 ` Kevin Hilman
2019-03-12 20:28 ` Kevin Hilman
2019-04-14 16:12 ` Markus Elfring
2019-04-14 16:12 ` Markus Elfring
2019-04-14 16:12 ` Markus Elfring
2019-04-14 16:12 ` Markus Elfring
2019-02-23 13:20 ` [PATCH 10/12] cpufreq: ap806: " Julia Lawall
2019-02-23 13:20 ` Julia Lawall
2019-02-23 13:20 ` Julia Lawall
2019-02-23 13:20 ` Julia Lawall
2019-02-25 4:29 ` Viresh Kumar
2019-02-25 4:41 ` Viresh Kumar
2019-02-25 4:29 ` Viresh Kumar
2019-02-23 13:20 ` [PATCH 11/12] ARM: OMAP2+: " Julia Lawall
2019-02-23 13:20 ` Julia Lawall
2019-02-23 13:20 ` Julia Lawall
2019-03-22 22:24 ` Tony Lindgren [this message]
2019-03-22 22:24 ` Tony Lindgren
2019-03-22 22:24 ` Tony Lindgren
2019-03-22 22:24 ` Tony Lindgren
2019-04-14 16:38 ` [11/12] " Markus Elfring
2019-04-14 16:38 ` Markus Elfring
2019-04-14 16:38 ` Markus Elfring
2019-04-14 16:49 ` Julia Lawall
2019-04-14 16:49 ` Julia Lawall
2019-04-14 16:49 ` Julia Lawall
2019-02-23 13:20 ` [PATCH 12/12] drivers: firmware: psci: " Julia Lawall
2019-02-23 13:20 ` Julia Lawall
2019-02-23 13:20 ` Julia Lawall
2019-04-01 12:47 ` Mukesh Ojha
2019-04-01 12:59 ` Mukesh Ojha
2019-04-01 12:47 ` Mukesh Ojha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190322222454.GJ19425@atomide.com \
--to=tony@atomide.com \
--cc=Julia.Lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.