From: Greg KH <gregkh@linuxfoundation.org>
To: Sanjana Sanikommu <sanjana99reddy99@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [PATCH v2] staging: greybus: svc_watchdog: Modify char* array declaration.
Date: Sun, 24 Mar 2019 09:59:23 +0100 [thread overview]
Message-ID: <20190324085923.GA32103@kroah.com> (raw)
In-Reply-To: <20190323112807.9804-1-sanjana99reddy99@gmail.com>
On Sat, Mar 23, 2019 at 04:58:07PM +0530, Sanjana Sanikommu wrote:
> Modify "static char* array" to "static char* const array".
> Issue found using checkpatch.pl
>
> WARNING:char* array declaration might be better as static constant
>
> Signed-off-by: Sanjana Sanikommu <sanjana99reddy99@gmail.com>
> ---
> Changes in v2:
> Test build the patch
No you did not :(
It blows up the build into tiny pieces. Please properly test build your
patches before sending them in.
greg k-h
next prev parent reply other threads:[~2019-03-24 8:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-23 11:28 [PATCH v2] staging: greybus: svc_watchdog: Modify char* array declaration Sanjana Sanikommu
2019-03-24 8:59 ` Greg KH [this message]
2019-03-24 9:05 ` [Outreachy kernel] " Julia Lawall
2019-03-24 9:22 ` sanjana99reddy99
2019-03-24 17:24 ` sanjana99reddy99
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190324085923.GA32103@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=sanjana99reddy99@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.