* [PATCH v2] staging: greybus: svc_watchdog: Modify char* array declaration.
@ 2019-03-23 11:28 Sanjana Sanikommu
2019-03-24 8:59 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: Sanjana Sanikommu @ 2019-03-23 11:28 UTC (permalink / raw)
To: gregkh; +Cc: outreachy-kernel
Modify "static char* array" to "static char* const array".
Issue found using checkpatch.pl
WARNING:char* array declaration might be better as static constant
Signed-off-by: Sanjana Sanikommu <sanjana99reddy99@gmail.com>
---
Changes in v2:
Test build the patch
drivers/staging/greybus/svc_watchdog.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/greybus/svc_watchdog.c b/drivers/staging/greybus/svc_watchdog.c
index 7868ad8211c5..b6aaabcec320 100644
--- a/drivers/staging/greybus/svc_watchdog.c
+++ b/drivers/staging/greybus/svc_watchdog.c
@@ -44,12 +44,12 @@ static int svc_watchdog_pm_notifier(struct notifier_block *notifier,
static void greybus_reset(struct work_struct *work)
{
static char const start_path[] = "/system/bin/start";
- static char *envp[] = {
+ static char const *envp[] = {
"HOME=/",
"PATH=/sbin:/vendor/bin:/system/sbin:/system/bin:/system/xbin",
NULL,
};
- static char *argv[] = {
+ static char const *argv[] = {
(char *)start_path,
"unipro_reset",
NULL,
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] staging: greybus: svc_watchdog: Modify char* array declaration.
2019-03-23 11:28 [PATCH v2] staging: greybus: svc_watchdog: Modify char* array declaration Sanjana Sanikommu
@ 2019-03-24 8:59 ` Greg KH
2019-03-24 9:05 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 5+ messages in thread
From: Greg KH @ 2019-03-24 8:59 UTC (permalink / raw)
To: Sanjana Sanikommu; +Cc: outreachy-kernel
On Sat, Mar 23, 2019 at 04:58:07PM +0530, Sanjana Sanikommu wrote:
> Modify "static char* array" to "static char* const array".
> Issue found using checkpatch.pl
>
> WARNING:char* array declaration might be better as static constant
>
> Signed-off-by: Sanjana Sanikommu <sanjana99reddy99@gmail.com>
> ---
> Changes in v2:
> Test build the patch
No you did not :(
It blows up the build into tiny pieces. Please properly test build your
patches before sending them in.
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Outreachy kernel] Re: [PATCH v2] staging: greybus: svc_watchdog: Modify char* array declaration.
2019-03-24 8:59 ` Greg KH
@ 2019-03-24 9:05 ` Julia Lawall
2019-03-24 9:22 ` sanjana99reddy99
0 siblings, 1 reply; 5+ messages in thread
From: Julia Lawall @ 2019-03-24 9:05 UTC (permalink / raw)
To: Greg KH; +Cc: Sanjana Sanikommu, outreachy-kernel
On Sun, 24 Mar 2019, Greg KH wrote:
> On Sat, Mar 23, 2019 at 04:58:07PM +0530, Sanjana Sanikommu wrote:
> > Modify "static char* array" to "static char* const array".
> > Issue found using checkpatch.pl
> >
> > WARNING:char* array declaration might be better as static constant
> >
> > Signed-off-by: Sanjana Sanikommu <sanjana99reddy99@gmail.com>
> > ---
> > Changes in v2:
> > Test build the patch
>
> No you did not :(
>
> It blows up the build into tiny pieces. Please properly test build your
> patches before sending them in.
Sarjana,
Try make allyesconfig to make it more likely to have a configuration that
will actually cause compiling the driver.
julia
>
> greg k-h
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190324085923.GA32103%40kroah.com.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Outreachy kernel] Re: [PATCH v2] staging: greybus: svc_watchdog: Modify char* array declaration.
2019-03-24 9:05 ` [Outreachy kernel] " Julia Lawall
@ 2019-03-24 9:22 ` sanjana99reddy99
2019-03-24 17:24 ` sanjana99reddy99
0 siblings, 1 reply; 5+ messages in thread
From: sanjana99reddy99 @ 2019-03-24 9:22 UTC (permalink / raw)
To: outreachy-kernel
[-- Attachment #1.1: Type: text/plain, Size: 1458 bytes --]
On Sunday, March 24, 2019 at 2:35:46 PM UTC+5:30, Julia Lawall wrote:
>
>
>
> On Sun, 24 Mar 2019, Greg KH wrote:
>
> > On Sat, Mar 23, 2019 at 04:58:07PM +0530, Sanjana Sanikommu wrote:
> > > Modify "static char* array" to "static char* const array".
> > > Issue found using checkpatch.pl
> > >
> > > WARNING:char* array declaration might be better as static constant
> > >
> > > Signed-off-by: Sanjana Sanikommu <sanjana9...@gmail.com <javascript:>>
>
> > > ---
> > > Changes in v2:
> > > Test build the patch
> >
> > No you did not :(
> >
> > It blows up the build into tiny pieces. Please properly test build your
> > patches before sending them in.
>
> Sarjana,
>
> Try make allyesconfig to make it more likely to have a configuration that
> will actually cause compiling the driver.
>
I would do that :)
thank you
Sanjana
>
> julia
>
> >
> > greg k-h
> >
> > --
> > You received this message because you are subscribed to the Google
> Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send
> an email to outreachy-kern...@googlegroups.com <javascript:>.
> > To post to this group, send email to outreach...@googlegroups.com
> <javascript:>.
> > To view this discussion on the web visit
> https://groups.google.com/d/msgid/outreachy-kernel/20190324085923.GA32103%40kroah.com.
>
> > For more options, visit https://groups.google.com/d/optout.
> >
>
[-- Attachment #1.2: Type: text/html, Size: 3650 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Outreachy kernel] Re: [PATCH v2] staging: greybus: svc_watchdog: Modify char* array declaration.
2019-03-24 9:22 ` sanjana99reddy99
@ 2019-03-24 17:24 ` sanjana99reddy99
0 siblings, 0 replies; 5+ messages in thread
From: sanjana99reddy99 @ 2019-03-24 17:24 UTC (permalink / raw)
To: outreachy-kernel
[-- Attachment #1.1: Type: text/plain, Size: 1811 bytes --]
On Sunday, March 24, 2019 at 2:52:51 PM UTC+5:30, sanjana9...@gmail.com
wrote:
>
>
>
> On Sunday, March 24, 2019 at 2:35:46 PM UTC+5:30, Julia Lawall wrote:
>>
>>
>>
>> On Sun, 24 Mar 2019, Greg KH wrote:
>>
>> > On Sat, Mar 23, 2019 at 04:58:07PM +0530, Sanjana Sanikommu wrote:
>> > > Modify "static char* array" to "static char* const array".
>> > > Issue found using checkpatch.pl
>> > >
>> > > WARNING:char* array declaration might be better as static constant
>> > >
>> > > Signed-off-by: Sanjana Sanikommu <sanjana9...@gmail.com>
>> > > ---
>> > > Changes in v2:
>> > > Test build the patch
>> >
>> > No you did not :(
>> >
>> > It blows up the build into tiny pieces. Please properly test build
>> your
>> > patches before sending them in.
>>
>> Sarjana,
>>
>> Try make allyesconfig to make it more likely to have a configuration that
>> will actually cause compiling the driver.
>>
>
> I would do that :)
> thank you
>
Sorry, I was dumb I now understand why it went wrong
because the expected is ‘char **’ but argument is of type ‘const
char **’.
So it cant be changed.
> Sanjana
>
>>
>> julia
>>
>> >
>> > greg k-h
>> >
>> > --
>> > You received this message because you are subscribed to the Google
>> Groups "outreachy-kernel" group.
>> > To unsubscribe from this group and stop receiving emails from it, send
>> an email to outreachy-kern...@googlegroups.com.
>> > To post to this group, send email to outreach...@googlegroups.com.
>> > To view this discussion on the web visit
>> https://groups.google.com/d/msgid/outreachy-kernel/20190324085923.GA32103%40kroah.com.
>>
>> > For more options, visit https://groups.google.com/d/optout.
>> >
>>
>
[-- Attachment #1.2: Type: text/html, Size: 3715 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-03-24 17:24 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-23 11:28 [PATCH v2] staging: greybus: svc_watchdog: Modify char* array declaration Sanjana Sanikommu
2019-03-24 8:59 ` Greg KH
2019-03-24 9:05 ` [Outreachy kernel] " Julia Lawall
2019-03-24 9:22 ` sanjana99reddy99
2019-03-24 17:24 ` sanjana99reddy99
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.