From: Greg KH <gregkh@linuxfoundation.org>
To: Vatsala Narang <vatsalanarang@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [PATCH] staging: rtl8723bs: include: Replace 'int16_t' with 's16_t'
Date: Sun, 24 Mar 2019 10:01:01 +0100 [thread overview]
Message-ID: <20190324090101.GA32228@kroah.com> (raw)
In-Reply-To: <20190323105745.31401-1-vatsalanarang@gmail.com>
On Sat, Mar 23, 2019 at 04:27:45PM +0530, Vatsala Narang wrote:
> Prefer kernel type 's16_t' over 'int16_t' to get rid of checkpatch
> warning
What warning? What is "s16_t"? Ick, that's not a "real" kernel type at
all.
>
> Signed-off-by: Vatsala Narang <vatsalanarang@gmail.com>
> ---
> drivers/staging/rtl8723bs/include/wifi.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/include/wifi.h b/drivers/staging/rtl8723bs/include/wifi.h
> index e729ecd5e9ab..d3deb18d3267 100644
> --- a/drivers/staging/rtl8723bs/include/wifi.h
> +++ b/drivers/staging/rtl8723bs/include/wifi.h
> @@ -1142,7 +1142,7 @@ struct rtw_regulatory {
> u32 tp_scale;
> u16 current_rd;
> u16 current_rd_ext;
> - int16_t power_limit;
> + s16_t power_limit;
You might have just changed the type of this variable, are you _sure_
about this?
greg k-h
next prev parent reply other threads:[~2019-03-24 9:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-23 10:57 [PATCH] staging: rtl8723bs: include: Replace 'int16_t' with 's16_t' Vatsala Narang
2019-03-24 9:01 ` Greg KH [this message]
2019-03-24 18:56 ` Vatsala Narang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190324090101.GA32228@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=vatsalanarang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.