* [PATCH] staging: rtl8723bs: include: Replace 'int16_t' with 's16_t'
@ 2019-03-23 10:57 Vatsala Narang
2019-03-24 9:01 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Vatsala Narang @ 2019-03-23 10:57 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh, Vatsala Narang
Prefer kernel type 's16_t' over 'int16_t' to get rid of checkpatch
warning
Signed-off-by: Vatsala Narang <vatsalanarang@gmail.com>
---
drivers/staging/rtl8723bs/include/wifi.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/include/wifi.h b/drivers/staging/rtl8723bs/include/wifi.h
index e729ecd5e9ab..d3deb18d3267 100644
--- a/drivers/staging/rtl8723bs/include/wifi.h
+++ b/drivers/staging/rtl8723bs/include/wifi.h
@@ -1142,7 +1142,7 @@ struct rtw_regulatory {
u32 tp_scale;
u16 current_rd;
u16 current_rd_ext;
- int16_t power_limit;
+ s16_t power_limit;
struct regd_pair_mapping *regpair;
};
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: rtl8723bs: include: Replace 'int16_t' with 's16_t'
2019-03-23 10:57 [PATCH] staging: rtl8723bs: include: Replace 'int16_t' with 's16_t' Vatsala Narang
@ 2019-03-24 9:01 ` Greg KH
2019-03-24 18:56 ` Vatsala Narang
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2019-03-24 9:01 UTC (permalink / raw)
To: Vatsala Narang; +Cc: outreachy-kernel
On Sat, Mar 23, 2019 at 04:27:45PM +0530, Vatsala Narang wrote:
> Prefer kernel type 's16_t' over 'int16_t' to get rid of checkpatch
> warning
What warning? What is "s16_t"? Ick, that's not a "real" kernel type at
all.
>
> Signed-off-by: Vatsala Narang <vatsalanarang@gmail.com>
> ---
> drivers/staging/rtl8723bs/include/wifi.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/include/wifi.h b/drivers/staging/rtl8723bs/include/wifi.h
> index e729ecd5e9ab..d3deb18d3267 100644
> --- a/drivers/staging/rtl8723bs/include/wifi.h
> +++ b/drivers/staging/rtl8723bs/include/wifi.h
> @@ -1142,7 +1142,7 @@ struct rtw_regulatory {
> u32 tp_scale;
> u16 current_rd;
> u16 current_rd_ext;
> - int16_t power_limit;
> + s16_t power_limit;
You might have just changed the type of this variable, are you _sure_
about this?
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: rtl8723bs: include: Replace 'int16_t' with 's16_t'
2019-03-24 9:01 ` Greg KH
@ 2019-03-24 18:56 ` Vatsala Narang
0 siblings, 0 replies; 3+ messages in thread
From: Vatsala Narang @ 2019-03-24 18:56 UTC (permalink / raw)
To: outreachy-kernel
[-- Attachment #1.1: Type: text/plain, Size: 391 bytes --]
> What warning? What is "s16_t"? Ick, that's not a "real" kernel type at
> all.
>
>
> > - int16_t power_limit;
> > + s16_t power_limit;
>
> You might have just changed the type of this variable, are you _sure_
> about this?
>
> greg k-h
>
I replaced int16_t with s16_t as it was there in checkpatch warning
sorry if its not a "real" kernel type
thanks,
Vatsala
[-- Attachment #1.2: Type: text/html, Size: 816 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-24 18:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-23 10:57 [PATCH] staging: rtl8723bs: include: Replace 'int16_t' with 's16_t' Vatsala Narang
2019-03-24 9:01 ` Greg KH
2019-03-24 18:56 ` Vatsala Narang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.