[PATCH 2/6 v2] staging: rtl8712: avoid camelcase variable name 'backupPMKIDList'

[PATCH 2/6 v2] staging: rtl8712: avoid camelcase variable name 'backupPMKIDList'

[Payal Kshirsagar]

Eliminate camelcase variable names to fix the style issue – ‘avoid
camelcase’.

Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
---
Changes in v2:
	-backup_PMKID_List replaced with backup_PMKID_list
 drivers/staging/rtl8712/mlme_linux.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8712/mlme_linux.c b/drivers/staging/rtl8712/mlme_linux.c
index fbd04f5..12b8eaf 100644
--- a/drivers/staging/rtl8712/mlme_linux.c
+++ b/drivers/staging/rtl8712/mlme_linux.c
@@ -84,7 +84,7 @@ void r8712_os_indicate_connect(struct _adapter *adapter)
 	netif_carrier_on(adapter->pnetdev);
 }
 
-static struct RT_PMKID_LIST   backup_PMKID_List[NUM_PMKID_CACHE];
+static struct RT_PMKID_LIST   backup_PMKID_list[NUM_PMKID_CACHE];
 void r8712_os_indicate_disconnect(struct _adapter *adapter)
 {
 	u8 backupPMKIDIndex = 0;
@@ -99,7 +99,7 @@ void r8712_os_indicate_disconnect(struct _adapter *adapter)
 		 * disconnect with AP for 60 seconds.
 		 */
 
-		memcpy(&backup_PMKID_List[0],
+		memcpy(&backup_PMKID_list[0],
 		       &adapter->securitypriv.PMKIDList[0],
 		       sizeof(struct RT_PMKID_LIST) * NUM_PMKID_CACHE);
 		backupPMKIDIndex = adapter->securitypriv.PMKIDIndex;
@@ -113,7 +113,7 @@ void r8712_os_indicate_disconnect(struct _adapter *adapter)
 		 * for the following connection.
 		 */
 		memcpy(&adapter->securitypriv.PMKIDList[0],
-		       &backup_PMKID_List[0],
+		       &backup_PMKID_list[0],
 		       sizeof(struct RT_PMKID_LIST) * NUM_PMKID_CACHE);
 		adapter->securitypriv.PMKIDIndex = backupPMKIDIndex;
 		adapter->securitypriv.btkip_countermeasure =
-- 
2.7.4

Re: [Outreachy kernel] [PATCH 2/6 v2] staging: rtl8712: avoid camelcase variable name 'backupPMKIDList'

[Greg KH]

On Sun, Mar 24, 2019 at 11:11:01AM +0530, Payal Kshirsagar wrote:
> Eliminate camelcase variable names to fix the style issue – ‘avoid
> camelcase’.
> 
> Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
> ---
> Changes in v2:
> 	-backup_PMKID_List replaced with backup_PMKID_list

Is this just a single v2?  You sent out a whole new series though?

I am totally confused as to what to review here and what is the latest
version.  Please resend a new series, as "v3", on each patch, so that I
know what to review/apply.

thanks,

greg k-h

Re: [Outreachy kernel] [PATCH 2/6 v2] staging: rtl8712: avoid camelcase variable name 'backupPMKIDList'

[Payal Kshirsagar]

[-- Attachment #1: Type: text/plain, Size: 742 bytes --]

On Sun, Mar 24, 2019, 2:38 PM Greg KH <greg@kroah.com> wrote:

> On Sun, Mar 24, 2019 at 11:11:01AM +0530, Payal Kshirsagar wrote:
> > Eliminate camelcase variable names to fix the style issue – ‘avoid
> > camelcase’.
> >
> > Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
> > ---
> > Changes in v2:
> >       -backup_PMKID_List replaced with backup_PMKID_list
>
> Is this just a single v2?  You sent out a whole new series though?
>
> I am totally confused as to what to review here and what is the latest
> version.  Please resend a new series, as "v3", on each patch, so that I
> know what to review/apply.
>

Okay,I will resend the whole patchset.
Thanks ,
Payal

thanks,
>
> greg k-h
>

[-- Attachment #2: Type: text/html, Size: 1601 bytes --]