From: Christoph Hellwig <hch@lst.de>
To: Anup Patel <Anup.Patel@wdc.com>
Cc: Albert Ou <aou@eecs.berkeley.edu>,
Palmer Dabbelt <palmer@sifive.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Mike Rapoport <rppt@linux.ibm.com>,
Christoph Hellwig <hch@infradead.org>,
Atish Patra <Atish.Patra@wdc.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] RISC-V: Always compile mm/init.c with cmodel=medany
Date: Sun, 24 Mar 2019 15:57:08 +0100 [thread overview]
Message-ID: <20190324145708.GA3355@lst.de> (raw)
In-Reply-To: <20190324110804.68555-1-anup.patel@wdc.com>
On Sun, Mar 24, 2019 at 11:08:29AM +0000, Anup Patel wrote:
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
Huh? I don't think this is from Mike and me.
> +unsigned long va_pa_offset;
> +EXPORT_SYMBOL(va_pa_offset);
> +unsigned long pfn_base;
> +EXPORT_SYMBOL(pfn_base);
Can you move va_pa_offset and pfn_base next to the swapper_pg_dir
declaration? Thats where I move them in my current nommu patchset,
as that allows to just have a single CONFIG_NOMMU in mm/init.c.
Otherwise this looks fine to me.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Anup Patel <Anup.Patel@wdc.com>
Cc: Palmer Dabbelt <palmer@sifive.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Atish Patra <Atish.Patra@wdc.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Christoph Hellwig <hch@infradead.org>,
Mike Rapoport <rppt@linux.ibm.com>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] RISC-V: Always compile mm/init.c with cmodel=medany
Date: Sun, 24 Mar 2019 15:57:08 +0100 [thread overview]
Message-ID: <20190324145708.GA3355@lst.de> (raw)
In-Reply-To: <20190324110804.68555-1-anup.patel@wdc.com>
On Sun, Mar 24, 2019 at 11:08:29AM +0000, Anup Patel wrote:
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
Huh? I don't think this is from Mike and me.
> +unsigned long va_pa_offset;
> +EXPORT_SYMBOL(va_pa_offset);
> +unsigned long pfn_base;
> +EXPORT_SYMBOL(pfn_base);
Can you move va_pa_offset and pfn_base next to the swapper_pg_dir
declaration? Thats where I move them in my current nommu patchset,
as that allows to just have a single CONFIG_NOMMU in mm/init.c.
Otherwise this looks fine to me.
next prev parent reply other threads:[~2019-03-24 14:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-24 11:08 [PATCH] RISC-V: Always compile mm/init.c with cmodel=medany Anup Patel
2019-03-24 11:08 ` Anup Patel
2019-03-24 14:57 ` Christoph Hellwig [this message]
2019-03-24 14:57 ` Christoph Hellwig
2019-03-24 16:43 ` Mike Rapoport
2019-03-24 16:43 ` Mike Rapoport
2019-03-25 3:19 ` Anup Patel
2019-03-25 3:19 ` Anup Patel
2019-03-25 3:19 ` Anup Patel
2019-03-25 3:19 ` Anup Patel
2019-03-24 19:14 ` Gary Guo
2019-03-24 19:14 ` Gary Guo
2019-03-25 3:21 ` Anup Patel
2019-03-25 3:21 ` Anup Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190324145708.GA3355@lst.de \
--to=hch@lst.de \
--cc=Anup.Patel@wdc.com \
--cc=Atish.Patra@wdc.com \
--cc=aou@eecs.berkeley.edu \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
--cc=rppt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.