From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 1/2] nvme: target: fix nvmet_file_init_bvec()
Date: Mon, 25 Mar 2019 11:52:31 +0100 [thread overview]
Message-ID: <20190325105231.GA24907@lst.de> (raw)
In-Reply-To: <20190325100708.24172-2-ming.lei@redhat.com>
On Mon, Mar 25, 2019@06:07:07PM +0800, Ming Lei wrote:
> There isn't sg iterator helper for building bvec, so invent one
> and fix the issue in nvmet_file_init_bvec().
>
> The issue is that one sg may include multipge continuous pages, and
> only the 1st .bv_offset isn't zero, also the length for the last bvec
> has to consider the remained length.
The scatterlist in the nvme target is always allocated by the nvmet
code itself an thus never contains multi-page sg list entries.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: linux-nvme@lists.infradead.org, Christoph Hellwig <hch@lst.de>,
Yi Zhang <yi.zhang@redhat.com>, Sagi Grimberg <sagi@grimberg.me>,
Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>,
stable@vger.kernel.org
Subject: Re: [PATCH 1/2] nvme: target: fix nvmet_file_init_bvec()
Date: Mon, 25 Mar 2019 11:52:31 +0100 [thread overview]
Message-ID: <20190325105231.GA24907@lst.de> (raw)
In-Reply-To: <20190325100708.24172-2-ming.lei@redhat.com>
On Mon, Mar 25, 2019 at 06:07:07PM +0800, Ming Lei wrote:
> There isn't sg iterator helper for building bvec, so invent one
> and fix the issue in nvmet_file_init_bvec().
>
> The issue is that one sg may include multipge continuous pages, and
> only the 1st .bv_offset isn't zero, also the length for the last bvec
> has to consider the remained length.
The scatterlist in the nvme target is always allocated by the nvmet
code itself an thus never contains multi-page sg list entries.
next prev parent reply other threads:[~2019-03-25 10:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 10:07 [PATCH 0/2] nvme: target: build bvec from sg directly Ming Lei
2019-03-25 10:07 ` [PATCH 1/2] nvme: target: fix nvmet_file_init_bvec() Ming Lei
2019-03-25 10:07 ` Ming Lei
2019-03-25 10:52 ` Christoph Hellwig [this message]
2019-03-25 10:52 ` Christoph Hellwig
2019-03-26 1:39 ` Ming Lei
2019-03-26 1:39 ` Ming Lei
2019-03-26 2:03 ` Sagi Grimberg
2019-03-26 2:03 ` Sagi Grimberg
2019-03-26 2:16 ` Ming Lei
2019-03-26 2:16 ` Ming Lei
2019-03-26 7:32 ` Christoph Hellwig
2019-03-26 7:32 ` Christoph Hellwig
2019-03-27 14:00 ` Sasha Levin
2019-03-25 10:07 ` [PATCH 2/2] nvme: target: build bvec from sg directly Ming Lei
2019-03-25 10:55 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190325105231.GA24907@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.