All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Jerry-ch Chen <Jerry-Ch.chen@mediatek.com>
Cc: devicetree@vger.kernel.org, Sean.Cheng@mediatek.com,
	laurent.pinchart+renesas@ideasonboard.com, Rynn.Wu@mediatek.com,
	christie.yu@mediatek.com, srv_heupstream@mediatek.com,
	holmes.chiou@mediatek.com, tfiga@chromium.org,
	jungo.lin@mediatek.com, sj.huang@mediatek.com,
	yuzhao@chromium.org, hans.verkuil@cisco.com,
	zwisler@chromium.org, frederic.chen@mediatek.com,
	matthias.bgg@gmail.com, linux-mediatek@lists.infradead.org,
	mchehab@kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-media@vger.kernel.org
Subject: Re: [RFC PATCH V0 5/7] dts: arm64: mt8183: Add FD nodes
Date: Mon, 25 Mar 2019 16:57:28 -0500	[thread overview]
Message-ID: <20190325215728.GA32712@bogus> (raw)
In-Reply-To: <1550648893-42050-6-git-send-email-Jerry-Ch.chen@mediatek.com>

On Wed, Feb 20, 2019 at 03:48:11PM +0800, Jerry-ch Chen wrote:
> This patch adds nodes for Face Detection (FD) unit. FD is embedded
> in Mediatek SoCs and works with the co-processor to perform face
> detection on the input data and image and output detected face result.
> 
> Signed-off-by: Jerry-ch Chen <jerry-ch.chen@mediatek.com>
> ---
>  arch/arm64/boot/dts/mediatek/mt8183.dtsi | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> index b3d8dfd..45c7e2f 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> @@ -440,6 +440,26 @@
>  			#clock-cells = <1>;
>  		};
>  
> +		fd_smem: fd_smem {
> +			compatible = "mediatek,fd_smem";
> +			mediatek,larb = <&larb5>;
> +			iommus = <&iommu M4U_PORT_CAM_IMGI>;

This doesn't look like an actual h/w device...

> +		};
> +
> +		fd:fd@1502b000 {

space after the :  ^
> +			compatible = "mediatek,fd";

Should be SoC specific.

> +			mediatek,larb = <&larb5>;
> +			mediatek,vpu = <&vpu>;
> +			iommus = <&iommu M4U_PORT_CAM_FDVT_RP>,
> +				 <&iommu M4U_PORT_CAM_FDVT_WR>,
> +				 <&iommu M4U_PORT_CAM_FDVT_RB>;
> +			reg = <0 0x1502b000 0 0x1000>;
> +			interrupts = <GIC_SPI 269 IRQ_TYPE_LEVEL_LOW>;
> +			clocks = <&imgsys CLK_IMG_FDVT>;
> +			clock-names = "FD_CLK_IMG_FD";
> +			smem_device = <&fd_smem>;
> +		};
> +
>  		vdecsys: syscon@16000000 {
>  			compatible = "mediatek,mt8183-vdecsys", "syscon";
>  			reg = <0 0x16000000 0 0x1000>;
> -- 
> 1.9.1
> 

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Jerry-ch Chen <Jerry-Ch.chen@mediatek.com>
Cc: devicetree@vger.kernel.org, Sean.Cheng@mediatek.com,
	laurent.pinchart+renesas@ideasonboard.com, Rynn.Wu@mediatek.com,
	christie.yu@mediatek.com, srv_heupstream@mediatek.com,
	holmes.chiou@mediatek.com, tfiga@chromium.org,
	jungo.lin@mediatek.com, sj.huang@mediatek.com,
	yuzhao@chromium.org, hans.verkuil@cisco.com,
	zwisler@chromium.org, frederic.chen@mediatek.com,
	matthias.bgg@gmail.com, linux-mediatek@lists.infradead.org,
	mchehab@kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-media@vger.kernel.org
Subject: Re: [RFC PATCH V0 5/7] dts: arm64: mt8183: Add FD nodes
Date: Mon, 25 Mar 2019 16:57:28 -0500	[thread overview]
Message-ID: <20190325215728.GA32712@bogus> (raw)
In-Reply-To: <1550648893-42050-6-git-send-email-Jerry-Ch.chen@mediatek.com>

On Wed, Feb 20, 2019 at 03:48:11PM +0800, Jerry-ch Chen wrote:
> This patch adds nodes for Face Detection (FD) unit. FD is embedded
> in Mediatek SoCs and works with the co-processor to perform face
> detection on the input data and image and output detected face result.
> 
> Signed-off-by: Jerry-ch Chen <jerry-ch.chen@mediatek.com>
> ---
>  arch/arm64/boot/dts/mediatek/mt8183.dtsi | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> index b3d8dfd..45c7e2f 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> @@ -440,6 +440,26 @@
>  			#clock-cells = <1>;
>  		};
>  
> +		fd_smem: fd_smem {
> +			compatible = "mediatek,fd_smem";
> +			mediatek,larb = <&larb5>;
> +			iommus = <&iommu M4U_PORT_CAM_IMGI>;

This doesn't look like an actual h/w device...

> +		};
> +
> +		fd:fd@1502b000 {

space after the :  ^
> +			compatible = "mediatek,fd";

Should be SoC specific.

> +			mediatek,larb = <&larb5>;
> +			mediatek,vpu = <&vpu>;
> +			iommus = <&iommu M4U_PORT_CAM_FDVT_RP>,
> +				 <&iommu M4U_PORT_CAM_FDVT_WR>,
> +				 <&iommu M4U_PORT_CAM_FDVT_RB>;
> +			reg = <0 0x1502b000 0 0x1000>;
> +			interrupts = <GIC_SPI 269 IRQ_TYPE_LEVEL_LOW>;
> +			clocks = <&imgsys CLK_IMG_FDVT>;
> +			clock-names = "FD_CLK_IMG_FD";
> +			smem_device = <&fd_smem>;
> +		};
> +
>  		vdecsys: syscon@16000000 {
>  			compatible = "mediatek,mt8183-vdecsys", "syscon";
>  			reg = <0 0x16000000 0 0x1000>;
> -- 
> 1.9.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Jerry-ch Chen <Jerry-Ch.chen@mediatek.com>
Cc: hans.verkuil@cisco.com,
	laurent.pinchart+renesas@ideasonboard.com, tfiga@chromium.org,
	matthias.bgg@gmail.com, mchehab@kernel.org, yuzhao@chromium.org,
	zwisler@chromium.org, linux-mediatek@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org, Sean.Cheng@mediatek.com,
	sj.huang@mediatek.com, christie.yu@mediatek.com,
	holmes.chiou@mediatek.com, frederic.chen@mediatek.com,
	jungo.lin@mediatek.com, Rynn.Wu@mediatek.com,
	linux-media@vger.kernel.org, srv_heupstream@mediatek.com,
	devicetree@vger.kernel.org
Subject: Re: [RFC PATCH V0 5/7] dts: arm64: mt8183: Add FD nodes
Date: Mon, 25 Mar 2019 16:57:28 -0500	[thread overview]
Message-ID: <20190325215728.GA32712@bogus> (raw)
In-Reply-To: <1550648893-42050-6-git-send-email-Jerry-Ch.chen@mediatek.com>

On Wed, Feb 20, 2019 at 03:48:11PM +0800, Jerry-ch Chen wrote:
> This patch adds nodes for Face Detection (FD) unit. FD is embedded
> in Mediatek SoCs and works with the co-processor to perform face
> detection on the input data and image and output detected face result.
> 
> Signed-off-by: Jerry-ch Chen <jerry-ch.chen@mediatek.com>
> ---
>  arch/arm64/boot/dts/mediatek/mt8183.dtsi | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> index b3d8dfd..45c7e2f 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> @@ -440,6 +440,26 @@
>  			#clock-cells = <1>;
>  		};
>  
> +		fd_smem: fd_smem {
> +			compatible = "mediatek,fd_smem";
> +			mediatek,larb = <&larb5>;
> +			iommus = <&iommu M4U_PORT_CAM_IMGI>;

This doesn't look like an actual h/w device...

> +		};
> +
> +		fd:fd@1502b000 {

space after the :  ^
> +			compatible = "mediatek,fd";

Should be SoC specific.

> +			mediatek,larb = <&larb5>;
> +			mediatek,vpu = <&vpu>;
> +			iommus = <&iommu M4U_PORT_CAM_FDVT_RP>,
> +				 <&iommu M4U_PORT_CAM_FDVT_WR>,
> +				 <&iommu M4U_PORT_CAM_FDVT_RB>;
> +			reg = <0 0x1502b000 0 0x1000>;
> +			interrupts = <GIC_SPI 269 IRQ_TYPE_LEVEL_LOW>;
> +			clocks = <&imgsys CLK_IMG_FDVT>;
> +			clock-names = "FD_CLK_IMG_FD";
> +			smem_device = <&fd_smem>;
> +		};
> +
>  		vdecsys: syscon@16000000 {
>  			compatible = "mediatek,mt8183-vdecsys", "syscon";
>  			reg = <0 0x16000000 0 0x1000>;
> -- 
> 1.9.1
> 

  reply	other threads:[~2019-03-25 21:57 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-20  7:48 [RFC PATCH V0 0/7] media: platform: Add support for Face Detection (FD) on mt8183 SoC Jerry-ch Chen
2019-02-20  7:48 ` Jerry-ch Chen
2019-02-20  7:48 ` Jerry-ch Chen
2019-02-20  7:48 ` [RFC PATCH V0 1/7] dt-bindings: mt8183: Add binding for FD shared memory Jerry-ch Chen
2019-02-20  7:48   ` Jerry-ch Chen
2019-02-20  7:48   ` Jerry-ch Chen
2019-02-20  7:48 ` [RFC PATCH V0 2/7] dts: arm64: mt8183: Add FD shared memory node Jerry-ch Chen
2019-02-20  7:48   ` Jerry-ch Chen
2019-02-20  7:48   ` Jerry-ch Chen
2019-02-20  7:48 ` [RFC PATCH V0 4/7] [media] dt-bindings: mt8183: Added FD dt-bindings Jerry-ch Chen
2019-02-20  7:48   ` Jerry-ch Chen
2019-02-20  7:48   ` Jerry-ch Chen
2019-02-20  7:48 ` [RFC PATCH V0 5/7] dts: arm64: mt8183: Add FD nodes Jerry-ch Chen
2019-02-20  7:48   ` Jerry-ch Chen
2019-02-20  7:48   ` Jerry-ch Chen
2019-03-25 21:57   ` Rob Herring [this message]
2019-03-25 21:57     ` Rob Herring
2019-03-25 21:57     ` Rob Herring
2019-04-03  2:26     ` Jerry-ch Chen
2019-04-03  2:26       ` Jerry-ch Chen
2019-04-03  2:26       ` Jerry-ch Chen
2019-02-20  7:48 ` [RFC PATCH V0 6/7] media: platform: Add Mediatek FD driver KConfig Jerry-ch Chen
2019-02-20  7:48   ` Jerry-ch Chen
2019-02-20  7:48   ` Jerry-ch Chen
     [not found] ` <1550648893-42050-1-git-send-email-Jerry-Ch.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2019-02-20  7:48   ` [RFC PATCH V0 3/7] [media] dt-bindings: mt8183: Added FD-SMEM dt-bindings Jerry-ch Chen
2019-02-20  7:48     ` Jerry-ch Chen
2019-02-20  7:48     ` Jerry-ch Chen
2019-02-20  7:48   ` [RFC PATCH V0 7/7] [media] platform: mtk-isp: Add Mediatek FD driver Jerry-ch Chen
2019-02-20  7:48     ` Jerry-ch Chen
     [not found]     ` <1550648893-42050-8-git-send-email-Jerry-Ch.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2019-03-05  7:48       ` Tomasz Figa
2019-03-05  7:48         ` Tomasz Figa
2019-03-14  8:40 ` [RFC PATCH V0 0/7] media: platform: Add support for Face Detection (FD) on mt8183 SoC Hans Verkuil
2019-03-14  8:40   ` Hans Verkuil
2019-03-14  8:40   ` Hans Verkuil
2019-03-21 10:29   ` Jerry-ch Chen
2019-03-21 10:29     ` Jerry-ch Chen
2019-03-21 10:29     ` Jerry-ch Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190325215728.GA32712@bogus \
    --to=robh@kernel.org \
    --cc=Jerry-Ch.chen@mediatek.com \
    --cc=Rynn.Wu@mediatek.com \
    --cc=Sean.Cheng@mediatek.com \
    --cc=christie.yu@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=frederic.chen@mediatek.com \
    --cc=hans.verkuil@cisco.com \
    --cc=holmes.chiou@mediatek.com \
    --cc=jungo.lin@mediatek.com \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=mchehab@kernel.org \
    --cc=sj.huang@mediatek.com \
    --cc=srv_heupstream@mediatek.com \
    --cc=tfiga@chromium.org \
    --cc=yuzhao@chromium.org \
    --cc=zwisler@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.