From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@01.org, Tamizh chelvam <tamizhr@codeaurora.org>
Cc: johannes@sipsolutions.net, linux-wireless@vger.kernel.org,
kbuild-all@01.org, ath10k@lists.infradead.org
Subject: Re: [PATCHv3 1/9] nl80211: New netlink command for TID specific configuration
Date: Tue, 26 Mar 2019 10:00:02 +0300 [thread overview]
Message-ID: <20190326070002.GB32613@kadam> (raw)
In-Reply-To: <1551895251-22941-2-git-send-email-tamizhr@codeaurora.org>
Hi Tamizh,
Thank you for the patch! Perhaps something to improve:
url: https://github.com/0day-ci/linux/commits/Tamizh-chelvam/cfg80211-mac80211-Add-support-for-TID-specific-configuration/20190308-195433
base: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master
New smatch warnings:
net/wireless/nl80211.c:13336 nl80211_set_tid_config() warn: possible memory leak of 'tid_conf'
Old smatch warnings:
net/wireless/nl80211.c:13339 nl80211_set_tid_config() warn: possible memory leak of 'tid_conf'
# https://github.com/0day-ci/linux/commit/e462f4e99ba46deede4c2e78bd343211d372246d
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout e462f4e99ba46deede4c2e78bd343211d372246d
vim +/tid_conf +13336 net/wireless/nl80211.c
e462f4e9 Tamizh chelvam 2019-03-06 13293
e462f4e9 Tamizh chelvam 2019-03-06 13294 static int nl80211_set_tid_config(struct sk_buff *skb,
e462f4e9 Tamizh chelvam 2019-03-06 13295 struct genl_info *info)
e462f4e9 Tamizh chelvam 2019-03-06 13296 {
e462f4e9 Tamizh chelvam 2019-03-06 13297 struct cfg80211_registered_device *rdev = info->user_ptr[0];
e462f4e9 Tamizh chelvam 2019-03-06 13298 struct nlattr *attrs[NL80211_ATTR_TID_CONFIG_MAX + 1];
e462f4e9 Tamizh chelvam 2019-03-06 13299 struct net_device *dev = info->user_ptr[1];
e462f4e9 Tamizh chelvam 2019-03-06 13300 struct ieee80211_tid_config *tid_conf;
e462f4e9 Tamizh chelvam 2019-03-06 13301 struct nlattr *tid;
e462f4e9 Tamizh chelvam 2019-03-06 13302 int conf_idx = 0, rem_conf;
e462f4e9 Tamizh chelvam 2019-03-06 13303 u32 num_conf = 0, size_of_conf;
e462f4e9 Tamizh chelvam 2019-03-06 13304 int ret = -EINVAL;
e462f4e9 Tamizh chelvam 2019-03-06 13305
e462f4e9 Tamizh chelvam 2019-03-06 13306 if (!info->attrs[NL80211_ATTR_TID_CONFIG])
e462f4e9 Tamizh chelvam 2019-03-06 13307 return -EINVAL;
e462f4e9 Tamizh chelvam 2019-03-06 13308
e462f4e9 Tamizh chelvam 2019-03-06 13309 if (!rdev->ops->set_tid_config)
e462f4e9 Tamizh chelvam 2019-03-06 13310 return -EOPNOTSUPP;
e462f4e9 Tamizh chelvam 2019-03-06 13311
e462f4e9 Tamizh chelvam 2019-03-06 13312 nla_for_each_nested(tid, info->attrs[NL80211_ATTR_TID_CONFIG],
e462f4e9 Tamizh chelvam 2019-03-06 13313 rem_conf)
e462f4e9 Tamizh chelvam 2019-03-06 13314 num_conf++;
e462f4e9 Tamizh chelvam 2019-03-06 13315
e462f4e9 Tamizh chelvam 2019-03-06 13316 size_of_conf = sizeof(struct ieee80211_tid_config) +
e462f4e9 Tamizh chelvam 2019-03-06 13317 num_conf * sizeof(struct ieee80211_tid_cfg);
e462f4e9 Tamizh chelvam 2019-03-06 13318
e462f4e9 Tamizh chelvam 2019-03-06 13319 tid_conf = kzalloc(size_of_conf, GFP_KERNEL);
e462f4e9 Tamizh chelvam 2019-03-06 13320 if (!tid_conf)
e462f4e9 Tamizh chelvam 2019-03-06 13321 return -ENOMEM;
e462f4e9 Tamizh chelvam 2019-03-06 13322
e462f4e9 Tamizh chelvam 2019-03-06 13323 tid_conf->n_tid_conf = num_conf;
e462f4e9 Tamizh chelvam 2019-03-06 13324
e462f4e9 Tamizh chelvam 2019-03-06 13325 if (info->attrs[NL80211_ATTR_MAC])
e462f4e9 Tamizh chelvam 2019-03-06 13326 tid_conf->peer = nla_data(info->attrs[NL80211_ATTR_MAC]);
e462f4e9 Tamizh chelvam 2019-03-06 13327 else
e462f4e9 Tamizh chelvam 2019-03-06 13328 tid_conf->peer = NULL;
e462f4e9 Tamizh chelvam 2019-03-06 13329
e462f4e9 Tamizh chelvam 2019-03-06 13330 nla_for_each_nested(tid, info->attrs[NL80211_ATTR_TID_CONFIG],
e462f4e9 Tamizh chelvam 2019-03-06 13331 rem_conf) {
e462f4e9 Tamizh chelvam 2019-03-06 13332 ret = nla_parse_nested(attrs, NL80211_ATTR_TID_CONFIG_MAX, tid,
e462f4e9 Tamizh chelvam 2019-03-06 13333 NULL, NULL);
e462f4e9 Tamizh chelvam 2019-03-06 13334
e462f4e9 Tamizh chelvam 2019-03-06 13335 if (ret)
e462f4e9 Tamizh chelvam 2019-03-06 @13336 return ret;
e462f4e9 Tamizh chelvam 2019-03-06 13337
e462f4e9 Tamizh chelvam 2019-03-06 13338 if (!attrs[NL80211_ATTR_TID_CONFIG_TID])
e462f4e9 Tamizh chelvam 2019-03-06 13339 return -EINVAL;
e462f4e9 Tamizh chelvam 2019-03-06 13340
e462f4e9 Tamizh chelvam 2019-03-06 13341 ret = parse_tid_conf(rdev, attrs, &tid_conf->tid_conf[conf_idx],
e462f4e9 Tamizh chelvam 2019-03-06 13342 tid_conf->peer);
e462f4e9 Tamizh chelvam 2019-03-06 13343 if (ret)
e462f4e9 Tamizh chelvam 2019-03-06 13344 goto bad_tid_conf;
e462f4e9 Tamizh chelvam 2019-03-06 13345
e462f4e9 Tamizh chelvam 2019-03-06 13346 conf_idx++;
e462f4e9 Tamizh chelvam 2019-03-06 13347 }
e462f4e9 Tamizh chelvam 2019-03-06 13348
e462f4e9 Tamizh chelvam 2019-03-06 13349 ret = rdev_set_tid_config(rdev, dev, tid_conf);
e462f4e9 Tamizh chelvam 2019-03-06 13350
e462f4e9 Tamizh chelvam 2019-03-06 13351 bad_tid_conf:
e462f4e9 Tamizh chelvam 2019-03-06 13352 kfree(tid_conf);
e462f4e9 Tamizh chelvam 2019-03-06 13353 return ret;
e462f4e9 Tamizh chelvam 2019-03-06 13354 }
e462f4e9 Tamizh chelvam 2019-03-06 13355
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@01.org, Tamizh chelvam <tamizhr@codeaurora.org>
Cc: kbuild-all@01.org, johannes@sipsolutions.net,
ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
Tamizh chelvam <tamizhr@codeaurora.org>
Subject: Re: [PATCHv3 1/9] nl80211: New netlink command for TID specific configuration
Date: Tue, 26 Mar 2019 10:00:02 +0300 [thread overview]
Message-ID: <20190326070002.GB32613@kadam> (raw)
In-Reply-To: <1551895251-22941-2-git-send-email-tamizhr@codeaurora.org>
Hi Tamizh,
Thank you for the patch! Perhaps something to improve:
url: https://github.com/0day-ci/linux/commits/Tamizh-chelvam/cfg80211-mac80211-Add-support-for-TID-specific-configuration/20190308-195433
base: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master
New smatch warnings:
net/wireless/nl80211.c:13336 nl80211_set_tid_config() warn: possible memory leak of 'tid_conf'
Old smatch warnings:
net/wireless/nl80211.c:13339 nl80211_set_tid_config() warn: possible memory leak of 'tid_conf'
# https://github.com/0day-ci/linux/commit/e462f4e99ba46deede4c2e78bd343211d372246d
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout e462f4e99ba46deede4c2e78bd343211d372246d
vim +/tid_conf +13336 net/wireless/nl80211.c
e462f4e9 Tamizh chelvam 2019-03-06 13293
e462f4e9 Tamizh chelvam 2019-03-06 13294 static int nl80211_set_tid_config(struct sk_buff *skb,
e462f4e9 Tamizh chelvam 2019-03-06 13295 struct genl_info *info)
e462f4e9 Tamizh chelvam 2019-03-06 13296 {
e462f4e9 Tamizh chelvam 2019-03-06 13297 struct cfg80211_registered_device *rdev = info->user_ptr[0];
e462f4e9 Tamizh chelvam 2019-03-06 13298 struct nlattr *attrs[NL80211_ATTR_TID_CONFIG_MAX + 1];
e462f4e9 Tamizh chelvam 2019-03-06 13299 struct net_device *dev = info->user_ptr[1];
e462f4e9 Tamizh chelvam 2019-03-06 13300 struct ieee80211_tid_config *tid_conf;
e462f4e9 Tamizh chelvam 2019-03-06 13301 struct nlattr *tid;
e462f4e9 Tamizh chelvam 2019-03-06 13302 int conf_idx = 0, rem_conf;
e462f4e9 Tamizh chelvam 2019-03-06 13303 u32 num_conf = 0, size_of_conf;
e462f4e9 Tamizh chelvam 2019-03-06 13304 int ret = -EINVAL;
e462f4e9 Tamizh chelvam 2019-03-06 13305
e462f4e9 Tamizh chelvam 2019-03-06 13306 if (!info->attrs[NL80211_ATTR_TID_CONFIG])
e462f4e9 Tamizh chelvam 2019-03-06 13307 return -EINVAL;
e462f4e9 Tamizh chelvam 2019-03-06 13308
e462f4e9 Tamizh chelvam 2019-03-06 13309 if (!rdev->ops->set_tid_config)
e462f4e9 Tamizh chelvam 2019-03-06 13310 return -EOPNOTSUPP;
e462f4e9 Tamizh chelvam 2019-03-06 13311
e462f4e9 Tamizh chelvam 2019-03-06 13312 nla_for_each_nested(tid, info->attrs[NL80211_ATTR_TID_CONFIG],
e462f4e9 Tamizh chelvam 2019-03-06 13313 rem_conf)
e462f4e9 Tamizh chelvam 2019-03-06 13314 num_conf++;
e462f4e9 Tamizh chelvam 2019-03-06 13315
e462f4e9 Tamizh chelvam 2019-03-06 13316 size_of_conf = sizeof(struct ieee80211_tid_config) +
e462f4e9 Tamizh chelvam 2019-03-06 13317 num_conf * sizeof(struct ieee80211_tid_cfg);
e462f4e9 Tamizh chelvam 2019-03-06 13318
e462f4e9 Tamizh chelvam 2019-03-06 13319 tid_conf = kzalloc(size_of_conf, GFP_KERNEL);
e462f4e9 Tamizh chelvam 2019-03-06 13320 if (!tid_conf)
e462f4e9 Tamizh chelvam 2019-03-06 13321 return -ENOMEM;
e462f4e9 Tamizh chelvam 2019-03-06 13322
e462f4e9 Tamizh chelvam 2019-03-06 13323 tid_conf->n_tid_conf = num_conf;
e462f4e9 Tamizh chelvam 2019-03-06 13324
e462f4e9 Tamizh chelvam 2019-03-06 13325 if (info->attrs[NL80211_ATTR_MAC])
e462f4e9 Tamizh chelvam 2019-03-06 13326 tid_conf->peer = nla_data(info->attrs[NL80211_ATTR_MAC]);
e462f4e9 Tamizh chelvam 2019-03-06 13327 else
e462f4e9 Tamizh chelvam 2019-03-06 13328 tid_conf->peer = NULL;
e462f4e9 Tamizh chelvam 2019-03-06 13329
e462f4e9 Tamizh chelvam 2019-03-06 13330 nla_for_each_nested(tid, info->attrs[NL80211_ATTR_TID_CONFIG],
e462f4e9 Tamizh chelvam 2019-03-06 13331 rem_conf) {
e462f4e9 Tamizh chelvam 2019-03-06 13332 ret = nla_parse_nested(attrs, NL80211_ATTR_TID_CONFIG_MAX, tid,
e462f4e9 Tamizh chelvam 2019-03-06 13333 NULL, NULL);
e462f4e9 Tamizh chelvam 2019-03-06 13334
e462f4e9 Tamizh chelvam 2019-03-06 13335 if (ret)
e462f4e9 Tamizh chelvam 2019-03-06 @13336 return ret;
e462f4e9 Tamizh chelvam 2019-03-06 13337
e462f4e9 Tamizh chelvam 2019-03-06 13338 if (!attrs[NL80211_ATTR_TID_CONFIG_TID])
e462f4e9 Tamizh chelvam 2019-03-06 13339 return -EINVAL;
e462f4e9 Tamizh chelvam 2019-03-06 13340
e462f4e9 Tamizh chelvam 2019-03-06 13341 ret = parse_tid_conf(rdev, attrs, &tid_conf->tid_conf[conf_idx],
e462f4e9 Tamizh chelvam 2019-03-06 13342 tid_conf->peer);
e462f4e9 Tamizh chelvam 2019-03-06 13343 if (ret)
e462f4e9 Tamizh chelvam 2019-03-06 13344 goto bad_tid_conf;
e462f4e9 Tamizh chelvam 2019-03-06 13345
e462f4e9 Tamizh chelvam 2019-03-06 13346 conf_idx++;
e462f4e9 Tamizh chelvam 2019-03-06 13347 }
e462f4e9 Tamizh chelvam 2019-03-06 13348
e462f4e9 Tamizh chelvam 2019-03-06 13349 ret = rdev_set_tid_config(rdev, dev, tid_conf);
e462f4e9 Tamizh chelvam 2019-03-06 13350
e462f4e9 Tamizh chelvam 2019-03-06 13351 bad_tid_conf:
e462f4e9 Tamizh chelvam 2019-03-06 13352 kfree(tid_conf);
e462f4e9 Tamizh chelvam 2019-03-06 13353 return ret;
e462f4e9 Tamizh chelvam 2019-03-06 13354 }
e462f4e9 Tamizh chelvam 2019-03-06 13355
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
next prev parent reply other threads:[~2019-03-26 7:00 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-06 18:00 [PATCHv3 0/9] cfg80211/mac80211: Add support for TID specific configuration Tamizh chelvam
2019-03-06 18:00 ` Tamizh chelvam
2019-03-06 18:00 ` [PATCHv3 1/9] nl80211: New netlink command " Tamizh chelvam
2019-03-06 18:00 ` Tamizh chelvam
2019-03-26 7:00 ` Dan Carpenter [this message]
2019-03-26 7:00 ` Dan Carpenter
2019-03-06 18:00 ` [PATCHv3 2/9] nl80211: Add new netlink attribute for TID speicific retry count Tamizh chelvam
2019-03-06 18:00 ` Tamizh chelvam
2019-03-06 18:00 ` [PATCHv3 3/9] nl80211: Add netlink attribute for AMPDU aggregation enable/disable Tamizh chelvam
2019-03-06 18:00 ` Tamizh chelvam
2019-03-06 18:00 ` [PATCHv3 4/9] nl80211: Add netlink attribute to enable/disable RTS_CTS Tamizh chelvam
2019-03-06 18:00 ` Tamizh chelvam
2019-03-06 18:00 ` [PATCHv3 5/9] nl80211: Add netlink attribute to configure TID specific tx rate Tamizh chelvam
2019-03-06 18:00 ` Tamizh chelvam
2019-03-06 18:00 ` [PATCHv3 6/9] mac80211: Add api to support configuring TID specific configuration Tamizh chelvam
2019-03-06 18:00 ` Tamizh chelvam
2019-03-08 16:54 ` kbuild test robot
2019-03-08 16:54 ` kbuild test robot
2019-03-06 18:00 ` [PATCHv3 7/9] ath10k: Add wmi command support for station specific TID config Tamizh chelvam
2019-03-06 18:00 ` Tamizh chelvam
2019-03-06 18:00 ` [PATCHv3 8/9] ath10k: Add new api to support TID specific configuration Tamizh chelvam
2019-03-06 18:00 ` Tamizh chelvam
2019-03-11 7:02 ` Dan Carpenter
2019-03-11 7:02 ` Dan Carpenter
2019-03-06 18:00 ` [PATCHv3 9/9] ath10k: Add extended TID configuration support Tamizh chelvam
2019-03-06 18:00 ` Tamizh chelvam
2019-03-08 19:30 ` [PATCHv3 0/9] cfg80211/mac80211: Add support for TID specific configuration Sergey Matyukevich
2019-03-08 19:30 ` Sergey Matyukevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190326070002.GB32613@kadam \
--to=dan.carpenter@oracle.com \
--cc=ath10k@lists.infradead.org \
--cc=johannes@sipsolutions.net \
--cc=kbuild-all@01.org \
--cc=kbuild@01.org \
--cc=linux-wireless@vger.kernel.org \
--cc=tamizhr@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.