From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Dean Nelson <dnelson@redhat.com>
Cc: Vadim Lomovtsev <vlomovtsev@marvell.com>,
Robert Richter <rric@kernel.org>,
netdev@vger.kernel.org, brouer@redhat.com,
Sunil Goutham <sgoutham@cavium.com>,
David Miller <davem@davemloft.net>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net v2 0/2] thunderx: fix receive buffer page recycling
Date: Tue, 26 Mar 2019 17:18:44 +0100 [thread overview]
Message-ID: <20190326171844.014b1918@carbon> (raw)
In-Reply-To: <08849eac-c185-ee0d-3907-85beb392899b@redhat.com>
On Tue, 26 Mar 2019 11:09:10 -0500
Dean Nelson <dnelson@redhat.com> wrote:
> On 3/26/19 10:53 AM, Dean Nelson wrote:
> > In attempting to optimize receive buffer page recycling for XDP, commit
> > 773225388dae15e72790 ("net: thunderx: Optimize page recycling for XDP")
> > inadvertently introduced two problems for the non-XDP case, that will be
> > addressed by this patch series.
> >
> > Dean Nelson (2):
> > thunderx: enable page recycling for non-XDP case
> > thunderx: eliminate extra calls to put_page() for pages held for recycling
> >
> > drivers/net/ethernet/cavium/thunder/nicvf_queues.c | 30 ++++++++++++++----------------
> > 1 file changed, 14 insertions(+), 16 deletions(-)
> >
>
>
> I'm really sorry, I completely forgot to add a description
> of what the changes were made by v2 (which was just to add
> the 'Fixes:' lines to the changelogs).
That should be okay, for such a small change.
> And I forgot to add you to the CC-list. I'm assuming I
> should repost? Right? (And do you want to be added?)
>
> It's just one of those days.
I can live with not getting Cc'ed (but I would prefer it), but some
other adjustments.
There should not be a newline between "Fixes:" and "Signed-off-by:".
And nitpicking, I believe that we usually only show the first 12 chars
of the commit id. I have setup git to use: 'git show --pretty=fixes'
From my ~/.gitconfig:
---------------------
[core]
abbrev = 12
[pretty]
fixes = Fixes: %h (\"%s\")
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Dean Nelson <dnelson@redhat.com>
Cc: brouer@redhat.com, Robert Richter <rric@kernel.org>,
Sunil Goutham <sgoutham@cavium.com>,
David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Vadim Lomovtsev <vlomovtsev@marvell.com>
Subject: Re: [PATCH net v2 0/2] thunderx: fix receive buffer page recycling
Date: Tue, 26 Mar 2019 17:18:44 +0100 [thread overview]
Message-ID: <20190326171844.014b1918@carbon> (raw)
In-Reply-To: <08849eac-c185-ee0d-3907-85beb392899b@redhat.com>
On Tue, 26 Mar 2019 11:09:10 -0500
Dean Nelson <dnelson@redhat.com> wrote:
> On 3/26/19 10:53 AM, Dean Nelson wrote:
> > In attempting to optimize receive buffer page recycling for XDP, commit
> > 773225388dae15e72790 ("net: thunderx: Optimize page recycling for XDP")
> > inadvertently introduced two problems for the non-XDP case, that will be
> > addressed by this patch series.
> >
> > Dean Nelson (2):
> > thunderx: enable page recycling for non-XDP case
> > thunderx: eliminate extra calls to put_page() for pages held for recycling
> >
> > drivers/net/ethernet/cavium/thunder/nicvf_queues.c | 30 ++++++++++++++----------------
> > 1 file changed, 14 insertions(+), 16 deletions(-)
> >
>
>
> I'm really sorry, I completely forgot to add a description
> of what the changes were made by v2 (which was just to add
> the 'Fixes:' lines to the changelogs).
That should be okay, for such a small change.
> And I forgot to add you to the CC-list. I'm assuming I
> should repost? Right? (And do you want to be added?)
>
> It's just one of those days.
I can live with not getting Cc'ed (but I would prefer it), but some
other adjustments.
There should not be a newline between "Fixes:" and "Signed-off-by:".
And nitpicking, I believe that we usually only show the first 12 chars
of the commit id. I have setup git to use: 'git show --pretty=fixes'
From my ~/.gitconfig:
---------------------
[core]
abbrev = 12
[pretty]
fixes = Fixes: %h (\"%s\")
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2019-03-26 16:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-26 15:53 [PATCH net v2 0/2] thunderx: fix receive buffer page recycling Dean Nelson
2019-03-26 15:53 ` [PATCH net v2 1/2] thunderx: enable page recycling for non-XDP case Dean Nelson
2019-03-26 15:53 ` [PATCH net v2 2/2] thunderx: eliminate extra calls to put_page() for pages held for recycling Dean Nelson
2019-03-26 16:09 ` [PATCH net v2 0/2] thunderx: fix receive buffer page recycling Dean Nelson
2019-03-26 16:09 ` Dean Nelson
2019-03-26 16:18 ` Jesper Dangaard Brouer [this message]
2019-03-26 16:18 ` Jesper Dangaard Brouer
2019-03-26 17:24 ` Dean Nelson
2019-03-26 17:24 ` Dean Nelson
2019-03-28 5:56 ` David Miller
2019-03-28 5:56 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190326171844.014b1918@carbon \
--to=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=dnelson@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=rric@kernel.org \
--cc=sgoutham@cavium.com \
--cc=vlomovtsev@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.