From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 1/4] nvmet: set loop queue's segment boundary mask as PAGE_SIZE - 1
Date: Wed, 27 Mar 2019 09:15:08 +0100 [thread overview]
Message-ID: <20190327081508.GE20525@lst.de> (raw)
In-Reply-To: <CACVXFVODbii+X6M6=k41-gBhWzRQ9vpbsmLnzoJT4wkoi5C7gw@mail.gmail.com>
On Tue, Mar 26, 2019@03:37:36PM +0800, Ming Lei wrote:
> On Tue, Mar 26, 2019@3:36 PM Christoph Hellwig <hch@lst.de> wrote:
> >
> > Note that in many cases allocating larger pages in the other targets
> > would be useful. Given that you fix the one places where we made a page
> > size assumption I don't see a great need to limit outselves here.
>
> block device backed ns still needs this patch.
Then we need to fix that code as well. Or even better make bio_add_page
handle the larger than page case fine if it really doesn't do that yet.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <tom.leiming@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>, Ming Lei <ming.lei@redhat.com>,
Yi Zhang <yi.zhang@redhat.com>, Sagi Grimberg <sagi@grimberg.me>,
Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>,
stable <stable@vger.kernel.org>,
linux-nvme <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH 1/4] nvmet: set loop queue's segment boundary mask as PAGE_SIZE - 1
Date: Wed, 27 Mar 2019 09:15:08 +0100 [thread overview]
Message-ID: <20190327081508.GE20525@lst.de> (raw)
In-Reply-To: <CACVXFVODbii+X6M6=k41-gBhWzRQ9vpbsmLnzoJT4wkoi5C7gw@mail.gmail.com>
On Tue, Mar 26, 2019 at 03:37:36PM +0800, Ming Lei wrote:
> On Tue, Mar 26, 2019 at 3:36 PM Christoph Hellwig <hch@lst.de> wrote:
> >
> > Note that in many cases allocating larger pages in the other targets
> > would be useful. Given that you fix the one places where we made a page
> > size assumption I don't see a great need to limit outselves here.
>
> block device backed ns still needs this patch.
Then we need to fix that code as well. Or even better make bio_add_page
handle the larger than page case fine if it really doesn't do that yet.
next prev parent reply other threads:[~2019-03-27 8:15 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-26 3:19 [PATCH 0/4] nvmet: fix file & block device backed ns Ming Lei
2019-03-26 3:19 ` [PATCH 1/4] nvmet: set loop queue's segment boundary mask as PAGE_SIZE - 1 Ming Lei
2019-03-26 3:19 ` Ming Lei
2019-03-26 7:36 ` Christoph Hellwig
2019-03-26 7:36 ` Christoph Hellwig
2019-03-26 7:37 ` Ming Lei
2019-03-26 7:37 ` Ming Lei
2019-03-26 7:39 ` Ming Lei
2019-03-26 7:39 ` Ming Lei
2019-03-27 8:15 ` Christoph Hellwig [this message]
2019-03-27 8:15 ` Christoph Hellwig
2019-03-27 8:26 ` Ming Lei
2019-03-27 8:26 ` Ming Lei
2019-03-27 8:39 ` Christoph Hellwig
2019-03-27 8:39 ` Christoph Hellwig
2019-03-26 3:19 ` [PATCH 2/4] nvmet: fix computation of io vector number Ming Lei
2019-03-26 3:19 ` Ming Lei
2019-03-26 7:38 ` Christoph Hellwig
2019-03-26 7:38 ` Christoph Hellwig
2019-03-26 7:50 ` Ming Lei
2019-03-26 7:50 ` Ming Lei
2019-03-27 8:15 ` Christoph Hellwig
2019-03-27 8:15 ` Christoph Hellwig
2019-03-26 3:19 ` [PATCH 3/4] nvmet: fix computation of bvec->bv_len Ming Lei
2019-03-26 3:19 ` Ming Lei
2019-03-26 3:19 ` [PATCH 4/4] nvmet: build bvec from sg directly Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190327081508.GE20525@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.