From: Wolfram Sang <wsa@the-dreams.de>
To: Stefan Lengfeld <contact@stefanchrist.eu>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-i2c@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, Keerthy <j-keerthy@ti.com>,
Peter Rosin <peda@axentia.se>, Tony Lindgren <tony@atomide.com>,
Russell King <linux@armlinux.org.uk>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Phil Reid <preid@electromag.com.au>,
Tero Kristo <t-kristo@ti.com>,
linux-omap@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [RFC PATCH v2 6/7] i2c: tegra-bpmp: convert to use new atomic callbacks
Date: Wed, 27 Mar 2019 14:51:14 +0100 [thread overview]
Message-ID: <20190327135114.GF5345@kunai> (raw)
In-Reply-To: <20190326202005.s3ktyth42lfjirx2@porty>
[-- Attachment #1: Type: text/plain, Size: 492 bytes --]
> > +static int tegra_bpmp_i2c_xfer(struct i2c_adapter *adapter,
> > + struct i2c_msg *msgs, int num)
> > +
> > +{
> > + return tegra_bpmp_i2c_xfer_common(adapter, msgs, num, false);
> > +}
> > +
> > +static int tegra_bpmp_i2c_xfer_atomic(struct i2c_adapter *adapter,
> > + struct i2c_msg *msgs, int num)
> > +
>
> Here and between the function prototype of 'tegra_bpmp_i2c_xfer' and
> it's function body is a unneeded blank line. Nitpick.
Thanks, fixed!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: Stefan Lengfeld <contact@stefanchrist.eu>
Cc: Tero Kristo <t-kristo@ti.com>,
Phil Reid <preid@electromag.com.au>,
Tony Lindgren <tony@atomide.com>, Keerthy <j-keerthy@ti.com>,
linux-kernel@vger.kernel.org,
Russell King <linux@armlinux.org.uk>,
linux-renesas-soc@vger.kernel.org,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-omap@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-tegra@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Peter Rosin <peda@axentia.se>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH v2 6/7] i2c: tegra-bpmp: convert to use new atomic callbacks
Date: Wed, 27 Mar 2019 14:51:14 +0100 [thread overview]
Message-ID: <20190327135114.GF5345@kunai> (raw)
In-Reply-To: <20190326202005.s3ktyth42lfjirx2@porty>
[-- Attachment #1.1: Type: text/plain, Size: 492 bytes --]
> > +static int tegra_bpmp_i2c_xfer(struct i2c_adapter *adapter,
> > + struct i2c_msg *msgs, int num)
> > +
> > +{
> > + return tegra_bpmp_i2c_xfer_common(adapter, msgs, num, false);
> > +}
> > +
> > +static int tegra_bpmp_i2c_xfer_atomic(struct i2c_adapter *adapter,
> > + struct i2c_msg *msgs, int num)
> > +
>
> Here and between the function prototype of 'tegra_bpmp_i2c_xfer' and
> it's function body is a unneeded blank line. Nitpick.
Thanks, fixed!
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-03-27 13:51 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-02 13:47 [RFC PATCH v2 0/7] i2c: core: introduce atomic transfers Wolfram Sang
2019-03-02 13:47 ` Wolfram Sang
2019-03-02 13:47 ` [RFC PATCH v2 1/7] i2c: apply coding style for struct i2c_adapter Wolfram Sang
2019-03-02 13:47 ` Wolfram Sang
2019-03-15 12:15 ` Simon Horman
2019-03-15 12:15 ` Simon Horman
2019-03-27 13:15 ` Wolfram Sang
2019-03-27 13:15 ` Wolfram Sang
2019-03-02 13:47 ` [RFC PATCH v2 2/7] i2c: core: use I2C locking behaviour also for SMBUS Wolfram Sang
2019-03-02 13:47 ` Wolfram Sang
2019-03-02 13:47 ` Wolfram Sang
2019-03-04 12:35 ` Geert Uytterhoeven
2019-03-04 12:35 ` Geert Uytterhoeven
2019-03-15 12:17 ` Simon Horman
2019-03-15 12:17 ` Simon Horman
2019-03-02 13:47 ` [RFC PATCH v2 3/7] i2c: core: introduce callbacks for atomic transfers Wolfram Sang
2019-03-02 13:47 ` Wolfram Sang
2019-03-02 13:47 ` Wolfram Sang
2019-03-15 12:23 ` Simon Horman
2019-03-15 12:23 ` Simon Horman
2019-03-15 12:23 ` Simon Horman
2019-03-27 13:47 ` Wolfram Sang
2019-03-27 13:47 ` Wolfram Sang
2019-03-29 9:45 ` Simon Horman
2019-03-29 9:45 ` Simon Horman
2019-03-02 13:47 ` [RFC PATCH v2 4/7] i2c: demux: WIP: handle the new atomic callbacks Wolfram Sang
2019-03-02 13:47 ` Wolfram Sang
2019-03-02 13:47 ` Wolfram Sang
2019-03-15 12:32 ` Simon Horman
2019-03-15 12:32 ` Simon Horman
2019-03-02 13:47 ` [RFC PATCH v2 5/7] i2c: busses: omap: Add the master_xfer_irqless hook Wolfram Sang
2019-03-02 13:47 ` Wolfram Sang
2019-03-15 12:47 ` Simon Horman
2019-03-15 12:47 ` Simon Horman
2019-03-15 12:47 ` Simon Horman
2019-03-15 13:14 ` Andy Shevchenko
2019-03-15 13:14 ` Andy Shevchenko
2019-03-27 13:50 ` Wolfram Sang
2019-03-27 13:50 ` Wolfram Sang
2019-03-29 9:45 ` Simon Horman
2019-03-29 9:45 ` Simon Horman
2019-03-02 13:47 ` [RFC PATCH v2 6/7] i2c: tegra-bpmp: convert to use new atomic callbacks Wolfram Sang
2019-03-02 13:47 ` Wolfram Sang
2019-03-04 12:25 ` Timo Alho
2019-03-04 12:25 ` Timo Alho
2019-03-04 12:59 ` Thierry Reding
2019-03-04 12:59 ` Thierry Reding
2019-03-15 12:42 ` Simon Horman
2019-03-15 12:42 ` Simon Horman
2019-03-26 20:20 ` Stefan Lengfeld
2019-03-26 20:20 ` Stefan Lengfeld
2019-03-26 20:20 ` Stefan Lengfeld
2019-03-27 13:51 ` Wolfram Sang [this message]
2019-03-27 13:51 ` Wolfram Sang
2019-03-02 13:47 ` [RFC PATCH v2 7/7] i2c: algo: bit: HACK! add atomic callback Wolfram Sang
2019-03-02 13:47 ` Wolfram Sang
2019-03-02 16:22 ` [RFC PATCH v2 0/7] i2c: core: introduce atomic transfers Andy Shevchenko
2019-03-02 16:22 ` Andy Shevchenko
2019-03-02 16:22 ` Andy Shevchenko
2019-03-12 15:45 ` Wolfram Sang
2019-03-12 15:45 ` Wolfram Sang
2019-03-25 13:40 ` Wolfram Sang
2019-03-25 13:40 ` Wolfram Sang
2019-03-04 18:11 ` Peter Rosin
2019-03-04 18:11 ` Peter Rosin
2019-03-04 22:48 ` Wolfram Sang
2019-03-04 22:48 ` Wolfram Sang
2019-03-07 0:02 ` Peter Rosin
2019-03-07 0:02 ` Peter Rosin
2019-03-27 13:53 ` Wolfram Sang
2019-03-27 13:53 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190327135114.GF5345@kunai \
--to=wsa@the-dreams.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=contact@stefanchrist.eu \
--cc=j-keerthy@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=peda@axentia.se \
--cc=preid@electromag.com.au \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.