* [PATCH] Staging: media: davinci_vpfe: Remove unused macros
@ 2019-03-27 17:21 Madhumitha Prabakaran
2019-03-27 18:36 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Madhumitha Prabakaran @ 2019-03-27 17:21 UTC (permalink / raw)
To: mchehab, gregkh, outreachy-kernel; +Cc: Madhumitha Prabakaran
Remove unused macros from kernel tree.
Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
---
drivers/staging/media/davinci_vpfe/dm365_isif_regs.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/media/davinci_vpfe/dm365_isif_regs.h b/drivers/staging/media/davinci_vpfe/dm365_isif_regs.h
index 6695680817b9..368c8a83a985 100644
--- a/drivers/staging/media/davinci_vpfe/dm365_isif_regs.h
+++ b/drivers/staging/media/davinci_vpfe/dm365_isif_regs.h
@@ -109,9 +109,6 @@
#define FMTLNV 0x128
#define FMTRLEN 0x12c
#define FMTHCNT 0x130
-#define FMTAPTR_BASE 0x134
-/* Below macro for addresses FMTAPTR0 - FMTAPTR15 */
-#define FMTAPTR(i) (FMTAPTR_BASE + (i * 4))
#define FMTPGMVF0 0x174
#define FMTPGMVF1 0x178
#define FMTPGMAPU0 0x17c
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Staging: media: davinci_vpfe: Remove unused macros
2019-03-27 17:21 [PATCH] Staging: media: davinci_vpfe: Remove unused macros Madhumitha Prabakaran
@ 2019-03-27 18:36 ` Greg KH
2019-03-27 20:35 ` Madhumthia Prabakaran
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2019-03-27 18:36 UTC (permalink / raw)
To: Madhumitha Prabakaran; +Cc: mchehab, outreachy-kernel
On Wed, Mar 27, 2019 at 12:21:50PM -0500, Madhumitha Prabakaran wrote:
> Remove unused macros from kernel tree.
That says shat you did, but why? What if someone wants to know this
information in the future? Deleting unused hardware description macros
isn't always a good thing to do, as sometimes that is the only way
people can find documentation on the chips involved.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Staging: media: davinci_vpfe: Remove unused macros
2019-03-27 18:36 ` Greg KH
@ 2019-03-27 20:35 ` Madhumthia Prabakaran
0 siblings, 0 replies; 3+ messages in thread
From: Madhumthia Prabakaran @ 2019-03-27 20:35 UTC (permalink / raw)
To: Greg KH, outreachy-kernel
On Thu, Mar 28, 2019 at 03:36:06AM +0900, Greg KH wrote:
> On Wed, Mar 27, 2019 at 12:21:50PM -0500, Madhumitha Prabakaran wrote:
> > Remove unused macros from kernel tree.
>
> That says shat you did, but why? What if someone wants to know this
> information in the future? Deleting unused hardware description macros
> isn't always a good thing to do, as sometimes that is the only way
> people can find documentation on the chips involved.
I will drop this one
Thanks
>
> thanks,
>
> greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-27 20:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-27 17:21 [PATCH] Staging: media: davinci_vpfe: Remove unused macros Madhumitha Prabakaran
2019-03-27 18:36 ` Greg KH
2019-03-27 20:35 ` Madhumthia Prabakaran
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.