All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: rjw@rjwysocki.net, linux-acpi@vger.kernel.org,
	Hanjun Guo <hanjun.guo@linaro.org>,
	Sudeep Holla <sudeep.holla@arm.com>,
	Robin Murphy <robin.murphy@arm.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] ACPI/IORT: set online numa node for smmuv3 device
Date: Thu, 28 Mar 2019 11:32:38 +0000	[thread overview]
Message-ID: <20190328113230.GA19628@red-moon> (raw)
In-Reply-To: <c0ba61db-0d99-0a50-92c6-cf6f9ad97872@huawei.com>

On Thu, Mar 21, 2019 at 02:08:47PM +0800, Kefeng Wang wrote:
> 
> On 2019/3/20 22:00, Lorenzo Pieralisi wrote:
> > On Wed, Mar 20, 2019 at 11:41:18AM +0000, Robin Murphy wrote:
> >> On 15/03/2019 02:19, Kefeng Wang wrote:
> >>> If there is only node 0 in system, but smmuv3 device is set to offline
> >>> node 1, parsed from proximity domain in SMMUv3 IORT table, it will lead
> >>> to following crash,
> >> Surely that's just a firmware bug? If node 1 doesn't exist in the system
> >> then AFAICS if we're presented with a device claiming to be on that node we
> >> can only assume the whole thing is bogus. Thus if we're going to work around
> >> it at all, it seems to me like we should reject the entire device rather
> >> than just bodging it to some other node.
> 
> Yes, I met this oops with a wrong IORT configuration,
> 
> > I suspect that's the same issue this thread addressed:
> >
> > https://lore.kernel.org/linux-pci/CAErSpo6S0qtR42tjGZrFu4aMFFyThx1hkHTSowTt6t3XerpHnA@mail.gmail.com/
> 
> and the situation mentioned above should will trigger this issue too.
> 
> If the node is offline, we can just return from
> arm_smmu_v3_set_proximity(),  any better way to fix this?

Add a return value to the set_promixity() callback and return failure on
hitting the issue above, therefore terminating device creation.

Thanks,
Lorenzo

WARNING: multiple messages have this Message-ID (diff)
From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: rjw@rjwysocki.net, linux-acpi@vger.kernel.org,
	Hanjun Guo <hanjun.guo@linaro.org>,
	Sudeep Holla <sudeep.holla@arm.com>,
	Robin Murphy <robin.murphy@arm.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] ACPI/IORT: set online numa node for smmuv3 device
Date: Thu, 28 Mar 2019 11:32:38 +0000	[thread overview]
Message-ID: <20190328113230.GA19628@red-moon> (raw)
In-Reply-To: <c0ba61db-0d99-0a50-92c6-cf6f9ad97872@huawei.com>

On Thu, Mar 21, 2019 at 02:08:47PM +0800, Kefeng Wang wrote:
> 
> On 2019/3/20 22:00, Lorenzo Pieralisi wrote:
> > On Wed, Mar 20, 2019 at 11:41:18AM +0000, Robin Murphy wrote:
> >> On 15/03/2019 02:19, Kefeng Wang wrote:
> >>> If there is only node 0 in system, but smmuv3 device is set to offline
> >>> node 1, parsed from proximity domain in SMMUv3 IORT table, it will lead
> >>> to following crash,
> >> Surely that's just a firmware bug? If node 1 doesn't exist in the system
> >> then AFAICS if we're presented with a device claiming to be on that node we
> >> can only assume the whole thing is bogus. Thus if we're going to work around
> >> it at all, it seems to me like we should reject the entire device rather
> >> than just bodging it to some other node.
> 
> Yes, I met this oops with a wrong IORT configuration,
> 
> > I suspect that's the same issue this thread addressed:
> >
> > https://lore.kernel.org/linux-pci/CAErSpo6S0qtR42tjGZrFu4aMFFyThx1hkHTSowTt6t3XerpHnA@mail.gmail.com/
> 
> and the situation mentioned above should will trigger this issue too.
> 
> If the node is offline, we can just return from
> arm_smmu_v3_set_proximity(),  any better way to fix this?

Add a return value to the set_promixity() callback and return failure on
hitting the issue above, therefore terminating device creation.

Thanks,
Lorenzo

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2019-03-28 11:32 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-15  2:19 [PATCH 0/2] fix issue when acpi smmuv3 device alloc offline node memory Kefeng Wang
2019-03-15  2:19 ` Kefeng Wang
2019-03-15  2:19 ` [PATCH 1/2] ACPI/IORT: set online numa node for smmuv3 device Kefeng Wang
2019-03-15  2:19   ` Kefeng Wang
2019-03-20 11:41   ` Robin Murphy
2019-03-20 11:41     ` Robin Murphy
2019-03-20 14:00     ` Lorenzo Pieralisi
2019-03-20 14:00       ` Lorenzo Pieralisi
2019-03-21  6:08       ` Kefeng Wang
2019-03-27 14:24         ` Kefeng Wang
2019-03-28 11:32         ` Lorenzo Pieralisi [this message]
2019-03-28 11:32           ` Lorenzo Pieralisi
2019-03-28 14:00           ` [PATCH v2] ACPI/IORT: Reject platform dev creation when dev set to wrong numa node Kefeng Wang
2019-03-28 14:00             ` Kefeng Wang
2019-03-28 13:59             ` Robin Murphy
2019-03-28 13:59               ` Robin Murphy
2019-03-28 14:29               ` Kefeng Wang
2019-03-28 14:29                 ` Kefeng Wang
2019-03-29  3:17             ` [PATCH RESEND " Kefeng Wang
2019-03-29  3:17               ` Kefeng Wang
2019-04-08 10:42               ` Lorenzo Pieralisi
2019-04-08 10:42                 ` Lorenzo Pieralisi
2019-04-08 10:42                 ` Lorenzo Pieralisi
2019-04-08 10:46               ` Lorenzo Pieralisi
2019-04-08 10:46                 ` Lorenzo Pieralisi
2019-04-08 10:46                 ` Lorenzo Pieralisi
2019-04-08 15:21                 ` [PATCH v3] ACPI/IORT: Reject platform device creation on NUMA node mapping failure Kefeng Wang
2019-04-08 15:21                   ` Kefeng Wang
2019-04-08 15:21                   ` Kefeng Wang
2019-04-16 17:02                   ` Lorenzo Pieralisi
2019-04-16 17:02                     ` Lorenzo Pieralisi
2019-04-16 17:02                     ` Lorenzo Pieralisi
2019-04-16 17:05                     ` Will Deacon
2019-04-16 17:05                       ` Will Deacon
2019-04-16 17:05                       ` Will Deacon
2019-03-15  2:19 ` [PATCH 2/2] ACPI: NUMA: show match info about PXM ID and offline/online node Kefeng Wang
2019-03-15  2:19   ` Kefeng Wang
2019-03-15  8:34   ` Kefeng Wang
2019-03-15  8:34     ` Kefeng Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190328113230.GA19628@red-moon \
    --to=lorenzo.pieralisi@arm.com \
    --cc=hanjun.guo@linaro.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=rjw@rjwysocki.net \
    --cc=robin.murphy@arm.com \
    --cc=sudeep.holla@arm.com \
    --cc=wangkefeng.wang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.