From: Baoquan He <bhe@redhat.com>
To: Oscar Salvador <osalvador@suse.de>
Cc: Michal Hocko <mhocko@kernel.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
rafael@kernel.org, akpm@linux-foundation.org, rppt@linux.ibm.com,
willy@infradead.org, fanc.fnst@cn.fujitsu.com
Subject: Re: [PATCH v3 2/2] drivers/base/memory.c: Rename the misleading parameter
Date: Fri, 29 Mar 2019 20:55:03 +0800 [thread overview]
Message-ID: <20190329125503.GK7627@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20190329093725.blpcyane33fnxvn7@d104.suse.de>
On 03/29/19 at 10:37am, Oscar Salvador wrote:
> On Fri, Mar 29, 2019 at 10:13:25AM +0100, Michal Hocko wrote:
> > On Fri 29-03-19 16:29:15, Baoquan He wrote:
> > > The input parameter 'phys_index' of memory_block_action() is actually
> > > the section number, but not the phys_index of memory_block. Fix it.
> >
> > I have tried to explain that the naming is mostly a relict from the past
> > than really a misleading name http://lkml.kernel.org/r/20190326093315.GL28406@dhcp22.suse.cz
> > Maybe it would be good to reflect that in the changelog
>
> I think that phys_device variable in remove_memory_section() is also a relict
> from the past, and it is no longer used.
> Neither node_id variable is used.
> Actually, unregister_memory_section() sets those two to 0 no matter what.
>
> Since we are cleaning up, I wonder if we can go a bit further and we can get
> rid of that as well.
Yes, certainly. I would like to post a new one to carry this.
next prev parent reply other threads:[~2019-03-29 12:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-29 8:29 [PATCH v3 1/2] mm/sparse: Clean up the obsolete code comment Baoquan He
2019-03-29 8:29 ` [PATCH v3 2/2] drivers/base/memory.c: Rename the misleading parameter Baoquan He
2019-03-29 9:13 ` Michal Hocko
2019-03-29 9:19 ` Baoquan He
2019-03-29 9:37 ` Oscar Salvador
2019-03-29 12:55 ` Baoquan He [this message]
2019-03-29 9:36 ` [PATCH v4 " Baoquan He
2019-03-29 10:32 ` Oscar Salvador
2019-03-29 10:43 ` Mukesh Ojha
2019-03-29 9:14 ` [PATCH v3 1/2] mm/sparse: Clean up the obsolete code comment Michal Hocko
2019-03-29 10:36 ` Oscar Salvador
2019-03-29 13:59 ` Baoquan He
2019-03-29 10:40 ` Mukesh Ojha
2019-03-30 9:50 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190329125503.GK7627@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=fanc.fnst@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=osalvador@suse.de \
--cc=rafael@kernel.org \
--cc=rppt@linux.ibm.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.