* [PATCH v2] staging: wilc1000: Avoid unnecessary braces around if.
@ 2019-03-29 4:22 Sanjana Sanikommu
2019-03-29 16:10 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Sanjana Sanikommu @ 2019-03-29 4:22 UTC (permalink / raw)
To: gregkh; +Cc: outreachy-kernel
Remove unnecessary brace around if statement.
Issue found using checkpatch.pl
WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: Sanjana Sanikommu <sanjana99reddy99@gmail.com>
---
Changes in v2:
Change the word in subject line from "else" to "if" statement.
Change the word in log message from "else" to "if" statement.
drivers/staging/wilc1000/host_interface.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
index a10c31bce07f..150ba033198f 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -1399,9 +1399,8 @@ int wilc_set_join_req(struct wilc_vif *vif, u8 *bssid, const u8 *ies,
if (ies) {
conn_info->req_ies_len = ies_len;
conn_info->req_ies = kmemdup(ies, ies_len, GFP_KERNEL);
- if (!conn_info->req_ies) {
+ if (!conn_info->req_ies)
return -ENOMEM;
- }
}
result = wilc_send_connect_wid(vif);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v2] staging: wilc1000: Avoid unnecessary braces around if.
2019-03-29 4:22 [PATCH v2] staging: wilc1000: Avoid unnecessary braces around if Sanjana Sanikommu
@ 2019-03-29 16:10 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2019-03-29 16:10 UTC (permalink / raw)
To: Sanjana Sanikommu; +Cc: outreachy-kernel
On Fri, Mar 29, 2019 at 09:52:26AM +0530, Sanjana Sanikommu wrote:
> Remove unnecessary brace around if statement.
> Issue found using checkpatch.pl
>
> WARNING: braces {} are not necessary for single statement blocks
>
> Signed-off-by: Sanjana Sanikommu <sanjana99reddy99@gmail.com>
> ---
> Changes in v2:
> Change the word in subject line from "else" to "if" statement.
> Change the word in log message from "else" to "if" statement.
Patch does not apply to my tree :(
Please rebase and resend.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-29 16:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-29 4:22 [PATCH v2] staging: wilc1000: Avoid unnecessary braces around if Sanjana Sanikommu
2019-03-29 16:10 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.