[PATCH v6 1/3] staging: vt6655: line over 80 characters.

[PATCH v6 1/3] staging: vt6655: line over 80 characters.

[Vatsala Narang]

Move function arguments that go over 80 characters a line to get rid of
checkpatch warning.

Signed-off-by: Vatsala Narang <vatsalanarang@gmail.com>
--- 
Changes in v6: 
 -fixed patch 1 and resent it
 drivers/staging/vt6655/rf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vt6655/rf.c b/drivers/staging/vt6655/rf.c
index 72475586a5ee..ad3970333390 100644
--- a/drivers/staging/vt6655/rf.c
+++ b/drivers/staging/vt6655/rf.c
@@ -748,7 +748,7 @@ bool RFvWriteWakeProgSyn(struct vnt_private *priv, unsigned char byRFType,
 	}
 
 	MACvSetMISCFifo(priv, MISCFIFO_SYNINFO_IDX,
-			(unsigned long)MAKEWORD(bySleepCount, byInitCount));
+		       	(unsigned long)MAKEWORD(bySleepCount, byInitCount));
 
 	return true;
 }
-- 
2.17.1

Re: [Outreachy kernel] [PATCH v6 1/3] staging: vt6655: line over 80 characters.

[Julia Lawall]

On Sat, 30 Mar 2019, Vatsala Narang wrote:

> Move function arguments that go over 80 characters a line to get rid of
> checkpatch warning.
>
> Signed-off-by: Vatsala Narang <vatsalanarang@gmail.com>
> ---
> Changes in v6:
>  -fixed patch 1 and resent it
>  drivers/staging/vt6655/rf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vt6655/rf.c b/drivers/staging/vt6655/rf.c
> index 72475586a5ee..ad3970333390 100644
> --- a/drivers/staging/vt6655/rf.c
> +++ b/drivers/staging/vt6655/rf.c
> @@ -748,7 +748,7 @@ bool RFvWriteWakeProgSyn(struct vnt_private *priv, unsigned char byRFType,
>  	}
>
>  	MACvSetMISCFifo(priv, MISCFIFO_SYNINFO_IDX,
> -			(unsigned long)MAKEWORD(bySleepCount, byInitCount));
> +		       	(unsigned long)MAKEWORD(bySleepCount, byInitCount));

The two lines look the same, although there are probably spacing
differences.  I think you have the wrong log message for this patch.

julia

>
>  	return true;
>  }
> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190329233147.27039-1-vatsalanarang%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] [PATCH v6 1/3] staging: vt6655: line over 80 characters.

[Vatsala Narang]

[-- Attachment #1.1: Type: text/plain, Size: 820 bytes --]

> Changes in v6: 

> >  -fixed patch 1 and resent it 
> >  drivers/staging/vt6655/rf.c | 2 +- 
> >  1 file changed, 1 insertion(+), 1 deletion(-) 
> > 
> > 
> >          MACvSetMISCFifo(priv, MISCFIFO_SYNINFO_IDX, 
> > -                        (unsigned long)MAKEWORD(bySleepCount, 
> byInitCount)); 
> > +                               (unsigned long)MAKEWORD(bySleepCount, 
> byInitCount)); 
>
> The two lines look the same, although there are probably spacing 
> differences.  I think you have the wrong log message for this patch. 
>
> julia 
>
> Apart from this when I rebased the earlier patch it was corrupted with 
multiple lines that were not present in the file,so I also removed those 
lines and i don't know why its not visible here .Anyways I will send this 
again with correct log message.
thanks 
Vatsala

[-- Attachment #1.2: Type: text/html, Size: 1111 bytes --]

Re: [PATCH v6 1/3] staging: vt6655: line over 80 characters.

[Greg KH]

On Sat, Mar 30, 2019 at 05:01:47AM +0530, Vatsala Narang wrote:
> Move function arguments that go over 80 characters a line to get rid of
> checkpatch warning.
> 
> Signed-off-by: Vatsala Narang <vatsalanarang@gmail.com>
> --- 
> Changes in v6: 
>  -fixed patch 1 and resent it
>  drivers/staging/vt6655/rf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Where are the other 3 patches in this series?

If you have to resend just one patch, just send one, but do not imply
that it is a longer series.  Remember, maintainers have almost no
context as they deal with hundreds of patches.  I have the short term
memory of a squirrel :)

greg k-h

Re: [PATCH v6 1/3] staging: vt6655: line over 80 characters.

[Vatsala Narang]

[-- Attachment #1.1: Type: text/plain, Size: 682 bytes --]



> Signed-off-by: Vatsala Narang <vatsal...@gmail.com <javascript:>> 
> > --- 
> > Changes in v6: 
> >  -fixed patch 1 and resent it 
> >  drivers/staging/vt6655/rf.c | 2 +- 
> >  1 file changed, 1 insertion(+), 1 deletion(-) 
>
> Where are the other 3 patches in this series? 
>
> If you have to resend just one patch, just send one, but do not imply 
> that it is a longer series.  Remember, maintainers have almost no 
> context as they deal with hundreds of patches.  I have the short term 
> memory of a squirrel :) 
>
> greg k-h 
>

Thanks greg for correcting me.Things are getting clear day by day.I will be 
more careful next time while sending patchsets.
thanks 
Vatsala


[-- Attachment #1.2: Type: text/html, Size: 1160 bytes --]