From: Borislav Petkov <bp@alien8.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Erwan Velu <e.velu@criteo.com>, Len Brown <lenb@kernel.org>,
linux-pm@vger.kernel.org,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Viresh Kumar <viresh.kumar@linaro.org>
Subject: [PATCH] cpufreq/intel_pstate: Do not issue the not supported message on !Intel
Date: Sat, 30 Mar 2019 11:02:25 +0100 [thread overview]
Message-ID: <20190330100225.14744-1-bp@alien8.de> (raw)
From: Borislav Petkov <bp@suse.de>
Issue the CPU-not-supported message only on Intel machines as this
driver is Intel-only. Which means, the print statement can remain
KERN_INFO for ease of debugging (no need to enable it first in dynamic
debug).
While at it, correct it to say CPU "model" which is what that test does.
Fixes: 076b862c7e44 ("cpufreq: intel_pstate: Add reasons for failure and debug messages")
Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: Erwan Velu <e.velu@criteo.com>
Cc: Len Brown <lenb@kernel.org>
Cc: linux-pm@vger.kernel.org
Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
CC: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: Viresh Kumar <viresh.kumar@linaro.org>
---
drivers/cpufreq/intel_pstate.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
index ea62e3f02d56..19854f01e2fa 100644
--- a/drivers/cpufreq/intel_pstate.c
+++ b/drivers/cpufreq/intel_pstate.c
@@ -2608,7 +2608,9 @@ static int __init intel_pstate_init(void)
} else {
id = x86_match_cpu(intel_pstate_cpu_ids);
if (!id) {
- pr_info("CPU ID not supported\n");
+ if (boot_cpu_data.x86_vendor == X86_VENDOR_INTEL)
+ pr_info("CPU model not supported\n");
+
return -ENODEV;
}
--
2.21.0
next reply other threads:[~2019-03-30 10:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-30 10:02 Borislav Petkov [this message]
2019-04-01 8:11 ` [PATCH] cpufreq/intel_pstate: Do not issue the not supported message on !Intel Erwan Velu
2019-04-01 8:39 ` Borislav Petkov
2019-04-01 15:03 ` [PATCH] cpufreq/intel_pstate: Load only on Intel hardware Borislav Petkov
2019-04-01 15:05 ` Erwan Velu
2019-04-01 15:18 ` Thomas Renninger
2019-04-02 8:38 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190330100225.14744-1-bp@alien8.de \
--to=bp@alien8.de \
--cc=e.velu@criteo.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.