From: Thomas Renninger <trenn@suse.de>
To: Borislav Petkov <bp@alien8.de>
Cc: Erwan Velu <e.velu@criteo.com>,
LKML <linux-kernel@vger.kernel.org>, Len Brown <lenb@kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Viresh Kumar <viresh.kumar@linaro.org>
Subject: Re: [PATCH] cpufreq/intel_pstate: Load only on Intel hardware
Date: Mon, 01 Apr 2019 17:18:49 +0200 [thread overview]
Message-ID: <9389251.Bs5y7Thn0n@house> (raw)
In-Reply-To: <20190401150345.GJ28264@zn.tnic>
On Monday, April 1, 2019 5:03:45 PM CEST Borislav Petkov wrote:
> From: Borislav Petkov <bp@suse.de>
>
> This driver is Intel-only so loading on anything which is not Intel is
> pointless. Prevent it from doing so.
Nice.
I wondered whether there are more of these to find by review, instead
of waiting for the next message to show up.
I ended up in the "not so straight forward" IOMMU init macros... and
continued with daily work again.
Anyway there are a lot files showing up when grepping the kernel for
intel files/drivers, maybe someone who is involved in the one or other comes
up with something similar...
Thomas
FWIW:
Reviewed-by: Thomas Renninger <trenn@suse.de>
> While at it, correct the "not supported" print statement to say CPU
> "model" which is what that test does.
>
> Suggested-by: Erwan Velu <e.velu@criteo.com>
> Signed-off-by: Borislav Petkov <bp@suse.de>
> Cc: Len Brown <lenb@kernel.org>
> Cc: linux-pm@vger.kernel.org
> Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> CC: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> drivers/cpufreq/intel_pstate.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> index b599c7318aab..2986119dd31f 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -2596,6 +2596,9 @@ static int __init intel_pstate_init(void)
> const struct x86_cpu_id *id;
> int rc;
>
> + if (boot_cpu_data.x86_vendor != X86_VENDOR_INTEL)
> + return -ENODEV;
> +
...
next prev parent reply other threads:[~2019-04-01 15:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-30 10:02 [PATCH] cpufreq/intel_pstate: Do not issue the not supported message on !Intel Borislav Petkov
2019-04-01 8:11 ` Erwan Velu
2019-04-01 8:39 ` Borislav Petkov
2019-04-01 15:03 ` [PATCH] cpufreq/intel_pstate: Load only on Intel hardware Borislav Petkov
2019-04-01 15:05 ` Erwan Velu
2019-04-01 15:18 ` Thomas Renninger [this message]
2019-04-02 8:38 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9389251.Bs5y7Thn0n@house \
--to=trenn@suse.de \
--cc=bp@alien8.de \
--cc=e.velu@criteo.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.