From: Ming Lei <ming.lei@redhat.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, Ming Lei <ming.lei@redhat.com>,
James Smart <james.smart@broadcom.com>,
Bart Van Assche <bart.vanassche@wdc.com>,
linux-scsi@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Christoph Hellwig <hch@lst.de>,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
jianchao wang <jianchao.w.wang@oracle.com>
Subject: [PATCH 1/5] blk-mq: re-organize blk_mq_exit_hctx() into two parts
Date: Sun, 31 Mar 2019 11:09:50 +0800 [thread overview]
Message-ID: <20190331030954.22320-2-ming.lei@redhat.com> (raw)
In-Reply-To: <20190331030954.22320-1-ming.lei@redhat.com>
This patch re-organizes blk_mq_exit_hctx() into two parts, and
one part is for exit hctx, and another part is for free hw queue.
No function change, just prepare for fixing hctx lifetime issue.
Cc: James Smart <james.smart@broadcom.com>
Cc: Bart Van Assche <bart.vanassche@wdc.com>
Cc: linux-scsi@vger.kernel.org,
Cc: Martin K . Petersen <martin.petersen@oracle.com>,
Cc: Christoph Hellwig <hch@lst.de>,
Cc: James E . J . Bottomley <jejb@linux.vnet.ibm.com>,
Cc: jianchao wang <jianchao.w.wang@oracle.com>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
---
block/blk-mq.c | 16 +++++++++++-----
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/block/blk-mq.c b/block/blk-mq.c
index 70b210a308c4..53265ce45238 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -2229,6 +2229,16 @@ static void blk_mq_remove_cpuhp(struct blk_mq_hw_ctx *hctx)
&hctx->cpuhp_dead);
}
+static void blk_mq_free_hctx(struct request_queue *q,
+ struct blk_mq_hw_ctx *hctx)
+{
+ if (hctx->flags & BLK_MQ_F_BLOCKING)
+ cleanup_srcu_struct(hctx->srcu);
+
+ blk_free_flush_queue(hctx->fq);
+ sbitmap_free(&hctx->ctx_map);
+}
+
/* hctx->ctxs will be freed in queue's release handler */
static void blk_mq_exit_hctx(struct request_queue *q,
struct blk_mq_tag_set *set,
@@ -2243,12 +2253,7 @@ static void blk_mq_exit_hctx(struct request_queue *q,
if (set->ops->exit_hctx)
set->ops->exit_hctx(hctx, hctx_idx);
- if (hctx->flags & BLK_MQ_F_BLOCKING)
- cleanup_srcu_struct(hctx->srcu);
-
blk_mq_remove_cpuhp(hctx);
- blk_free_flush_queue(hctx->fq);
- sbitmap_free(&hctx->ctx_map);
}
static void blk_mq_exit_hw_queues(struct request_queue *q,
@@ -2262,6 +2267,7 @@ static void blk_mq_exit_hw_queues(struct request_queue *q,
break;
blk_mq_debugfs_unregister_hctx(hctx);
blk_mq_exit_hctx(q, set, hctx, i);
+ blk_mq_free_hctx(q, hctx);
}
}
--
2.9.5
next prev parent reply other threads:[~2019-03-31 3:11 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-31 3:09 [PATCH 0/5] blk-mq: allow to run queue if queue refcount is held Ming Lei
2019-03-31 3:09 ` Ming Lei [this message]
2019-04-01 1:40 ` [PATCH 1/5] blk-mq: re-organize blk_mq_exit_hctx() into two parts Dongli Zhang
2019-04-01 2:06 ` Ming Lei
2019-03-31 3:09 ` [PATCH 2/5] blk-mq: re-organize blk_mq_exit_hw_queues() " Ming Lei
2019-03-31 3:09 ` [PATCH 3/5] blk-mq: free hw queues in queue's release handler Ming Lei
2019-03-31 3:09 ` [PATCH 4/5] block: don't drain in-progress dispatch in blk_cleanup_queue() Ming Lei
2019-04-01 1:50 ` Dongli Zhang
2019-04-01 2:08 ` Ming Lei
2019-03-31 3:09 ` [PATCH 5/5] SCSI: don't grab queue usage counter before run queue Ming Lei
2019-04-01 1:53 ` Dongli Zhang
2019-03-31 15:27 ` [PATCH 0/5] blk-mq: allow to run queue if queue refcount is held Bart Van Assche
2019-04-01 2:00 ` Ming Lei
2019-04-01 2:39 ` Bart Van Assche
2019-04-01 2:44 ` jianchao.wang
2019-04-02 18:07 ` Bart Van Assche
2019-04-01 2:52 ` Ming Lei
2019-04-01 3:25 ` jianchao.wang
2019-04-01 3:28 ` Ming Lei
2019-04-01 9:19 ` jianchao.wang
2019-04-01 10:03 ` Ming Lei
2019-04-02 2:02 ` jianchao.wang
2019-04-02 2:55 ` Ming Lei
2019-04-02 8:07 ` jianchao.wang
2019-04-02 11:05 ` Ming Lei
2019-04-02 17:53 ` Bart Van Assche
2019-04-03 3:20 ` Ming Lei
2019-04-03 8:29 ` Ming Lei
2019-04-03 8:43 ` Ming Lei
2019-04-02 18:11 ` Bart Van Assche
2019-04-03 3:24 ` Ming Lei
2019-04-01 5:05 ` Dongli Zhang
2019-04-01 5:16 ` Ming Lei
2019-04-01 5:30 ` Dongli Zhang
2019-04-01 7:15 ` Ming Lei
2019-04-02 2:10 ` Dongli Zhang
2019-04-02 2:20 ` Ming Lei
2019-04-01 3:27 ` Ming Lei
2019-04-01 3:32 ` jianchao.wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190331030954.22320-2-ming.lei@redhat.com \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=bart.vanassche@wdc.com \
--cc=hch@lst.de \
--cc=james.smart@broadcom.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=jianchao.w.wang@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.