From: Ming Lei <ming.lei@redhat.com>
To: Dongli Zhang <dongli.zhang@oracle.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org,
James Smart <james.smart@broadcom.com>,
Bart Van Assche <bart.vanassche@wdc.com>,
linux-scsi@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Christoph Hellwig <hch@lst.de>,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
jianchao wang <jianchao.w.wang@oracle.com>
Subject: Re: [PATCH 4/5] block: don't drain in-progress dispatch in blk_cleanup_queue()
Date: Mon, 1 Apr 2019 10:08:15 +0800 [thread overview]
Message-ID: <20190401020814.GD30776@ming.t460p> (raw)
In-Reply-To: <658802bd-99a5-6446-5059-8536febba05e@oracle.com>
On Mon, Apr 01, 2019 at 09:50:12AM +0800, Dongli Zhang wrote:
>
>
> On 3/31/19 11:09 AM, Ming Lei wrote:
> > Now freeing dispatch resource is moved to queue's release handler,
> > we don't need to worry about the race between blk_cleanup_queue and
> > run queue any more.
> >
> > So don't drain in-progress dispatch in blk_cleanup_queue().
>
> Unless this direction is not followed, how about we mention that this is revert
> of prior two fixes (which are not required any longer) so that people working on
> backport would feel much more easier to track the issue.
>
> c2856ae2f315 ("blk-mq: quiesce queue before freeing queue")
> 1311326cf4755c7 ("blk-mq: avoid to synchronize rcu inside blk_cleanup_queue()")
OK, will mention that in V2.
Thanks,
Ming
next prev parent reply other threads:[~2019-04-01 2:08 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-31 3:09 [PATCH 0/5] blk-mq: allow to run queue if queue refcount is held Ming Lei
2019-03-31 3:09 ` [PATCH 1/5] blk-mq: re-organize blk_mq_exit_hctx() into two parts Ming Lei
2019-04-01 1:40 ` Dongli Zhang
2019-04-01 2:06 ` Ming Lei
2019-03-31 3:09 ` [PATCH 2/5] blk-mq: re-organize blk_mq_exit_hw_queues() " Ming Lei
2019-03-31 3:09 ` [PATCH 3/5] blk-mq: free hw queues in queue's release handler Ming Lei
2019-03-31 3:09 ` [PATCH 4/5] block: don't drain in-progress dispatch in blk_cleanup_queue() Ming Lei
2019-04-01 1:50 ` Dongli Zhang
2019-04-01 2:08 ` Ming Lei [this message]
2019-03-31 3:09 ` [PATCH 5/5] SCSI: don't grab queue usage counter before run queue Ming Lei
2019-04-01 1:53 ` Dongli Zhang
2019-03-31 15:27 ` [PATCH 0/5] blk-mq: allow to run queue if queue refcount is held Bart Van Assche
2019-04-01 2:00 ` Ming Lei
2019-04-01 2:39 ` Bart Van Assche
2019-04-01 2:44 ` jianchao.wang
2019-04-02 18:07 ` Bart Van Assche
2019-04-01 2:52 ` Ming Lei
2019-04-01 3:25 ` jianchao.wang
2019-04-01 3:28 ` Ming Lei
2019-04-01 9:19 ` jianchao.wang
2019-04-01 10:03 ` Ming Lei
2019-04-02 2:02 ` jianchao.wang
2019-04-02 2:55 ` Ming Lei
2019-04-02 8:07 ` jianchao.wang
2019-04-02 11:05 ` Ming Lei
2019-04-02 17:53 ` Bart Van Assche
2019-04-03 3:20 ` Ming Lei
2019-04-03 8:29 ` Ming Lei
2019-04-03 8:43 ` Ming Lei
2019-04-02 18:11 ` Bart Van Assche
2019-04-03 3:24 ` Ming Lei
2019-04-01 5:05 ` Dongli Zhang
2019-04-01 5:16 ` Ming Lei
2019-04-01 5:30 ` Dongli Zhang
2019-04-01 7:15 ` Ming Lei
2019-04-02 2:10 ` Dongli Zhang
2019-04-02 2:20 ` Ming Lei
2019-04-01 3:27 ` Ming Lei
2019-04-01 3:32 ` jianchao.wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190401020814.GD30776@ming.t460p \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=bart.vanassche@wdc.com \
--cc=dongli.zhang@oracle.com \
--cc=hch@lst.de \
--cc=james.smart@broadcom.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=jianchao.w.wang@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.