From: Pavel Machek <pavel@ucw.cz>
To: Colin King <colin.king@canonical.com>
Cc: Jan-Simon Moeller <jansimon.moeller@gmx.de>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
linux-leds@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] leds: blinkm: clean up double assignment to data->i2c_addr
Date: Sun, 31 Mar 2019 18:38:22 +0000 [thread overview]
Message-ID: <20190331183822.GA7642@amd> (raw)
In-Reply-To: <20190330203757.8877-1-colin.king@canonical.com>
[-- Attachment #1: Type: text/plain, Size: 540 bytes --]
On Sat 2019-03-30 20:37:57, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently data->i2c_addr is being assigned twice, first with the
> value 0x09 and then immediately afterwards with the value 0x08.
> The first assignment is redundant and can be removed.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: Colin King <colin.king@canonical.com>
Cc: Jan-Simon Moeller <jansimon.moeller@gmx.de>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
linux-leds@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] leds: blinkm: clean up double assignment to data->i2c_addr
Date: Sun, 31 Mar 2019 20:38:22 +0200 [thread overview]
Message-ID: <20190331183822.GA7642@amd> (raw)
In-Reply-To: <20190330203757.8877-1-colin.king@canonical.com>
[-- Attachment #1: Type: text/plain, Size: 540 bytes --]
On Sat 2019-03-30 20:37:57, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently data->i2c_addr is being assigned twice, first with the
> value 0x09 and then immediately afterwards with the value 0x08.
> The first assignment is redundant and can be removed.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2019-03-31 18:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-30 20:37 [PATCH] leds: blinkm: clean up double assignment to data->i2c_addr Colin King
2019-03-31 7:18 ` Mukesh Ojha
2019-03-31 7:30 ` Mukesh Ojha
2019-03-31 18:38 ` Pavel Machek [this message]
2019-03-31 18:38 ` Pavel Machek
2019-04-02 19:05 ` Jacek Anaszewski
2019-04-02 19:05 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190331183822.GA7642@amd \
--to=pavel@ucw.cz \
--cc=colin.king@canonical.com \
--cc=jacek.anaszewski@gmail.com \
--cc=jansimon.moeller@gmx.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.