From: Bin Liu <b-liu@ti.com>
To: Paul Cercueil <paul@crapouillou.net>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, od@zcrc.me
Subject: usb: musb: Force-disable pullup on shutdown
Date: Mon, 1 Apr 2019 12:17:25 -0500 [thread overview]
Message-ID: <20190401171725.GK25852@uda0271908> (raw)
On Thu, Mar 21, 2019 at 03:42:46PM +0100, Paul Cercueil wrote:
> When the musb is shutdown, for instance when the driver is unloaded,
> force-disable the pullup. Otherwise, the host will still see the gadget
> device even after the shutdown.
how would this happen?
when musb-hdrc driver is unloaded, udc core removes the bound gadget
driver which calls musb_gadget_pullup() to disable the pullup.
Regards,
-Bin.
WARNING: multiple messages have this Message-ID (diff)
From: Bin Liu <b-liu@ti.com>
To: Paul Cercueil <paul@crapouillou.net>
Cc: <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<od@zcrc.me>
Subject: Re: [PATCH] usb: musb: Force-disable pullup on shutdown
Date: Mon, 1 Apr 2019 12:17:25 -0500 [thread overview]
Message-ID: <20190401171725.GK25852@uda0271908> (raw)
In-Reply-To: <20190321144246.3547-1-paul@crapouillou.net>
On Thu, Mar 21, 2019 at 03:42:46PM +0100, Paul Cercueil wrote:
> When the musb is shutdown, for instance when the driver is unloaded,
> force-disable the pullup. Otherwise, the host will still see the gadget
> device even after the shutdown.
how would this happen?
when musb-hdrc driver is unloaded, udc core removes the bound gadget
driver which calls musb_gadget_pullup() to disable the pullup.
Regards,
-Bin.
next reply other threads:[~2019-04-01 17:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-01 17:17 Bin Liu [this message]
2019-04-01 17:17 ` [PATCH] usb: musb: Force-disable pullup on shutdown Bin Liu
-- strict thread matches above, loose matches on Subject: below --
2019-04-03 18:54 Bin Liu
2019-04-03 18:54 ` [PATCH] " Bin Liu
2019-04-03 15:52 Paul Cercueil
2019-04-03 15:52 ` [PATCH] " Paul Cercueil
2019-04-03 15:46 Bin Liu
2019-04-03 15:46 ` [PATCH] " Bin Liu
2019-04-03 15:31 Paul Cercueil
2019-04-03 15:31 ` [PATCH] " Paul Cercueil
2019-04-03 13:26 Bin Liu
2019-04-03 13:26 ` [PATCH] " Bin Liu
2019-04-02 19:58 Paul Cercueil
2019-04-02 19:58 ` [PATCH] " Paul Cercueil
2019-04-01 18:20 Bin Liu
2019-04-01 18:20 ` [PATCH] " Bin Liu
2019-04-01 17:46 Paul Cercueil
2019-04-01 17:46 ` [PATCH] " Paul Cercueil
2019-03-21 14:42 Paul Cercueil
2019-03-21 14:42 ` [PATCH] " Paul Cercueil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190401171725.GK25852@uda0271908 \
--to=b-liu@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=od@zcrc.me \
--cc=paul@crapouillou.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.